Merge pull request #182 from JeremyWuuuuu/bugfix/unmounting-on-multi-root

bugfix/unmounting-on-multi-root

Author: lmiller1990

src/vueWrapper.ts

@@ -216,10 +216,7 @@ export class VueWrapper<T extends ComponentPublicInstance> {
       )
     }
 
-    if (this.parentElement) {
-      this.parentElement.removeChild(this.element)
-    }
-    this.__app.unmount(this.element)
+    this.__app.unmount(this.parentElement)
   }
 }
 

tests/unmount.spec.ts

@@ -0,0 +1,44 @@
+import { defineComponent } from 'vue'
+
+import { mount } from '../src'
+
+describe('Unmount', () => {
+  it('works on single root component', () => {
+    const errorHandler = jest.fn()
+    const Component = {
+      template: `
+        <div></div>
+      `
+    }
+    const wrapper = mount(Component, {
+      props: {},
+      global: {
+        config: {
+          errorHandler
+        }
+      }
+    } as any) // The type checking keeps complaning about unmatched type which might be a bug
+    wrapper.unmount()
+    expect(errorHandler).not.toHaveBeenCalled()
+  })
+
+  it('works on multi-root component', () => {
+    const errorHandler = jest.fn()
+    const Component = defineComponent({
+      template: `
+        <div></div>
+        <div></div>
+      `
+    })
+    const wrapper = mount(Component, {
+      props: {},
+      global: {
+        config: {
+          errorHandler
+        }
+      }
+    } as any)
+    wrapper.unmount()
+    expect(errorHandler).not.toHaveBeenCalled()
+  })
+})