Skip to content

feat: use minify function exposed from Vite for Vite 8+ #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sapphi-red wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

feat: use minify function exposed from Vite for Vite 8+ #5048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/node/build/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,11 @@ export async function build(
) {
const start = Date.now()

// @ts-ignore only exists for rolldown-vite
if (vite.rolldownVersion) {
if (
!vite.version.startsWith('8.') &&
// @ts-ignore only exists for rolldown-vite
vite.rolldownVersion
) {
try {
await import('oxc-minify')
} catch {
Expand Down
8 changes: 6 additions & 2 deletions src/node/build/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,12 @@ function renderAttrs(attrs: Record<string, string>): string {
}

async function minifyScript(code: string, filename: string): Promise<string> {
// @ts-ignore use oxc-minify when rolldown-vite is used
if (vite.rolldownVersion) {
if (vite.version.startsWith('8.')) {
// @ts-ignore minify is available in vite 8
const minify = vite.minify
return (await minify(filename, code)).code.trim()
// @ts-ignore use oxc-minify when rolldown-vite is used
} else if (vite.rolldownVersion) {
const oxcMinify = await import('oxc-minify')
return (await oxcMinify.minify(filename, code)).code.trim()
}
Expand Down