Skip to content

Commit 5ff7198

Browse files
author
Guillaume Chau
committed
feat(file-diff): less obnoxious loading UX
1 parent c8a53a4 commit 5ff7198

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

packages/@vue/cli-ui/src/components/file-diff/FileDiffView.vue

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44
<VueIcon icon="cached"/>
55
<div class="title">{{ $t('org.vue.components.file-diff-view.files-changed') }}</div>
66
<div class="file-count">{{ fileDiffs && fileDiffs.length }}</div>
7+
<transition name="vue-ui-fade">
8+
<VueLoadingIndicator
9+
v-if="loading && fileDiffs.length"
10+
class="small accent"
11+
/>
12+
</transition>
713
<div class="vue-ui-spacer"/>
814
<VueInput
915
v-model="search"
@@ -76,8 +82,8 @@
7682

7783
<transition name="vue-ui-fade">
7884
<VueLoadingIndicator
79-
v-if="loading"
80-
class="overlay"
85+
v-if="loading && !fileDiffs.length"
86+
class="accent big overlay"
8187
/>
8288
</transition>
8389

0 commit comments

Comments
 (0)