Skip to content

Commit 6e29daa

Browse files
committed
chore: cleanup comments
1 parent d84df9a commit 6e29daa

File tree

7 files changed

+11
-18
lines changed

7 files changed

+11
-18
lines changed

packages/@vue/cli-plugin-unit-jest/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ module.exports = api => {
1414
process.env.VUE_CLI_BABEL_TARGET_NODE = true
1515
process.env.VUE_CLI_BABEL_TRANSPILE_MODULES = true
1616

17-
// TODO execa jest w/ --config jest.config.js
1817
const execa = require('execa')
1918
const jestBinPath = require.resolve('jest/bin/jest')
2019

packages/@vue/cli-service/lib/commands/build.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// TODO handle alternative build targets
2-
31
const defaults = {
42
mode: 'production',
53
target: 'app'
@@ -10,8 +8,9 @@ module.exports = (api, options) => {
108
description: 'build for production',
119
usage: 'vue-cli-service build [options]',
1210
options: {
13-
'--mode': `specify env mode (default: ${defaults.mode})`,
14-
'--target': `app | library | web-component (default: ${defaults.target})`
11+
// TODO
12+
// '--mode': `specify env mode (default: ${defaults.mode})`,
13+
// '--target': `app | library | web-component (default: ${defaults.target})`
1514
}
1615
}, args => {
1716
api.setMode(args.mode || defaults.mode)
@@ -46,8 +45,7 @@ module.exports = (api, options) => {
4645
process.stdout.write(stats.toString({
4746
colors: true,
4847
modules: false,
49-
// TODO set this to true if using TS
50-
children: false,
48+
children: api.hasPlugin('typescript'),
5149
chunks: false,
5250
chunkModules: false
5351
}) + '\n\n')

packages/@vue/cli-service/lib/commands/serve.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ module.exports = (api, options) => {
108108
} else {
109109
console.log(` App is served in production mode.`)
110110
console.log(` Note this is for preview or E2E testing only.`)
111-
// TODO console.log(` See URL for more deployment tips.`)
112111
}
113112
console.log()
114113

packages/@vue/cli-service/lib/config/css.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ module.exports = (api, options) => {
8080
}, userOptions)])
8181
}
8282

83-
// TODO document receipe for adding sass-resource-loader
83+
// TODO document receipe for using css.loaderOptions to add `data` option
84+
// to sass-loader
8485
})
8586
}

packages/@vue/cli-service/lib/config/prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ module.exports = (api, options) => {
121121
ignore: ['index.html', '.*']
122122
}]])
123123

124-
// TODO investigate DLL plugin options
124+
// TODO investigate happypack/cache-loader/DLL plugin options
125125
}
126126
})
127127
}

packages/@vue/cli/lib/promptModules/linter.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ module.exports = cli => {
55
cli.injectFeature({
66
name: 'Linter / Formatter',
77
value: 'linter',
8-
short: 'Linter',
9-
checked: true
8+
short: 'Linter'
109
})
1110

1211
cli.injectPrompt({
@@ -49,13 +48,11 @@ module.exports = cli => {
4948
choices: [
5049
{
5150
name: 'Lint on save',
52-
value: 'save',
53-
checked: true
51+
value: 'save'
5452
},
5553
{
5654
name: 'Lint and fix on commit' + (hasGit ? '' : chalk.red(' (requires Git)')),
57-
value: 'commit',
58-
checked: true
55+
value: 'commit'
5956
}
6057
]
6158
})

packages/@vue/cli/lib/promptModules/unit.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ module.exports = cli => {
22
cli.injectFeature({
33
name: 'Unit Testing',
44
value: 'unit',
5-
short: 'Unit',
6-
checked: true
5+
short: 'Unit'
76
})
87

98
cli.injectPrompt({

0 commit comments

Comments
 (0)