Skip to content

Commit b6cc787

Browse files
committed
ci: attempt to fix chromedriver for Appveyor
1 parent a7564d6 commit b6cc787

File tree

5 files changed

+18
-4
lines changed

5 files changed

+18
-4
lines changed

appveyor.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@ environment:
33

44
install:
55
- ps: Install-Product node $env:nodejs_version
6+
- yarn patch-chromedriver
67
- yarn --network-timeout 600000
78

89
test_script:
910
- git --version
1011
- node --version
1112
- yarn --version
1213
- yarn test
13-
- cd "packages/@vue/cli-ui" && yarn test
14+
# ui tests temporarily disabled due to Cypress 3.0 issue on windows
15+
# - cd "packages/@vue/cli-ui" && yarn test
1416

1517
cache:
1618
- node_modules -> yarn.lock

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
"boot": "node scripts/bootstrap.js",
1616
"release": "yarn clean && node scripts/release.js",
1717
"docs": "vuepress dev docs",
18-
"docs:build": "vuepress build docs"
18+
"docs:build": "vuepress build docs",
19+
"patch-chromedriver": "node scripts/patchChromedriver.js"
1920
},
2021
"gitHooks": {
2122
"pre-commit": "lint-staged",

packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module.exports = deepmerge({
1414
host: '127.0.0.1',
1515
port: 4444,
1616
cli_args: {
17-
'webdriver.chrome.driver': process.env.APPVEYOR ? '' : require('chromedriver').path
17+
'webdriver.chrome.driver': require('chromedriver').path
1818
}
1919
},
2020

packages/@vue/cli-plugin-typescript/__tests__/tsPluginE2e.spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ jest.setTimeout(process.env.APPVEYOR ? 850000 : 50000)
22

33
const create = require('@vue/cli-test-utils/createTestProject')
44

5-
// temporarily disabled on AppVeyor due to upstream issue
5+
// temporarily disabled on AppVeyor
6+
// due to Cypress upstream issue
67
// https://github.com/cypress-io/cypress/issues/1841
78
if (!process.env.APPVEYOR) {
89
test('cypress', async () => {

scripts/patchChromedriver.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// Appveyor current only ships Chrome 65
2+
// which is no longer supported by the latest version of Chromedriver.
3+
4+
const fs = require('fs')
5+
const path = require('path')
6+
const pkg = require('../package.json')
7+
8+
pkg.resolutions.chromedriver = '2.38.0'
9+
10+
fs.writeFileSync(path.resolve(__dirname, '../package.json'), JSON.stringify(pkg, null, 2))

0 commit comments

Comments
 (0)