fix(compiler): prevent handle comment node for v-slot

Author: zhiyuanzmj

.changeset/flat-snakes-destroy.md

@@ -0,0 +1,5 @@
+---
+'@vue-jsx-vapor/compiler': patch
+---
+
+prevent handle comment node for v-slot

packages/compiler/src/transforms/vSlot.ts

@@ -17,6 +17,7 @@ import {
 } from '../ir'
 import {
   findProp,
+  isEmptyText,
   isJSXComponent,
   isTemplate,
   resolveDirectiveNode,
@@ -70,8 +71,7 @@ function transformComponentSlot(
   const arg = dir && dir.arg
   const nonSlotTemplateChildren = children.filter(
     (n) =>
-      isNonWhitespaceContent(n) &&
-      !(n.type === 'JSXElement' && findProp(n, 'v-slot')),
+      !isEmptyText(n) && !(n.type === 'JSXElement' && findProp(n, 'v-slot')),
   )
 
   const [block, onExit] = createSlotBlock(node, dir, context)
@@ -242,10 +242,3 @@ function createSlotBlock(
   const exitBlock = context.enterBlock(block)
   return [block, exitBlock]
 }
-
-export function isNonWhitespaceContent(
-  node: JSXElement['children'][0],
-): boolean {
-  if (node.type !== 'JSXText') return true
-  return !!node.value.trim()
-}

packages/compiler/test/transforms/__snapshots__/vSlot.spec.ts.snap

@@ -79,6 +79,18 @@ exports[`compiler: transform slot > implicit default slot 1`] = `
 "
 `;
 
+exports[`compiler: transform slot > named slots w/ comment 1`] = `
+"
+  const n6 = _createComponent(Comp, null, {
+    "one": () => {
+      const n3 = t0()
+      return n3
+    }
+  })
+  return n6
+"
+`;
+
 exports[`compiler: transform slot > named slots w/ implicit default slot 1`] = `
 "
   const n6 = _createComponent(Comp, null, {

packages/compiler/test/transforms/vSlot.spec.ts

@@ -199,6 +199,17 @@ describe('compiler: transform slot', () => {
     ])
   })
 
+  test('named slots w/ comment', () => {
+    const { ir, code } = compileWithSlots(
+      `<Comp>
+        {/* foo */}
+        <template v-slot:one>foo</template>
+      </Comp>`,
+    )
+    expect(code).toMatchSnapshot()
+    expect(ir.block.operation[0].slots.length).toEqual(1)
+  })
+
   test('nested slots scoping', () => {
     const { ir, code } = compileWithSlots(
       `<Comp>