Skip to content

Commit 7605f7a

Browse files
committed
revert inline style module
1 parent c09259a commit 7605f7a

File tree

3 files changed

+51
-68
lines changed

3 files changed

+51
-68
lines changed

lib/template-compiler/index.js

Lines changed: 50 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -5,74 +5,69 @@ var beautify = require('js-beautify').js_beautify
55
var transpile = require('vue-template-es2015-compiler')
66
var hotReloadAPIPath = normalize.dep('vue-hot-reload-api')
77
var transformRequire = require('./modules/transform-require')
8-
var rewriteInlineStyles = require('./modules/inline-style')
98

109
module.exports = function (html) {
1110
this.cacheable()
12-
var cb = this.async()
1311
var isServer = this.target === 'node'
1412
var isProduction = this.minimize || process.env.NODE_ENV === 'production'
1513
var vueOptions = this.options.__vueOptions__ || {}
1614
var options = loaderUtils.getOptions(this) || {}
1715

18-
Promise.all([
19-
transformRequire(options.transformToRequire),
20-
rewriteInlineStyles()
21-
]).then(defaultCompilerModules => {
22-
// user compiler modules
23-
var userCompilerModules = options.compilerModules || vueOptions.compilerModules
24-
// for HappyPack cross-process use cases
25-
if (typeof userCompilerModules === 'string') {
26-
userCompilerModules = require(userCompilerModules)
27-
}
16+
var defaultModules = [transformRequire(options.transformToRequire)]
17+
var userModules = vueOptions.compilerModules || options.compilerModules
18+
// for HappyPack cross-process use cases
19+
if (typeof userModules === 'string') {
20+
userModules = require(userModules)
21+
}
2822

29-
var compiled = compiler.compile(html, {
30-
preserveWhitespace: options.preserveWhitespace,
31-
modules: defaultCompilerModules.concat(userCompilerModules || [])
32-
})
23+
var compilerOptions = {
24+
preserveWhitespace: options.preserveWhitespace,
25+
modules: defaultModules.concat(userModules || [])
26+
}
3327

34-
// tips
35-
if (compiled.tips && compiled.tips.length) {
36-
compiled.tips.forEach(tip => {
37-
this.emitWarning(tip)
38-
})
39-
}
28+
var compiled = compiler.compile(html, compilerOptions)
4029

41-
var code
42-
if (compiled.errors && compiled.errors.length) {
43-
this.emitError(
44-
`\n Error compiling template:\n${pad(html)}\n` +
45-
compiled.errors.map(e => ` - ${e}`).join('\n') + '\n'
46-
)
47-
code = 'module.exports={render:function(){},staticRenderFns:[]}'
48-
} else {
49-
var bubleOptions = options.buble
50-
code = transpile('module.exports={' +
51-
'render:' + toFunction(compiled.render) + ',' +
52-
'staticRenderFns: [' + compiled.staticRenderFns.map(toFunction).join(',') + ']' +
53-
'}', bubleOptions)
54-
// mark with stripped (this enables Vue to use correct runtime proxy detection)
55-
if (!isProduction && (
56-
!bubleOptions ||
57-
!bubleOptions.transforms ||
58-
bubleOptions.transforms.stripWith !== false
59-
)) {
60-
code += `\nmodule.exports.render._withStripped = true`
61-
}
62-
}
63-
// hot-reload
64-
if (!isServer && !isProduction) {
65-
code +=
66-
'\nif (module.hot) {\n' +
67-
' module.hot.accept()\n' +
68-
' if (module.hot.data) {\n' +
69-
' require("' + hotReloadAPIPath + '").rerender("' + options.id + '", module.exports)\n' +
70-
' }\n' +
71-
'}'
30+
// tips
31+
if (compiled.tips && compiled.tips.length) {
32+
compiled.tips.forEach(tip => {
33+
this.emitWarning(tip)
34+
})
35+
}
36+
37+
var code
38+
if (compiled.errors && compiled.errors.length) {
39+
this.emitError(
40+
`\n Error compiling template:\n${pad(html)}\n` +
41+
compiled.errors.map(e => ` - ${e}`).join('\n') + '\n'
42+
)
43+
code = 'module.exports={render:function(){},staticRenderFns:[]}'
44+
} else {
45+
var bubleOptions = options.buble
46+
code = transpile('module.exports={' +
47+
'render:' + toFunction(compiled.render) + ',' +
48+
'staticRenderFns: [' + compiled.staticRenderFns.map(toFunction).join(',') + ']' +
49+
'}', bubleOptions)
50+
// mark with stripped (this enables Vue to use correct runtime proxy detection)
51+
if (!isProduction && (
52+
!bubleOptions ||
53+
!bubleOptions.transforms ||
54+
bubleOptions.transforms.stripWith !== false
55+
)) {
56+
code += `\nmodule.exports.render._withStripped = true`
7257
}
58+
}
59+
// hot-reload
60+
if (!isServer && !isProduction) {
61+
code +=
62+
'\nif (module.hot) {\n' +
63+
' module.hot.accept()\n' +
64+
' if (module.hot.data) {\n' +
65+
' require("' + hotReloadAPIPath + '").rerender("' + options.id + '", module.exports)\n' +
66+
' }\n' +
67+
'}'
68+
}
7369

74-
cb(null, code)
75-
}).catch(cb)
70+
return code
7671
}
7772

7873
function toFunction (code) {

lib/template-compiler/modules/inline-style.js

Lines changed: 0 additions & 12 deletions
This file was deleted.

lib/template-compiler/modules/transform-require.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// vue compiler module for using transforming `<tag>:<attribute>` to `require`
1+
// vue compiler module for transforming `<tag>:<attribute>` to `require`
22

33
var defaultOptions = {
44
img: 'src',

0 commit comments

Comments
 (0)