Skip to content

Commit deee354

Browse files
committed
revert auto name-setting
1 parent 9e0ad9b commit deee354

File tree

5 files changed

+4
-31
lines changed

5 files changed

+4
-31
lines changed

lib/loader.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,6 @@ module.exports = function (content) {
181181
'if (typeof __vue_options__ === "function") {\n' +
182182
' __vue_options__ = __vue_options__.options\n' +
183183
'}\n' +
184-
// add name based on filename if not already set
185-
'__vue_options__.name = __vue_options__.name || ' + JSON.stringify(fileName.replace(/(\.vue|[^a-z0-9\-])/gi, '')) + '\n' +
186184
// add filename in dev
187185
(isProduction ? '' : ('__vue_options__.__file = ' + JSON.stringify(filePath))) + '\n'
188186

test/fixtures/named.vue

Lines changed: 0 additions & 9 deletions
This file was deleted.

test/fixtures/unnamed-5tr@ng3_f1l3n@me$.vue

Lines changed: 0 additions & 3 deletions
This file was deleted.

test/fixtures/unnamed.vue

Lines changed: 0 additions & 3 deletions
This file was deleted.

test/test.js

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -108,22 +108,12 @@ describe('vue-loader', function () {
108108
})
109109
})
110110

111-
it('automatic name setting based on filename', function (done) {
111+
it('expose filename', function (done) {
112112
test({
113-
entry: './test/fixtures/unnamed.vue'
113+
entry: './test/fixtures/basic.vue'
114114
}, function (window, module, rawModule) {
115-
expect(module.name).to.equal('unnamed')
116-
test({
117-
entry: './test/fixtures/named.vue'
118-
}, function (window, module, rawModule) {
119-
expect(module.name).to.equal('custom-name')
120-
test({
121-
entry: './test/fixtures/unnamed-5tr@ng3_f1l3n@me$.vue'
122-
}, function (window, module, rawModule) {
123-
expect(module.name).to.equal('unnamed-5trng3f1l3nme')
124-
done()
125-
})
126-
})
115+
expect(module.__file).to.equal(path.resolve(__dirname, './fixtures/basic.vue'))
116+
done()
127117
})
128118
})
129119

0 commit comments

Comments
 (0)