- add functional test for validation using filters

Evan You · Evan You · commit 15d54e9fdc98 · 2013-11-15T13:14:38.000-05:00
- filter functions now have a `this` context of the VM calling it.
diff --git a/src/directive.js b/src/directive.js
@@ -174,7 +174,7 @@ DirProto.applyFilters = function (value) {
     var filtered = value, filter
     for (var i = 0, l = this.filters.length; i < l; i++) {
         filter = this.filters[i]
-        filtered = filter.apply(filtered, filter.args)
+        filtered = filter.apply.call(this.vm, filtered, filter.args)
     }
     return filtered
 }
diff --git a/test/functional/fixtures/validation.html b/test/functional/fixtures/validation.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html lang="en">
+    <head>
+        <title></title>
+        <meta charset="utf-8">
+        <script src="bind.js"></script>
+        <script src="../../../dist/seed.js"></script>
+        <style type="text/css">
+            input:not(.valid) {
+                outline-color: #f00;
+            }
+        </style>
+    </head>
+    <body>
+        <div id="test">
+            email: <input type="text" sd-model="a | email" sd-class="valid:validation.email">
+        </div>
+        <script>
+            Seed.config({debug: true})
+            var RE = /^(([^<>()[\]\\.,;:\s@\"]+(\.[^<>()[\]\\.,;:\s@\"]+)*)|(\".+\"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/
+            var test = new Seed({
+                el: '#test',
+                filters: {
+                    email: function (val) {
+                        this.validation.email = val === '' || RE.test(val)
+                        return val
+                    }
+                },
+                scope: {
+                    a: 'hihi',
+                    validation: {
+                        email: true
+                    }
+                }
+            })
+        </script>
+    </body>
+</html>
diff --git a/test/functional/specs/validation.js b/test/functional/specs/validation.js
@@ -0,0 +1,13 @@
+casper.test.begin('Validation', 2, function (test) {
+    
+    casper
+    .start('./fixtures/validation.html', function () {
+        test.assertElementCount('.valid', 0)
+        this.sendKeys('input', '@hello.com')
+        test.assertElementCount('.valid', 1)
+    })
+    .run(function () {
+        test.done()
+    })
+
+})

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ DirProto.applyFilters = function (value) {`
`174`	`174`	`var filtered = value, filter`
`175`	`175`	`for (var i = 0, l = this.filters.length; i < l; i++) {`
`176`	`176`	`filter = this.filters[i]`
`177`		`- filtered = filter.apply(filtered, filter.args)`
	`177`	`+ filtered = filter.apply.call(this.vm, filtered, filter.args)`
`178`	`178`	`}`
`179`	`179`	`return filtered`
`180`	`180`	`}`