Fix missing removal of v-transition class (#3033)

Fix #2972

Author: posva

src/directives/internal/transition.js

@@ -11,6 +11,7 @@ export default {
     // resolve on owner vm
     var hooks = resolveAsset(this.vm.$options, 'transitions', id)
     id = id || 'v'
+    oldId = oldId || 'v'
     el.__v_trans = new Transition(el, id, hooks, this.vm)
     if (oldId) {
       removeClass(el, oldId + '-transition')

test/unit/specs/directives/internal/transition_spec.js

@@ -14,25 +14,30 @@ describe('transition', function () {
     })
     var dir = new Directive({
       name: 'transition',
-      raw: 'test',
+      raw: '',
       def: def,
       modifiers: {
         literal: true
       }
     }, vm, el)
     dir._bind()
     var transition = dir.el.__v_trans
+    expect(transition.enterClass).toBe('v-enter')
+    expect(transition.leaveClass).toBe('v-leave')
+    expect(dir.el.className).toBe('v-transition')
+    dir.update('test', '')
+    transition = dir.el.__v_trans
     expect(transition.el).toBe(dir.el)
     expect(transition.hooks).toBe(fns)
     expect(transition.enterClass).toBe('test-enter')
     expect(transition.leaveClass).toBe('test-leave')
-    expect(dir.el.className === 'test-transition')
+    expect(dir.el.className).toBe('test-transition')
     dir.update('lol', 'test')
     transition = dir.el.__v_trans
     expect(transition.enterClass).toBe('lol-enter')
     expect(transition.leaveClass).toBe('lol-leave')
     expect(transition.fns).toBeUndefined()
-    expect(dir.el.className === 'lol-transition')
+    expect(dir.el.className).toBe('lol-transition')
   })
 
   it('dynamic transitions', function (done) {