provide warning on frozen objects in v-for (ref #2809)

yyx990803 · yyx990803 · commit 70ecce4b42fc · 2016-05-05T18:45:32.000-04:00
diff --git a/src/directives/public/for.js b/src/directives/public/for.js
@@ -426,8 +426,13 @@ const vFor = {
           process.env.NODE_ENV !== 'production' &&
           this.warnDuplicate(value)
         }
-      } else {
+      } else if (Object.isExtensible(value)) {
         def(value, id, frag)
+      } else if (process.env.NODE_ENV !== 'production') {
+        warn(
+          'Frozen v-for objects cannot be automatically tracked, make sure to ' +
+          'provide a track-by key.'
+        )
       }
     }
     frag.raw = value

Original file line number	Diff line number	Diff line change
`@@ -426,8 +426,13 @@ const vFor = {`
`426`	`426`	`process.env.NODE_ENV !== 'production' &&`
`427`	`427`	`this.warnDuplicate(value)`
`428`	`428`	`}`
`429`		`- } else {`
	`429`	`+ } else if (Object.isExtensible(value)) {`
`430`	`430`	`def(value, id, frag)`
	`431`	`+ } else if (process.env.NODE_ENV !== 'production') {`
	`432`	`+ warn(`
	`433`	`+ 'Frozen v-for objects cannot be automatically tracked, make sure to ' +`
	`434`	`+ 'provide a track-by key.'`
	`435`	`+ )`
`431`	`436`	`}`
`432`	`437`	`}`
`433`	`438`	`frag.raw = value`