Skip to content

Commit 8bc8580

Browse files
committed
revert transtion hook context binding behavior (fix #2287)
1 parent f3e6f9f commit 8bc8580

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

src/directives/internal/transition.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ export default {
1111
// resolve on owner vm
1212
var hooks = resolveAsset(this.vm.$options, 'transitions', id)
1313
id = id || 'v'
14-
// apply on closest vm
15-
el.__v_trans = new Transition(el, id, hooks, this.el.__vue__ || this.vm)
14+
el.__v_trans = new Transition(el, id, hooks, this.vm)
1615
if (oldId) {
1716
removeClass(el, oldId + '-transition')
1817
}

test/unit/specs/directives/internal/transition_spec.js

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,23 +36,6 @@ describe('transition', function () {
3636
expect(dir.el.className === 'lol-transition')
3737
})
3838

39-
it('should bind the transition to closest vm', function () {
40-
var vm1 = new Vue()
41-
var vm2 = new Vue()
42-
var el = document.createElement('div')
43-
var dir = new Directive({
44-
name: 'transition',
45-
raw: 'test',
46-
def: def,
47-
modifiers: {
48-
literal: true
49-
}
50-
}, vm1, el)
51-
dir.el.__vue__ = vm2
52-
dir._bind()
53-
expect(dir.el.__v_trans.vm).toBe(vm2)
54-
})
55-
5639
it('dynamic transitions', function (done) {
5740
var el = document.createElement('div')
5841
document.body.appendChild(el)

0 commit comments

Comments
 (0)