Skip to content

Commit b3a9302

Browse files
committed
simplify defProtected
1 parent 02cc63e commit b3a9302

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/directives/repeat.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ function objectToArray (obj) {
102102
data = utils.typeOf(val) === 'Object'
103103
? val
104104
: { $value: val }
105-
def(data, '$key', key, false, true)
105+
def(data, '$key', key)
106106
res.push(data)
107107
}
108108
return res
@@ -283,7 +283,7 @@ module.exports = {
283283
data = { $value: data }
284284
}
285285
// define index
286-
def(data, '$index', index, false, true)
286+
def(data, '$index', index)
287287

288288
}
289289

@@ -349,7 +349,7 @@ module.exports = {
349349

350350
this.object = object
351351
var collection = objectToArray(object)
352-
def(object, '$repeater', collection, false, true)
352+
def(object, '$repeater', collection)
353353

354354
var self = this
355355
this.updateRepeater = function (key, val) {
@@ -362,7 +362,7 @@ module.exports = {
362362
if ('$value' in item) {
363363
item.$value = val
364364
} else {
365-
def(val, '$key', key, false, true)
365+
def(val, '$key', key)
366366
self.lock = true
367367
collection.set(i, val)
368368
self.lock = false
@@ -391,7 +391,7 @@ module.exports = {
391391
if (action > 0) { // new property
392392
// make key ienumerable
393393
delete data.$key
394-
def(data, '$key', key, false, true)
394+
def(data, '$key', key)
395395
obj[key] = val
396396
Observer.convert(obj, key)
397397
} else {

src/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ var utils = module.exports = {
3333
* This avoids it being included in JSON.stringify
3434
* or for...in loops.
3535
*/
36-
defProtected: function (obj, key, val, enumerable, configurable) {
36+
defProtected: function (obj, key, val, enumerable) {
3737
if (obj.hasOwnProperty(key)) return
3838
Object.defineProperty(obj, key, {
3939
value : val,
4040
enumerable : !!enumerable,
41-
configurable : !!configurable
41+
configurable : true
4242
})
4343
},
4444

0 commit comments

Comments
 (0)