fix: should not import from firebase-admin if not used

Author: posva

packages/nuxt/src/runtime/admin/plugin-auth-user.server.ts

@@ -4,8 +4,8 @@ import { createServerUser } from 'vuefire/server'
 import { getCookie } from 'h3'
 // FirebaseError is an interface here but is a class in firebase/app
 import type { FirebaseError } from 'firebase-admin'
-import { AUTH_COOKIE_NAME } from '../auth/api.session'
 import { log } from '../logging'
+import { AUTH_COOKIE_NAME, UserSymbol } from '../shared'
 import { defineNuxtPlugin, useRequestEvent } from '#app'
 
 /**
@@ -42,16 +42,12 @@ export default defineNuxtPlugin(async (nuxtApp) => {
 
   nuxtApp.payload.vuefireUser = user?.toJSON()
 
-  // @ts-expect-error: We cannot provide with a Symbol in nuxt and it cannot be typed
-  nuxtApp[UserSymbol] = createServerUser(user)
+  nuxtApp[
+    // we cannot use symbol to index
+    UserSymbol as unknown as string
+  ] = createServerUser(user)
 })
 
-/**
- * Gets access to the user within the application. This is a symbol to keep it private for the moment.
- * @internal
- */
-export const UserSymbol = Symbol('user')
-
 function isFirebaseError(err: any): err is FirebaseError {
   return err != null && 'code' in err
 }

packages/nuxt/src/runtime/app/plugin.server.ts

@@ -1,8 +1,8 @@
 import { deleteApp, FirebaseApp, initializeApp } from 'firebase/app'
 import { User } from 'firebase/auth'
 import LRU from 'lru-cache'
-import { UserSymbol } from '../admin/plugin-auth-user.server'
 import { log } from '../logging'
+import { UserSymbol } from '../shared'
 import { defineNuxtPlugin, useAppConfig } from '#app'
 
 // TODO: allow customizing
@@ -26,8 +26,10 @@ const appCache = new LRU<string, FirebaseApp>({
 export default defineNuxtPlugin((nuxtApp) => {
   const appConfig = useAppConfig()
 
-  // @ts-expect-error: this is a private symbol
-  const user = nuxtApp[UserSymbol] as User | undefined | null
+  const user = nuxtApp[
+    // we cannot use a symbol to index
+    UserSymbol as unknown as string
+  ] as User | undefined | null
   const uid = user?.uid
 
   let firebaseApp: FirebaseApp

packages/nuxt/src/runtime/auth/api.session-verification.ts

@@ -6,10 +6,9 @@ import {
   assertMethod,
   defineEventHandler,
   deleteCookie,
-  sendRedirect,
 } from 'h3'
 import { log } from '../logging'
-import { AUTH_COOKIE_MAX_AGE, AUTH_COOKIE_NAME } from './api.session'
+import { AUTH_COOKIE_MAX_AGE, AUTH_COOKIE_NAME } from '../shared'
 
 // This version is used at https://github.com/FirebaseExtended/firebase-framework-tools/blob/e69f5bdd44695274ad88dbb4e21aac778ba60cc8/src/firebase-aware.ts#L39 but doesn't work locally. Should it maybe be used in production only? Seems unlikely.
 

packages/nuxt/src/runtime/auth/api.session.ts

@@ -5,6 +5,7 @@ import {
   defineEventHandler,
   deleteCookie,
 } from 'h3'
+import { AUTH_COOKIE_NAME, AUTH_COOKIE_MAX_AGE } from '../shared'
 
 /**
  * Setups an API endpoint to be used by the client to mint a cookie based auth session.
@@ -33,9 +34,3 @@ export default defineEventHandler(async (event) => {
   event.node.res.statusCode = 204
   return ''
 })
-
-// TODO: customizable defaults
-export const AUTH_COOKIE_MAX_AGE = 60 * 60 * 24 * 5 * 1_000
-// MUST be named session to be kept
-// https://firebase.google.com/docs/hosting/manage-cache#using_cookies
-export const AUTH_COOKIE_NAME = '__session'

packages/nuxt/src/runtime/auth/plugin.client.ts

@@ -1,12 +1,12 @@
-import type { FirebaseError, FirebaseApp } from 'firebase/app'
+import type { FirebaseApp } from 'firebase/app'
 import {
   getAuth,
   onIdTokenChanged,
   beforeAuthStateChanged,
   User,
 } from 'firebase/auth'
 import { VueFireAuth } from 'vuefire'
-import { defineNuxtPlugin, showError } from '#app'
+import { defineNuxtPlugin } from '#app'
 
 /**
  * Setups VueFireAuth and automatically mints a cookie based auth session. On the server, it reads the cookie to

packages/nuxt/src/runtime/auth/plugin.server.ts

@@ -1,17 +1,19 @@
 import type { FirebaseApp } from 'firebase/app'
 import type { User } from 'firebase/auth'
 import { VueFireAuthServer } from 'vuefire/server'
-import { UserSymbol } from '../admin/plugin-auth-user.server'
 import { log } from '../logging'
+import { UserSymbol } from '../shared'
 import { defineNuxtPlugin } from '#app'
 
 /**
  * Setups the auth state based on the cookie.
  */
 export default defineNuxtPlugin((nuxtApp) => {
   const firebaseApp = nuxtApp.$firebaseApp as FirebaseApp
-  // @ts-expect-error: this is a private symbol
-  const user = nuxtApp[UserSymbol] as User | undefined | null
+  const user = nuxtApp[
+    // we cannot use symbol to index
+    UserSymbol as unknown as string
+  ] as User | undefined | null
 
   log('debug', 'setting up user for app', firebaseApp.name, user?.uid)
 

packages/nuxt/src/runtime/shared/index.ts

@@ -0,0 +1,11 @@
+/**
+ * @internal Gets access to the user within the application. This is a symbol to keep it private for the moment.
+ */
+export const UserSymbol = Symbol('user')
+
+// TODO: customizable defaults
+export const AUTH_COOKIE_MAX_AGE = 60 * 60 * 24 * 5 * 1_000
+
+// MUST be named session to be kept
+// https://firebase.google.com/docs/hosting/manage-cache#using_cookies
+export const AUTH_COOKIE_NAME = '__session'