fix: refactor cookie name var

Author: posva

packages/nuxt/src/runtime/admin/plugin-auth-user.server.ts

@@ -5,7 +5,7 @@ import { getCookie } from 'h3'
 // FirebaseError is an interface here but is a class in firebase/app
 import type { FirebaseError } from 'firebase-admin'
 import { log } from '../logging'
-import { AUTH_COOKIE_NAME, UserSymbol } from '../constants'
+import { UserSymbol } from '../constants'
 import { defineNuxtPlugin, useRequestEvent } from '#app'
 
 /**
@@ -51,3 +51,7 @@ export default defineNuxtPlugin(async (nuxtApp) => {
 function isFirebaseError(err: any): err is FirebaseError {
   return err != null && 'code' in err
 }
+
+// MUST be named session to be kept
+// https://firebase.google.com/docs/hosting/manage-cache#using_cookies
+const AUTH_COOKIE_NAME = '__session'

packages/nuxt/src/runtime/auth/api.session-verification.ts

@@ -8,7 +8,6 @@ import {
   deleteCookie,
 } from 'h3'
 import { log } from '../logging'
-import { AUTH_COOKIE_MAX_AGE, AUTH_COOKIE_NAME } from '../constants'
 
 // This version is used at https://github.com/FirebaseExtended/firebase-framework-tools/blob/e69f5bdd44695274ad88dbb4e21aac778ba60cc8/src/firebase-aware.ts#L39 but doesn't work locally. Should it maybe be used in production only? Seems unlikely.
 
@@ -66,4 +65,9 @@ export default defineEventHandler(async (event) => {
   return ''
 })
 
-export const ID_TOKEN_MAX_AGE = 5 * 60
+// these must be within this file because the handler gets inlined in dev mode
+const ID_TOKEN_MAX_AGE = 5 * 60
+const AUTH_COOKIE_MAX_AGE = 60 * 60 * 24 * 5 * 1_000
+// MUST be named session to be kept
+// https://firebase.google.com/docs/hosting/manage-cache#using_cookies
+const AUTH_COOKIE_NAME = '__session'

packages/nuxt/src/runtime/auth/api.session.ts

@@ -5,7 +5,6 @@ import {
   defineEventHandler,
   deleteCookie,
 } from 'h3'
-import { AUTH_COOKIE_NAME, AUTH_COOKIE_MAX_AGE } from '../constants'
 
 /**
  * Setups an API endpoint to be used by the client to mint a cookie based auth session.
@@ -34,3 +33,9 @@ export default defineEventHandler(async (event) => {
   event.node.res.statusCode = 204
   return ''
 })
+
+// these must be within this file because the handler gets inlined in dev mode
+const AUTH_COOKIE_MAX_AGE = 60 * 60 * 24 * 5 * 1_000
+// MUST be named session to be kept
+// https://firebase.google.com/docs/hosting/manage-cache#using_cookies
+const AUTH_COOKIE_NAME = '__session'

packages/nuxt/src/runtime/constants.ts

@@ -2,10 +2,3 @@
  * @internal Gets access to the user within the application. This is a symbol to keep it private for the moment.
  */
 export const UserSymbol = Symbol('user')
-
-// TODO: customizable defaults
-export const AUTH_COOKIE_MAX_AGE = 60 * 60 * 24 * 5 * 1_000
-
-// MUST be named session to be kept
-// https://firebase.google.com/docs/hosting/manage-cache#using_cookies
-export const AUTH_COOKIE_NAME = '__session'