Skip to content

Commit 600f70c

Browse files
committed
refactor: rename types
1 parent 4a14969 commit 600f70c

File tree

3 files changed

+18
-14
lines changed

3 files changed

+18
-14
lines changed

src/firestore/index.ts

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -141,14 +141,14 @@ export function useCollection<
141141
export function useCollection<T>(
142142
collectionRef: CollectionReference | Query,
143143
options?: UseCollectionOptions
144-
): _RefFirestore<VueFireQueryData<T>>
144+
): _RefFirestore<VueFireStoreQueryData<T>>
145145

146146
export function useCollection<T>(
147147
collectionRef: CollectionReference<unknown> | Query<unknown>,
148148
options?: UseCollectionOptions
149-
): _RefFirestore<VueFireQueryData<T>> {
149+
): _RefFirestore<VueFireStoreQueryData<T>> {
150150
return _useFirestoreRef(collectionRef, options) as _RefFirestore<
151-
VueFireQueryData<T>
151+
VueFireStoreQueryData<T>
152152
>
153153
}
154154

@@ -181,14 +181,18 @@ export function useDocument<
181181
export function useDocument<T>(
182182
documentRef: DocumentReference,
183183
options?: UseDocumentOptions
184-
): _RefFirestore<VueFireDocumentData<T>>
184+
): _RefFirestore<VueFirestoreDocumentData<T>>
185185

186186
export function useDocument<T>(
187187
documentRef: DocumentReference<unknown>,
188188
options?: UseDocumentOptions
189-
): _RefFirestore<_InferReferenceType<T> | null> | _RefFirestore<T | null> {
189+
):
190+
| _RefFirestore<VueFirestoreDocumentData<T> | null>
191+
| _RefFirestore<VueFirestoreDocumentData<T> | null> {
190192
// no unwrapRef to have a simpler type
191-
return _useFirestoreRef(documentRef, options) as _RefFirestore<T>
193+
return _useFirestoreRef(documentRef, options) as _RefFirestore<
194+
VueFirestoreDocumentData<T>
195+
>
192196
}
193197

194198
// TODO: move to an unsubscribe file
@@ -224,7 +228,7 @@ export type _InferReferenceType<R> = R extends
224228
/**
225229
* Type used by default by the `firestoreDefaultConverter`.
226230
*/
227-
export type VueFireDocumentData<T = DocumentData> =
231+
export type VueFirestoreDocumentData<T = DocumentData> =
228232
| null
229233
| (T & {
230234
/**
@@ -233,8 +237,8 @@ export type VueFireDocumentData<T = DocumentData> =
233237
readonly id: string
234238
})
235239

236-
export type VueFireQueryData<T = DocumentData> = Array<
237-
Exclude<VueFireDocumentData<T>, null>
240+
export type VueFireStoreQueryData<T = DocumentData> = Array<
241+
Exclude<VueFirestoreDocumentData<T>, null>
238242
>
239243

240244
export interface _RefFirestore<T> extends _RefWithState<T, FirestoreError> {}

src/firestore/utils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
FirestoreDataConverter,
1010
} from 'firebase/firestore'
1111
import { isTimestamp, isObject, isDocumentRef, TODO } from '../shared'
12-
import { VueFireDocumentData } from '.'
12+
import { VueFirestoreDocumentData } from '.'
1313

1414
export type FirestoreReference = Query | DocumentReference | CollectionReference
1515

@@ -24,7 +24,7 @@ export function createSnapshot<T = DocumentData>(
2424
return Object.defineProperty(doc.data() || {}, 'id', { value: doc.id })
2525
}
2626

27-
export const firestoreDefaultConverter: FirestoreDataConverter<VueFireDocumentData> =
27+
export const firestoreDefaultConverter: FirestoreDataConverter<VueFirestoreDocumentData> =
2828
{
2929
toFirestore(data) {
3030
// this is okay because we declare other properties as non-enumerable
@@ -42,7 +42,7 @@ export const firestoreDefaultConverter: FirestoreDataConverter<VueFireDocumentDa
4242
// value: snapshot.metadata,
4343
// },
4444
// $ref: { get: () => snapshot.ref },
45-
}) as VueFireDocumentData)
45+
}) as VueFirestoreDocumentData)
4646
: null
4747
},
4848
}

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ export { useCollection, useDocument } from './firestore'
77

88
export type {
99
UseCollectionOptions,
10-
VueFireDocumentData,
11-
VueFireQueryData,
10+
VueFirestoreDocumentData,
11+
VueFireStoreQueryData,
1212
} from './firestore'
1313

1414
export { firestorePlugin } from './firestore/optionsApi'

0 commit comments

Comments
 (0)