test: make pending hot-reload test pass

kiaking · kiaking · commit 9c58465fcf1d · 2020-03-31T00:59:26.000+09:00
diff --git a/package.json b/package.json
@@ -58,6 +58,7 @@
     "express": "^4.14.1",
     "jasmine": "2.8.0",
     "jasmine-core": "2.8.0",
+    "jsdom": "^16.2.2",
     "nightwatch": "^1.3.1",
     "nightwatch-helpers": "^1.2.0",
     "rollup": "^1.1.0",
diff --git a/test/unit/hot-reload.spec.js b/test/unit/hot-reload.spec.js
@@ -1,8 +1,9 @@
-// import { createApp, nextTick } from 'vue'
+import { nextTick } from 'vue'
+import { mount } from './support/helpers'
 import Vuex from '../../dist/vuex.common.js'
 
 const TEST = 'TEST'
-// const isSSR = process.env.VUE_ENV === 'server'
+const isSSR = process.env.VUE_ENV === 'server'
 
 describe('Hot Reload', () => {
   it('mutations', function () {
@@ -233,67 +234,62 @@ describe('Hot Reload', () => {
     expect(store.state.list.join()).toBe('1,2,3,2,4,5')
   })
 
-  // Skipping for now due to unkown error;
-  // TypeError: Cannot read property 'createComment' of null
-  //
-  // it('getters', done => {
-  //   const store = new Vuex.Store({
-  //     state: {
-  //       count: 0
-  //     },
-  //     mutations: {
-  //       inc: state => state.count++
-  //     },
-  //     getters: {
-  //       count: state => state.count
-  //     },
-  //     actions: {
-  //       check ({ getters }, value) {
-  //         expect(getters.count).toBe(value)
-  //       }
-  //     }
-  //   })
+  it('getters', done => {
+    const store = new Vuex.Store({
+      state: {
+        count: 0
+      },
+      mutations: {
+        inc: state => state.count++
+      },
+      getters: {
+        count: state => state.count
+      },
+      actions: {
+        check ({ getters }, value) {
+          expect(getters.count).toBe(value)
+        }
+      }
+    })
 
-  //   const spy = jasmine.createSpy()
-  //   const app = createApp({
-  //     computed: {
-  //       a: () => store.getters.count
-  //     },
-  //     watch: {
-  //       a: spy
-  //     },
-  //     render () {}
-  //   })
-  //   app.use(Vuex, store)
-  //   const vm = app.mount({ appendChild: () => {} })
+    const spy = jasmine.createSpy()
 
-  //   expect(vm.a).toBe(0)
-  //   store.dispatch('check', 0)
+    const vm = mount(store, {
+      computed: {
+        a: () => store.getters.count
+      },
+      watch: {
+        a: spy
+      }
+    })
 
-  //   store.commit('inc')
+    expect(vm.a).toBe(0)
+    store.dispatch('check', 0)
 
-  //   expect(vm.a).toBe(1)
-  //   store.dispatch('check', 1)
+    store.commit('inc')
 
-  //   // update getters
-  //   store.hotUpdate({
-  //     getters: {
-  //       count: state => state.count * 10
-  //     }
-  //   })
+    expect(vm.a).toBe(1)
+    store.dispatch('check', 1)
 
-  //   expect(vm.a).toBe(10)
-  //   store.dispatch('check', 10)
+    // update getters
+    store.hotUpdate({
+      getters: {
+        count: state => state.count * 10
+      }
+    })
+
+    expect(vm.a).toBe(10)
+    store.dispatch('check', 10)
 
-  //   if (isSSR) {
-  //     done()
-  //   } else {
-  //     nextTick(() => {
-  //       expect(spy).toHaveBeenCalled()
-  //       done()
-  //     })
-  //   }
-  // })
+    if (isSSR) {
+      done()
+    } else {
+      nextTick(() => {
+        expect(spy).toHaveBeenCalled()
+        done()
+      })
+    }
+  })
 
   it('provide warning if a new module is given', () => {
     const store = new Vuex.Store({})
diff --git a/test/unit/setup.js b/test/unit/setup.js
@@ -1 +1,8 @@
 import 'babel-polyfill'
+import { JSDOM } from 'jsdom'
+
+const dom = new JSDOM('<html><body></body></html>')
+
+global.document = dom.window.document
+global.window = dom.window
+global.navigator = dom.window.navigator
diff --git a/test/unit/support/helpers.js b/test/unit/support/helpers.js
@@ -0,0 +1,21 @@
+import { createApp } from 'vue'
+
+export function mount (store, component) {
+  const el = createElement()
+
+  component.render = () => {}
+
+  const app = createApp(component)
+
+  app.use(store)
+
+  return app.mount(el)
+}
+
+function createElement () {
+  const el = document.createElement('div')
+
+  document.body.appendChild(el)
+
+  return el
+}
diff --git a/yarn.lock b/yarn.lock
