refactor(client): handle page data hmr by checking pageChunk ref

meteorlxy · meteorlxy · commit 3daf0fc908f6 · 2024-02-19T13:25:23.000+08:00
diff --git a/packages/client/src/setupGlobalComputed.ts b/packages/client/src/setupGlobalComputed.ts
@@ -50,10 +50,7 @@ export const setupGlobalComputed = (
       const newPageChunk = { comp: oldPageChunk.comp, data: newPageData }
       routes.value[newPageData.path].loader = () =>
         Promise.resolve(newPageChunk)
-      if (
-        newPageData.path ===
-        router.currentRoute.value.meta._pageChunk?.data.path
-      ) {
+      if (newPageData.path === pageChunk.value.data.path) {
         pageChunk.value = newPageChunk
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -50,10 +50,7 @@ export const setupGlobalComputed = (`
`50`	`50`	`const newPageChunk = { comp: oldPageChunk.comp, data: newPageData }`
`51`	`51`	`routes.value[newPageData.path].loader = () =>`
`52`	`52`	`Promise.resolve(newPageChunk)`
`53`		`- if (`
`54`		`- newPageData.path ===`
`55`		`- router.currentRoute.value.meta._pageChunk?.data.path`
`56`		`- ) {`
	`53`	`+ if (newPageData.path === pageChunk.value.data.path) {`
`57`	`54`	`pageChunk.value = newPageChunk`
`58`	`55`	`}`
`59`	`56`	`}`