revert: refactor(client): handle page data hmr by checking pageChunk ref

meteorlxy · meteorlxy · commit bb96427c2505 · 2024-02-19T13:54:29.000+08:00
It would cause error in webpack hmr
diff --git a/packages/client/src/setupGlobalComputed.ts b/packages/client/src/setupGlobalComputed.ts
@@ -50,7 +50,10 @@ export const setupGlobalComputed = (
       const newPageChunk = { comp: oldPageChunk.comp, data: newPageData }
       routes.value[newPageData.path].loader = () =>
         Promise.resolve(newPageChunk)
-      if (newPageData.path === pageChunk.value.data.path) {
+      if (
+        newPageData.path ===
+        router.currentRoute.value.meta._pageChunk?.data.path
+      ) {
         pageChunk.value = newPageChunk
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,10 @@ export const setupGlobalComputed = (`
`50`	`50`	`const newPageChunk = { comp: oldPageChunk.comp, data: newPageData }`
`51`	`51`	`routes.value[newPageData.path].loader = () =>`
`52`	`52`	`Promise.resolve(newPageChunk)`
`53`		`- if (newPageData.path === pageChunk.value.data.path) {`
	`53`	`+ if (`
	`54`	`+ newPageData.path ===`
	`55`	`+ router.currentRoute.value.meta._pageChunk?.data.path`
	`56`	`+ ) {`
`54`	`57`	`pageChunk.value = newPageChunk`
`55`	`58`	`}`
`56`	`59`	`}`