Skip to content

Commit 0109f6b

Browse files
committed
chore: add CR fixes
1 parent 0ebc456 commit 0109f6b

File tree

6 files changed

+32
-18
lines changed

6 files changed

+32
-18
lines changed

packages/logger/__tests__/unit/consolaStructuredLogger.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe("createConsolaStructuredLogger", () => {
1212
const logData: LogData = "Test log message";
1313
const metadata: Metadata = { userId: "12345" };
1414

15-
it("should create a logger with the correct set of methods", () => {
15+
it("it creates a logger with the correct set of methods", () => {
1616
const logger = createConsolaStructuredLogger(mockStructuredLog);
1717

1818
expect(logger).toHaveProperty("emergency");
@@ -25,7 +25,7 @@ describe("createConsolaStructuredLogger", () => {
2525
expect(logger).toHaveProperty("debug");
2626
});
2727

28-
it("should log at the correct level", () => {
28+
it("it logs at the correct level", () => {
2929
const logger = createConsolaStructuredLogger(mockStructuredLog);
3030

3131
const infoSpy = jest.spyOn(logger, "info").mockImplementation(() => {});

packages/logger/src/ConsolaStructuredLogger.ts

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ConsolaOptions, ConsolaReporter, createConsola } from "consola";
1+
import { ConsolaOptions, createConsola } from "consola";
22

33
import dotenv from "dotenv";
44
import { LogLevel } from "./interfaces/LogLevel";
@@ -37,22 +37,24 @@ const createConsolaStructuredLogger = (
3737
debug: 4,
3838
};
3939

40-
const jsonReporter: ConsolaReporter = {
41-
log: (logObject) => {
42-
if (
43-
process.env.NODE_ENV === "development" ||
44-
typeof window !== "undefined"
45-
) {
46-
console.log(logObject.args[0].structuredLog);
47-
} else {
48-
console.log(JSON.stringify(logObject.args[0].structuredLog));
49-
}
50-
},
40+
const buildJsonReporter = () => {
41+
return {
42+
log: (logObject) => {
43+
if (
44+
process.env.NODE_ENV === "development" ||
45+
typeof window !== "undefined"
46+
) {
47+
console.log(logObject.args[0].structuredLog);
48+
} else {
49+
console.log(JSON.stringify(logObject.args[0].structuredLog));
50+
}
51+
},
52+
};
5153
};
5254

5355
const logger = createConsola({
5456
level: levelMap?.[options.level] ?? levelMap.info,
55-
reporters: [jsonReporter],
57+
reporters: options.reporters || [buildJsonReporter()],
5658
});
5759

5860
if (options.reporters) {
@@ -75,6 +77,11 @@ const createConsolaStructuredLogger = (
7577
metadata
7678
);
7779

80+
/**
81+
* Map the log level to the consola level
82+
* Our log levels are more granular than consola's log levels
83+
* and we need to map them to the closest consola level
84+
*/
7885
const consolaLevel = mapToConsolaLevel(level);
7986

8087
switch (consolaLevel) {

packages/logger/src/structuredLog/GCPStructuredLog.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {
2-
removeAnsiCodesFromStr as defaultRemoveAnsiCodes,
2+
removeAnsiColorCodesFromStr as defaultRemoveAnsiCodes,
33
type RemoveAnsiCode,
44
} from "../utils/removeAnsiCodes";
55
import type { LogData, Metadata } from "../interfaces/LoggerInterface";
@@ -40,7 +40,7 @@ export class GCPStructuredLog implements StructuredLog {
4040
};
4141

4242
/**
43-
* The function to remove ANSI codes from the log message.
43+
* The function to remove ANSI color codes from the log message.
4444
*/
4545
private removeAnsiCodes: RemoveAnsiCode;
4646

packages/logger/src/utils/removeAnsiCodes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export type RemoveAnsiCode = (str: string) => string;
22

3-
export const removeAnsiCodesFromStr: RemoveAnsiCode = (str) => {
3+
export const removeAnsiColorCodesFromStr: RemoveAnsiCode = (str) => {
44
// eslint-disable-next-line no-control-regex
55
const ansiRegex = /\x1B\[[0-?9;]*[mK]/g;
66

packages/middleware/src/handlers/prepareApiFunction/index.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,12 @@ export function prepareApiFunction(
2222
extensionName,
2323
functionName,
2424
},
25+
errorBoundary: {
26+
scope: {
27+
integrationName,
28+
functionName,
29+
},
30+
},
2531
};
2632

2733
const {

packages/middleware/src/integrations/registerIntegrations.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ async function triggerExtendAppHook(
4343
const loggerWithMetadata = injectMetadata(logger, () => ({
4444
scope: {
4545
extensionName: name,
46+
type: "hook",
4647
hookName: "extendApp",
4748
},
4849
}));

0 commit comments

Comments
 (0)