Skip to content

Commit d5a2f41

Browse files
author
Tomasz Kostuch
authored
Merge branch 'release/v1.12.0-rc.1' into feature/move-deprecated-code-to-file
2 parents 1cedd4e + 40075ae commit d5a2f41

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
6161
- removed possible memory leak in ssr - @resubaka (#4247)
6262
- Bugfix for reactivity of `current_configuration` in `populateProductConfigurationAsync` - @cewald (#4258)
6363
- Bugfix for build exception in Node v13.13+ - @cewald (#4249)
64+
- Convert option ids to string while comparing them in `getProductConfiguration` - @gibkigonzo (#4484)
6465
- change value to number in price filter - @gibkigonzo (#4478)
6566

6667
### Changed / Improved

core/modules/cart/helpers/getProductConfiguration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const ATTRIBUTES = ['color', 'size']
77
const getProductConfiguration = (product: CartItem): ProductConfiguration => {
88
const options = getProductOptions(product)
99
const getAttributesFields = (attributeCode) =>
10-
(options[attributeCode] || []).find(c => c.id === parseInt(product[attributeCode]))
10+
(options[attributeCode] || []).find(c => String(c.id) === String(product[attributeCode]))
1111

1212
if (!options) {
1313
return null

0 commit comments

Comments
 (0)