Fix connection detection for polymorphic relations

Author: phortx

dist/vuex-orm-graphql.esm.js

@@ -3661,6 +3661,18 @@ var Model = /** @class */ (function () {
             field instanceof context.components.Number ||
             field instanceof context.components.Boolean;
     };
+    /**
+     * Tells if a field which represents a relation is a connection (multiple).
+     * @param {Field} field
+     * @returns {boolean}
+     */
+    Model.isConnection = function (field) {
+        var context = Context.getInstance();
+        return !(field instanceof context.components.BelongsTo ||
+            field instanceof context.components.HasOne ||
+            field instanceof context.components.MorphTo ||
+            field instanceof context.components.MorphOne);
+    };
     /**
      * Adds $isPersisted and other meta fields to the model by overwriting the fields() method.
      * @todo is this a good way to add fields?
@@ -3914,7 +3926,9 @@ function valueToObjectRepresentation(argObj, name, value, variables) {
         argObj[name.value] = null;
     }
     else {
-        throw new Error("The inline argument \"" + name.value + "\" of kind \"" + value.kind + "\" is not supported.\n                    Use variables instead of inline arguments to overcome this limitation.");
+        throw new Error("The inline argument \"" + name.value + "\" of kind \"" + value.kind + "\"" +
+            'is not supported. Use variables instead of inline arguments to ' +
+            'overcome this limitation.');
     }
 }
 function storeKeyNameFromField(field, variables) {
@@ -6766,7 +6780,7 @@ var QueryManager = /** @class */ (function () {
                         // clear out the latest new data, since we're now using it
                         _this.setQuery(queryId, function () { return ({ newData: null }); });
                         data = newData.result;
-                        isMissing = !newData.complete ? !newData.complete : false;
+                        isMissing = !newData.complete || false;
                     }
                     else {
                         if (lastResult && lastResult.data && !errorStatusChanged) {
@@ -10333,11 +10347,9 @@ var QueryBuilder = /** @class */ (function () {
             var ignore = path.includes(singularizedFieldName);
             // console.log(`-----> Will ${ignore ? '' : 'not'} ignore ${model.singularName}.${name}, path: ${path.join('.')}`);
             if (model.shouldEagerLoadRelation(name, field, relatedModel) && !ignore) {
-                var multiple = !(field instanceof context.components.BelongsTo ||
-                    field instanceof context.components.HasOne);
                 var newPath = path.slice(0);
                 newPath.push(singularizedFieldName);
-                relationQueries.push(_this.buildField(relatedModel, multiple, undefined, newPath, name, false));
+                relationQueries.push(_this.buildField(relatedModel, Model.isConnection(field), undefined, newPath, name, false));
             }
         });
         return relationQueries.join('\n');

src/graphql/query-builder.ts

@@ -270,13 +270,10 @@ export default class QueryBuilder {
       // console.log(`-----> Will ${ignore ? '' : 'not'} ignore ${model.singularName}.${name}, path: ${path.join('.')}`);
 
       if (model.shouldEagerLoadRelation(name, field, relatedModel) && !ignore) {
-        const multiple: boolean = !(field instanceof context.components.BelongsTo ||
-          field instanceof context.components.HasOne);
-
         const newPath = path.slice(0);
         newPath.push(singularizedFieldName);
 
-        relationQueries.push(this.buildField(relatedModel, multiple, undefined, newPath, name, false));
+        relationQueries.push(this.buildField(relatedModel, Model.isConnection(field), undefined, newPath, name, false));
       }
     });
 

src/orm/model.ts

@@ -76,6 +76,22 @@ export default class Model {
       field instanceof context.components.Boolean;
   }
 
+  /**
+   * Tells if a field which represents a relation is a connection (multiple).
+   * @param {Field} field
+   * @returns {boolean}
+   */
+  public static isConnection (field: Field): boolean {
+    const context = Context.getInstance();
+
+    return !(
+      field instanceof context.components.BelongsTo ||
+      field instanceof context.components.HasOne ||
+      field instanceof context.components.MorphTo ||
+      field instanceof context.components.MorphOne
+    );
+  }
+
   /**
    * Adds $isPersisted and other meta fields to the model by overwriting the fields() method.
    * @todo is this a good way to add fields?

test/integration/VuexORMGraphQL.spec.js

@@ -974,13 +974,13 @@ query status {
         result = await store.dispatch('entities/simpleQuery', { query, variables: {} });
       });
 
-      const idSymbol = Object.getOwnPropertySymbols(result)[0];
+      // Remove the ID Symbol
+      delete Object.getOwnPropertySymbols(result)[0];
 
       expect(result).toEqual({
         backend: true,
         smsGateway: false,
-        paypalIntegration: true,
-        [idSymbol]: "ROOT_QUERY"
+        paypalIntegration: true
       });
       expect(request.query).toEqual(`
 query status {