Replace script interpreter to bash or update the documentation

[Jiab77]

Hello @kotakanbe, I've spotted that most of the script are using sh as interpreter but the documentation is using sudo bash install.sh as shown here.

Would it not be better to simply change the default interpreter to bash instead of sh and update the documentation accordingly?

Let me know if you agree and I can do the necessary pull requests.

[kotakanbe]

Hi, @Jiab77

You're right. If it works, I think /bin/sh is fine.
Please make sure you do the test, send a pull request is appreciated.

[Jiab77]

Hello @kotakanbe, Yes I'll do some tests 'cause I think this coding form: if [[ condition == expected ]]; then; else; fi or [[ condition ]] && true || false will not work with /bin/sh. I think this coding form is only supported by /bin/bash.

As far as I remember, /bin/sh will only support this form: if [ condition = expected ]; then; else; fi.

I'll do some research, do some tests and let you know. From there we will be able to take a decision.