Skip to content

Commit 213296d

Browse files
committed
adjust code
1 parent a069359 commit 213296d

13 files changed

+48
-35
lines changed

JSONConverter/Classes/Builder/BuilderProtocol.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protocol BuilderProtocol {
1717
func propertySetterText(_ type: PropertyType, keyName: String, strategy: PropertyStrategy, keyTypeName: String?) -> String
1818

1919
func contentParentClassText(_ clsText: String?) -> String
20-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String
20+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String
2121

2222
func fileSuffix() -> String
2323
func fileImplSuffix() -> String

JSONConverter/Classes/Builder/CodableBuilder.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ class CodableBuilder: BuilderProtocol {
4848
return StringUtils.isEmpty(clsText) ? ": Codable" : ": \(clsText!)"
4949
}
5050

51-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
51+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
5252
if structType == .class {
5353
return "\nclass \(clsName)\(parentClsName) {\n\(propertiesText)\n\trequired init() {}\n}\n"
5454
} else {
55-
propertiesText.removeLastChar()
56-
return "\nstruct \(clsName)\(parentClsName) {\n\(propertiesText)\n}\n"
55+
let tempPropertiesText = StringUtils.removeLastChar(propertiesText)
56+
return "\nstruct \(clsName)\(parentClsName) {\n\(tempPropertiesText)\n}\n"
5757
}
5858
}
5959

JSONConverter/Classes/Builder/FlutterBuilder.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class FlutterBuilder: BuilderProtocol {
4545
return StringUtils.isEmpty(clsText) ? " extends Object" : " extends \(clsText!)"
4646
}
4747

48-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
48+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
4949
return "\n@JsonSerializable()\nclass \(clsName)\(parentClsName) {\n\(propertiesText)\n\t\(clsName)(\(propertiesInitText!));\n\n\tfactory \(clsName).fromJson(Map<String, dynamic> srcJson) => _$\(clsName)FromJson(srcJson);\n\n\tMap<String, dynamic> toJson() => _$\(clsName)ToJson(this);\n\n}\n"
5050
}
5151

JSONConverter/Classes/Builder/GolangBuilder.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ class GolangBuilder: BuilderProtocol {
4949
return StringUtils.isEmpty(clsText) ? "" : ": \(clsText!)"
5050
}
5151

52-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
53-
propertiesText.removeLastChar()
54-
return "\ntype \(clsName) struct {\n\(propertiesText)\n}\n"
52+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
53+
let tempPropertiesText = StringUtils.removeLastChar(propertiesText)
54+
return "\ntype \(clsName) struct {\n\(tempPropertiesText)\n}\n"
5555
}
5656

5757
func fileSuffix() -> String {

JSONConverter/Classes/Builder/HandyJSONBuilder.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ class HandyJSONBuilder: BuilderProtocol {
4848
return StringUtils.isEmpty(clsText) ? ": HandyJSON" : ": \(clsText!)"
4949
}
5050

51-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
51+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
5252
if structType == .class {
5353
return "\nclass \(clsName)\(parentClsName) {\n\(propertiesText)\n\trequired init() {}\n}\n"
5454
} else {
55-
propertiesText.removeLastChar()
56-
return "\nstruct \(clsName)\(parentClsName) {\n\(propertiesText)\n}\n"
55+
let tempPropertiesText = StringUtils.removeLastChar(propertiesText)
56+
return "\nstruct \(clsName)\(parentClsName) {\n\(tempPropertiesText)\n}\n"
5757
}
5858
}
5959

JSONConverter/Classes/Builder/JavaBuilder.swift

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,17 +210,20 @@ class JavaBuilder: BuilderProtocol {
210210
}
211211
}
212212

213-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
213+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
214214
assert(propertiesGetterSetterText != nil, "property getter setter text can't be nil")
215-
if let getterSetterText = propertiesGetterSetterText, StringUtils.isNotEmpty(getterSetterText) {
216-
let range = getterSetterText.index(getterSetterText.endIndex, offsetBy: -2)..<getterSetterText.endIndex
217-
propertiesGetterSetterText?.removeSubrange(range)
215+
216+
var getterSetterText = propertiesGetterSetterText ?? ""
217+
if var tempGetterSetterText = propertiesGetterSetterText, StringUtils.isNotEmpty(tempGetterSetterText) {
218+
let range = tempGetterSetterText.index(tempGetterSetterText.endIndex, offsetBy: -2)..<tempGetterSetterText.endIndex
219+
tempGetterSetterText.removeSubrange(range)
220+
getterSetterText = tempGetterSetterText
218221
}
219222

220223
return """
221224
\npublic class \(clsName) \(parentClsName) {
222225
\(propertiesText)
223-
\(propertiesGetterSetterText!)
226+
\(getterSetterText)
224227
}\n
225228
"""
226229
}

JSONConverter/Classes/Builder/KakaJSONBuilder.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ class KakaJSONBuilder: BuilderProtocol {
4848
return StringUtils.isEmpty(clsText) ? ": Convertible" : ": \(clsText!)"
4949
}
5050

51-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
51+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
5252
if structType == .class {
5353
return "\nclass \(clsName)\(parentClsName) {\n\(propertiesText)\n\trequired init() {}\n}\n"
5454
} else {
55-
propertiesText.removeLastChar()
56-
return "\nstruct \(clsName)\(parentClsName) {\n\(propertiesText)\n}\n"
55+
let tempPropertiesText = StringUtils.removeLastChar(propertiesText)
56+
return "\nstruct \(clsName)\(parentClsName) {\n\(tempPropertiesText)\n}\n"
5757
}
5858
}
5959

JSONConverter/Classes/Builder/ObjCBuilder.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ class ObjCBuilder: BuilderProtocol {
4747
return StringUtils.isEmpty(clsText) ? ": NSObject" : ": \(clsText!)"
4848
}
4949

50-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
51-
propertiesText.removeLastChar()
52-
return "\n@interface \(clsName)\(parentClsName)\n\(propertiesText)\n@end\n"
50+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
51+
let tempPropertiesText = StringUtils.removeLastChar(propertiesText)
52+
return "\n@interface \(clsName)\(parentClsName)\n\(tempPropertiesText)\n@end\n"
5353
}
5454

5555
func fileSuffix() -> String {

JSONConverter/Classes/Builder/ObjectMapperBuilder.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class ObjectMapperBuilder: BuilderProtocol {
4545
}
4646
}
4747

48-
func initPropertyText(_ type: PropertyType, keyName: String, strategy: PropertyStrategy, maxKeyNameLength: Int, typeName: String?) -> String {
48+
func propertyInitText(_ type: PropertyType, keyName: String, strategy: PropertyStrategy, maxKeyNameLength: Int, keyTypeName: String?) -> String {
4949
let tempKeyName = strategy.processed(keyName)
5050
let spaceText = String.numSpace(count: maxKeyNameLength - tempKeyName.count)
5151
return "\t\t\(tempKeyName)\(spaceText) <- map[\"\(keyName)\"]\n"
@@ -55,7 +55,7 @@ class ObjectMapperBuilder: BuilderProtocol {
5555
return StringUtils.isEmpty(clsText) ? ": Mappable" : ": \(clsText!)"
5656
}
5757

58-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
58+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
5959
if structType == .class {
6060
return "\nclass \(clsName)\(parentClsName) {\n\(propertiesText)\n\trequired init?(map: Map) {}\n\n\tfunc mapping(map: Map) {\n\(propertiesInitText!)\t}\n}\n"
6161
} else {

JSONConverter/Classes/Builder/SwiftBuilder.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ class SwiftBuilder: BuilderProtocol {
4747
return StringUtils.isEmpty(clsText) ? "" : ": \(clsText!)"
4848
}
4949

50-
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: inout String, propertiesInitText: inout String?, propertiesGetterSetterText: inout String?) -> String {
51-
propertiesText.removeLastChar()
50+
func contentText(_ structType: StructType, clsName: String, parentClsName: String, propertiesText: String, propertiesInitText: String?, propertiesGetterSetterText: String?) -> String {
51+
let tempPropertiesText = StringUtils.removeLastChar(propertiesText)
5252
if structType == .class {
53-
return "\nclass \(clsName)\(parentClsName) {\n\(propertiesText)\n}\n"
53+
return "\nclass \(clsName)\(parentClsName) {\n\(tempPropertiesText)\n}\n"
5454
} else {
55-
return "\nstruct \(clsName)\(parentClsName) {\n\(propertiesText)\n}\n"
55+
return "\nstruct \(clsName)\(parentClsName) {\n\(tempPropertiesText)\n}\n"
5656
}
5757
}
5858

0 commit comments

Comments
 (0)