Skip to content

Commit 59d46f6

Browse files
authored
Prettify macOS dmg (#58)
* Prettify mac dmg isntaller * Fix docs * Update mscOS docs
1 parent 29bb169 commit 59d46f6

File tree

9 files changed

+25
-16
lines changed

9 files changed

+25
-16
lines changed

.github/workflows/execute_merge_checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ env:
88
LV2_TARGET_NAME: PeakEater_LV2
99
CLAP_TARGET_NAME: PeakEater_CLAP
1010
JUCE_REVISION: 4e68af7
11-
VERSION: 0.5.0
11+
VERSION: 0.5.1
1212
BUILD_ID: "${{ github.run_id }}.${{ github.run_number }}.${{ github.run_attempt }}"
1313
jobs:
1414
macos:

.github/workflows/publish_release_draft.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: Publish Release Draft
2-
run-name: Create release draft for v0.5.0
2+
run-name: Create release draft for v0.5.1
33
on:
44
push:
55
branches:
@@ -12,9 +12,9 @@ env:
1212
LV2_TARGET_NAME: PeakEater_LV2
1313
CLAP_TARGET_NAME: PeakEater_CLAP
1414
JUCE_REVISION: 4e68af7
15-
MACOS_RELEASE_NAME: PeakEater_v0.5.0_macOS
16-
WINDOWS_RELEASE_NAME: PeakEater_v0.5.0_Windows
17-
LINUX_RELEASE_NAME: PeakEater_v0.5.0_Linux
15+
MACOS_RELEASE_NAME: PeakEater_v0.5.1_macOS
16+
WINDOWS_RELEASE_NAME: PeakEater_v0.5.1_Windows
17+
LINUX_RELEASE_NAME: PeakEater_v0.5.1_Linux
1818
jobs:
1919
macos:
2020
name: macOS
@@ -81,12 +81,12 @@ jobs:
8181
MACOS_APPLE_ID: ${{ secrets.MACOS_APPLE_ID }}
8282
MACOS_APPLE_PASSWORD: ${{ secrets.MACOS_APPLE_PASSWORD }}
8383
MACOS_APPLE_TEAM_ID: ${{ secrets.MACOS_APPLE_TEAM_ID }}
84-
run: python ${{github.workspace}}/Scripts/Release/MacOS.py --release_type=${{env.BUILD_TYPE}} --sign_and_notarize=True --release_version=0.5.0
84+
run: python ${{github.workspace}}/Scripts/Release/MacOS.py --release_type=${{env.BUILD_TYPE}} --sign_and_notarize=True --release_version=0.5.1
8585
- name: Upload Artifacts
8686
uses: actions/upload-artifact@v3
8787
with:
8888
name: ${{ env.MACOS_RELEASE_NAME }}
89-
path: ${{github.workspace}}/build/release/PeakEater-0.5.0.dmg
89+
path: ${{github.workspace}}/build/release/PeakEater-0.5.1.dmg
9090

9191
windows:
9292
name: Windows
@@ -183,5 +183,5 @@ jobs:
183183
draft: true
184184
removeArtifacts: true
185185
makeLatest: true
186-
tag: "v0.5.0"
186+
tag: "v0.5.1"
187187
artifacts: "${{ env.MACOS_RELEASE_NAME }}.zip,${{ env.WINDOWS_RELEASE_NAME }}.zip,${{ env.LINUX_RELEASE_NAME }}.zip"

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,8 @@
1010
# Python cache
1111
Scripts/Release/__pycache__
1212

13+
# node
14+
node_modules
15+
1316
# Various vscode logs
1417
/.vscode/*.log

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.15)
2-
project(PeakEater VERSION 0.5.0)
2+
project(PeakEater VERSION 0.5.1)
33
set(CMAKE_CXX_STANDARD 20)
44

55
add_subdirectory(Dependencies/JUCE)

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ Shows approximated RMS that was cut("Eaten") in last 2 seconds and current clipp
101101

102102
### Switchable scales
103103

104-
<img src="Resources/screenshots/screenshot-switch-ticks.gif" alt="switch-db-level-scales" height="250"/>
104+
<img src="Resources/screenshots/screenshot-switch-ticks.gif" alt="switch-db-level-scales" width="400"/>
105105

106106
Right click on Visualizer to switch between different scales.
107107

@@ -171,7 +171,10 @@ You can use it on macOS, Windows or Linux.
171171
Supported formats are: VST3, AU, LV2, CLAP.
172172
Tested on: macOS 12.6.2
173173

174-
Install plugin via **.dmg** file. copy plugin in format of choice into folder with your plugins.
174+
Install plugin via **.dmg** file. Drag plugin in format of choice into folder with your plugins.
175+
176+
> **Note**<br />
177+
> Due to macOS restrictions, you cannot drag files into untrusted directories. Therefore, double click on directory shortcut, open it and drag it directly there.
175178
176179
> **Note**<br />
177180
> VST3 directory is `/Library/Audio/Plug-ins/VST3`<br />

Scripts/Release/MacOS.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import utils
77
import os
88
import pathlib
9+
import shutil
910
from dotenv import load_dotenv
1011

1112
# Read env variables
@@ -77,8 +78,11 @@ def notarize(bin_path: str) -> None:
7778

7879
utils.log_info("Creating DMG image...")
7980
release_dmg_path = f"{str(RELEASE_DIR_PATH)}/PeakEater-{args.release_version}.dmg"
81+
utils.exec_command("npm install -g appdmg")
82+
shutil.copyfile(
83+
f"{os.path.dirname(__file__)}/configs/appdmg-config.json", f"{RELEASE_DIR_PATH}/appdmg-config.json")
8084
utils.exec_command(
81-
f"hdiutil create -volname PeakEater-{args.release_version} -srcfolder {str(RELEASE_DIR_PATH)} -ov -format ULFO {release_dmg_path}")
85+
f"appdmg {RELEASE_DIR_PATH}/appdmg-config.json {str(RELEASE_DIR_PATH)}/PeakEater-{args.release_version}.dmg")
8286
if args.sign_and_notarize:
8387
codesign(release_dmg_path)
8488
notarize(release_dmg_path)

Scripts/Release/configs/appdmg-config.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
2-
"title": "PeakEater v0.5.0",
3-
"icon": "icon-mac.icns",
2+
"title": "PeakEater",
43
"format": "ULFO",
54
"window": {
65
"size": {

Scripts/Release/configs/inno-config.iss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[Setup]
22
AppName=PeakEater
3-
AppVersion=0.5.0
3+
AppVersion=0.5.1
44
DefaultDirName={cf}
55
DefaultGroupName=PeakEater
66
OutputBaseFilename=PeakEater-windows

Scripts/Release/configs/wix-config.wxs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
2-
<Product Id="*" UpgradeCode="12345678-1111-2222-3333-666666666666" Name="PeakEater" Version="0.5.0.0" Manufacturer="T-Audio" Language="1033">
2+
<Product Id="*" UpgradeCode="12345678-1111-2222-3333-666666666666" Name="PeakEater" Version="0.5.1.0" Manufacturer="T-Audio" Language="1033">
33
<Package InstallerVersion="200" InstallScope="perMachine" Compressed="yes" Comments="PeakEater is a free open-source VST3/AU waveshaper plugin"/>
44
<MediaTemplate EmbedCab="yes" />
55

0 commit comments

Comments
 (0)