Skip to content

Commit b08dcfa

Browse files
committed
add hallmark
1 parent 8abb91b commit b08dcfa

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
- Detect [Beaker](https://beakerbrowser.com/)
1212
- Detect [Brave](https://brave.com/)
13+
- Add [`hallmark`](https://github.com/vweevers/hallmark) devDependency
1314

1415
### Fixed
1516

@@ -58,5 +59,7 @@
5859
- No longer uses command-line version flags or version numbers found in the registry or elsewhere. This simplifies the process and makes the version numbers consistent and more detailed.
5960

6061
[3.1.0]: https://github.com/vweevers/win-detect-browsers/compare/v3.0.0...v3.1.0
62+
6163
[3.0.0]: https://github.com/vweevers/win-detect-browsers/compare/v3.0.0-rc1...v3.0.0
64+
6265
[3.0.0-rc1]: https://github.com/vweevers/win-detect-browsers/compare/v2.1.0...v3.0.0-rc1

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"cli.js"
1313
],
1414
"scripts": {
15-
"test": "standard && node test.js"
15+
"test": "standard && hallmark && node test.js",
16+
"hallmark": "hallmark --fix"
1617
},
1718
"dependencies": {
1819
"after": "~0.8.2",
@@ -31,6 +32,7 @@
3132
"yargs": "~12.0.4"
3233
},
3334
"devDependencies": {
35+
"hallmark": "~0.1.0",
3436
"standard": "~12.0.1",
3537
"tape": "~4.9.0",
3638
"win-dummy-exe": "0.0.1"

readme.md

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,14 @@
1414
- [API](#api)
1515
- [CLI](#cli)
1616
- [Install](#install)
17-
- [Changelog](#changelog)
1817
- [Background](#background)
1918
- [License](#license)
2019

2120
</details>
2221

2322
## Usage
2423

25-
**If you are upgrading:** please see [the changelog](#changelog).
24+
**If you are upgrading:** please see [the changelog](CHANGELOG.md).
2625

2726
```js
2827
const detect = require('win-detect-browsers')
@@ -48,7 +47,7 @@ detect(['chrome', 'firefox'], function (err, browsers) {
4847

4948
### `detect([names, ]callback)`
5049

51-
`names` is an array of browser names you want to find. If omitted or empty, it will detect *[everything](http://youtu.be/k1yvvNvlXtg)*. The `callback` receives an error if any and an array of `results`. A result is excluded if its path has no `.exe` extension or if its version could not be read.
50+
`names` is an array of browser names you want to find. If omitted or empty, it will detect _[everything](http://youtu.be/k1yvvNvlXtg)_. The `callback` receives an error if any and an array of `results`. A result is excluded if its path has no `.exe` extension or if its version could not be read.
5251

5352
Each `result` is an object with the following properties:
5453

@@ -338,13 +337,9 @@ npm install win-detect-browsers # For API
338337
npm install win-detect-browsers -g # For CLI
339338
```
340339

341-
## Changelog
342-
343-
*The changelog has moved to [CHANGELOG.md](CHANGELOG.md).*
344-
345340
## Background
346341

347-
Browser detection on Windows can't be done right. This is the *try-everything-and-fail-silently* approach. It accounts for architecture differences, normalizes environment variables, tries default locations, searches the registry (in the HKLM and HKCU hives as well as WoW counterparts) (including [Start Menu Internet Applications](http://msdn.microsoft.com/en-us/library/windows/desktop/dd203067(v=vs.85).aspx), Google Updater and more), and looks in `PATH`. Version numbers are then read from the executable metadata.
342+
Browser detection on Windows can't be done right. This is the _try-everything-and-fail-silently_ approach. It accounts for architecture differences, normalizes environment variables, tries default locations, searches the registry (in the HKLM and HKCU hives as well as WoW counterparts) (including [Start Menu Internet Applications](http://msdn.microsoft.com/en-us/library/windows/desktop/dd203067(v=vs.85).aspx), Google Updater and more), and looks in `PATH`. Version numbers are then read from the executable metadata.
348343

349344
`browser-launcher` by substack has [poor Windows support](https://github.com/substack/browser-launcher/issues/7), and it prompted me to create this module. It is now used in [browser-launcher2](https://github.com/benderjs/browser-launcher2), ~~an active~~ a once active fork of `browser-launcher`.
350345

0 commit comments

Comments
 (0)