Python fixtures failure during Nix build

[siraben]

Version Information

• vyper Version (output of vyper --version): 0.2.8
• OS: osx
• Python Version (output of python --version): 3.8.6
• Environment (output of pip freeze):

pip freeze

[nix-shell:~/Git/forks/nixpkgs]$ pip freeze
alabaster @ file:///private/tmp/nix-build-python3.8-alabaster-0.7.12.drv-0/alabaster-0.7.12/dist/alabaster-0.7.12-py2.py3-none-any.whl
apipkg @ file:///private/tmp/nix-build-python3.8-apipkg-1.5.drv-0/apipkg-1.5/dist/apipkg-1.5-py2.py3-none-any.whl
astroid @ file:///private/tmp/nix-build-python3.8-astroid-2.4.2.drv-0/astroid-2.4.2/dist/astroid-2.4.2-py3-none-any.whl
asttokens @ file:///private/tmp/nix-build-python3.8-asttokens-2.0.4.drv-0/asttokens-2.0.4/dist/asttokens-2.0.4-py2.py3-none-any.whl
atomicwrites @ file:///private/tmp/nix-build-python3.8-atomicwrites-1.4.0.drv-0/atomicwrites-1.4.0/dist/atomicwrites-1.4.0-py2.py3-none-any.whl
attrs @ file:///private/tmp/nix-build-python3.8-attrs-19.3.0.drv-0/attrs-19.3.0/dist/attrs-19.3.0-py2.py3-none-any.whl
Babel @ file:///private/tmp/nix-build-python3.8-Babel-2.7.0.drv-0/Babel-2.7.0/dist/Babel-2.7.0-py2.py3-none-any.whl
certifi @ file:///private/tmp/nix-build-python3.8-certifi-2020.6.20.drv-0/certifi-2020.6.20/dist/certifi-2020.6.20-py2.py3-none-any.whl
cffi @ file:///private/tmp/nix-build-python3.8-cffi-1.14.3.drv-0/cffi-1.14.3/dist/cffi-1.14.3-cp38-cp38-macosx_10_12_x86_64.whl
chardet @ file:///private/tmp/nix-build-python3.8-chardet-3.0.4.drv-0/chardet-3.0.4/dist/chardet-3.0.4-py2.py3-none-any.whl
commonmark @ file:///private/tmp/nix-build-python3.8-commonmark-0.9.1.drv-0/commonmark-0.9.1/dist/commonmark-0.9.1-py2.py3-none-any.whl
coverage @ file:///private/tmp/nix-build-python3.8-coverage-5.2.1.drv-0/coverage-5.2.1/dist/coverage-5.2.1-cp38-cp38-macosx_10_12_x86_64.whl
cryptography @ file:///private/tmp/nix-build-python3.8-cryptography-3.2.1.drv-0/cryptography-3.2.1/dist/cryptography-3.2.1-cp38-cp38-macosx_10_12_x86_64.whl
docutils @ file:///private/tmp/nix-build-python3.8-docutils-0.16.drv-0/docutils-0.16/dist/docutils-0.16-py2.py3-none-any.whl
execnet @ file:///private/tmp/nix-build-python3.8-execnet-1.7.1.drv-0/execnet-1.7.1/dist/execnet-1.7.1-py2.py3-none-any.whl
future @ file:///private/tmp/nix-build-python3.8-future-0.18.2.drv-0/future-0.18.2/dist/future-0.18.2-py3-none-any.whl
hypothesis @ file:///private/tmp/nix-build-python3.8-hypothesis-5.30.0.drv-0/source/hypothesis-python/dist/hypothesis-5.30.0-py3-none-any.whl
idna @ file:///private/tmp/nix-build-python3.8-idna-2.10.drv-0/idna-2.10/dist/idna-2.10-py2.py3-none-any.whl
imagesize @ file:///private/tmp/nix-build-python3.8-imagesize-1.2.0.drv-0/imagesize-1.2.0/dist/imagesize-1.2.0-py2.py3-none-any.whl
importlib-metadata @ file:///private/tmp/nix-build-python3.8-importlib-metadata-1.7.0.drv-0/importlib_metadata-1.7.0/dist/importlib_metadata-1.7.0-py2.py3-none-any.whl
Jinja2 @ file:///private/tmp/nix-build-python3.8-Jinja2-2.11.2.drv-0/Jinja2-2.11.2/dist/Jinja2-2.11.2-py2.py3-none-any.whl
lazy-object-proxy @ file:///private/tmp/nix-build-python3.8-lazy-object-proxy-1.5.1.drv-0/lazy-object-proxy-1.5.1/dist/lazy_object_proxy-1.5.1-cp38-cp38-macosx_10_12_x86_64.whl
MarkupSafe @ file:///private/tmp/nix-build-python3.8-MarkupSafe-1.1.1.drv-0/MarkupSafe-1.1.1/dist/MarkupSafe-1.1.1-cp38-cp38-macosx_10_12_x86_64.whl
more-itertools @ file:///private/tmp/nix-build-python3.8-more-itertools-8.4.0.drv-0/more-itertools-8.4.0/dist/more_itertools-8.4.0-py3-none-any.whl
packaging @ file:///private/tmp/nix-build-python3.8-packaging-20.4.drv-0/packaging-20.4/dist/packaging-20.4-py2.py3-none-any.whl
pluggy @ file:///private/tmp/nix-build-python3.8-pluggy-0.13.1.drv-0/pluggy-0.13.1/dist/pluggy-0.13.1-py2.py3-none-any.whl
psutil @ file:///private/tmp/nix-build-python3.8-psutil-5.7.3.drv-0/psutil-5.7.3/dist/psutil-5.7.3-cp38-cp38-macosx_10_12_x86_64.whl
py @ file:///private/tmp/nix-build-python3.8-py-1.9.0.drv-0/py-1.9.0/dist/py-1.9.0-py2.py3-none-any.whl
pyasn1 @ file:///private/tmp/nix-build-python3.8-pyasn1-0.4.8.drv-0/pyasn1-0.4.8/dist/pyasn1-0.4.8-py2.py3-none-any.whl
pycparser @ file:///private/tmp/nix-build-python3.8-pycparser-2.20.drv-0/pycparser-2.20/dist/pycparser-2.20-py2.py3-none-any.whl
pycryptodome @ file:///private/tmp/nix-build-python3.8-pycryptodome-3.9.9.drv-0/pycryptodome-3.9.9/dist/pycryptodome-3.9.9-cp38-cp38-macosx_10_12_x86_64.whl
Pygments @ file:///private/tmp/nix-build-python3.8-Pygments-2.6.1.drv-0/Pygments-2.6.1/dist/Pygments-2.6.1-py2.py3-none-any.whl
pyOpenSSL @ file:///private/tmp/nix-build-python3.8-pyOpenSSL-19.1.0.drv-0/pyOpenSSL-19.1.0/dist/pyOpenSSL-19.1.0-py2.py3-none-any.whl
pyparsing @ file:///private/tmp/nix-build-python3.8-pyparsing-2.4.6.drv-0/source/dist/pyparsing-2.4.6-py2.py3-none-any.whl
PySocks @ file:///private/tmp/nix-build-python3.8-pysocks-1.7.1.drv-0/PySocks-1.7.1/dist/PySocks-1.7.1-py3-none-any.whl
PyStemmer @ file:///private/tmp/nix-build-python3.8-PyStemmer-2.0.1.drv-0/PyStemmer-2.0.1/dist/PyStemmer-2.0.1-cp38-cp38-macosx_10_12_x86_64.whl
pytest @ file:///private/tmp/nix-build-python3.8-pytest-5.4.3.drv-0/pytest-5.4.3/dist/pytest-5.4.3-py3-none-any.whl
pytest-cov @ file:///private/tmp/nix-build-python3.8-pytest-cov-2.10.1.drv-0/pytest-cov-2.10.1/dist/pytest_cov-2.10.1-py2.py3-none-any.whl
pytest-forked @ file:///private/tmp/nix-build-python3.8-pytest-forked-1.3.0.drv-0/pytest-forked-1.3.0/dist/pytest_forked-1.3.0-py2.py3-none-any.whl
pytest-xdist @ file:///private/tmp/nix-build-python3.8-pytest-xdist-1.34.0.drv-0/pytest-xdist-1.34.0/dist/pytest_xdist-1.34.0-py2.py3-none-any.whl
pytz @ file:///private/tmp/nix-build-python3.8-pytz-2020.1.drv-0/pytz-2020.1/dist/pytz-2020.1-py3-none-any.whl
recommonmark @ file:///private/tmp/nix-build-python3.8-recommonmark-0.6.0.drv-0/source/dist/recommonmark-0.6.0-py2.py3-none-any.whl
requests @ file:///private/tmp/nix-build-python3.8-requests-2.25.0.drv-0/requests-2.25.0/dist/requests-2.25.0-py2.py3-none-any.whl
semantic-version @ file:///private/tmp/nix-build-python3.8-semantic_version-2.8.5.drv-0/semantic_version-2.8.5/dist/semantic_version-2.8.5-py2.py3-none-any.whl
setuptools-scm @ file:///private/tmp/nix-build-python3.8-setuptools_scm-4.1.2.drv-0/setuptools_scm-4.1.2/dist/setuptools_scm-4.1.2-py2.py3-none-any.whl
six @ file:///private/tmp/nix-build-python3.8-six-1.15.0.drv-0/six-1.15.0/dist/six-1.15.0-py2.py3-none-any.whl
snowballstemmer @ file:///private/tmp/nix-build-python3.8-snowballstemmer-2.0.0.drv-0/snowballstemmer-2.0.0/dist/snowballstemmer-2.0.0-py2.py3-none-any.whl
sortedcontainers @ file:///private/tmp/nix-build-python3.8-sortedcontainers-2.2.2.drv-0/sortedcontainers-2.2.2/dist/sortedcontainers-2.2.2-py3-none-any.whl
Sphinx @ file:///private/tmp/nix-build-python3.8-sphinx-3.0.3.drv-0/Sphinx-3.0.3/dist/Sphinx-3.0.3-py3-none-any.whl
sphinx-rtd-theme @ file:///private/tmp/nix-build-python3.8-sphinx_rtd_theme-0.4.3.drv-0/sphinx_rtd_theme-0.4.3/dist/sphinx_rtd_theme-0.4.3-py2.py3-none-any.whl
sphinxcontrib-applehelp @ file:///private/tmp/nix-build-python3.8-sphinxcontrib-applehelp-1.0.2.drv-0/sphinxcontrib-applehelp-1.0.2/dist/sphinxcontrib_applehelp-1.0.2-py2.py3-none-any.whl
sphinxcontrib-devhelp @ file:///private/tmp/nix-build-python3.8-sphinxcontrib-devhelp-1.0.2.drv-0/sphinxcontrib-devhelp-1.0.2/dist/sphinxcontrib_devhelp-1.0.2-py2.py3-none-any.whl
sphinxcontrib-htmlhelp @ file:///private/tmp/nix-build-python3.8-sphinxcontrib-htmlhelp-1.0.3.drv-0/sphinxcontrib-htmlhelp-1.0.3/dist/sphinxcontrib_htmlhelp-1.0.3-py2.py3-none-any.whl
sphinxcontrib-jsmath @ file:///private/tmp/nix-build-python3.8-sphinxcontrib-jsmath-1.0.1.drv-0/sphinxcontrib-jsmath-1.0.1/dist/sphinxcontrib_jsmath-1.0.1-py2.py3-none-any.whl
sphinxcontrib-qthelp @ file:///private/tmp/nix-build-python3.8-sphinxcontrib-qthelp-1.0.3.drv-0/sphinxcontrib-qthelp-1.0.3/dist/sphinxcontrib_qthelp-1.0.3-py2.py3-none-any.whl
sphinxcontrib-serializinghtml @ file:///private/tmp/nix-build-python3.8-sphinxcontrib-serializinghtml-1.1.4.drv-0/sphinxcontrib-serializinghtml-1.1.4/dist/sphinxcontrib_serializinghtml-1.1.4-py2.py3-none-any.whl
sphinxcontrib-websupport @ file:///private/tmp/nix-build-python3.8-sphinxcontrib-websupport-1.2.4.drv-0/sphinxcontrib-websupport-1.2.4/dist/sphinxcontrib_websupport-1.2.4-py2.py3-none-any.whl
testfixtures @ file:///private/tmp/nix-build-python3.8-testfixtures-6.14.2.drv-0/testfixtures-6.14.2/dist/testfixtures-6.14.2-py2.py3-none-any.whl
toml @ file:///private/tmp/nix-build-python3.8-toml-0.10.2.drv-0/toml-0.10.2/dist/toml-0.10.2-py2.py3-none-any.whl
typed-ast @ file:///private/tmp/nix-build-python3.8-typed-ast-1.4.1.drv-0/source/dist/typed_ast-1.4.1-cp38-cp38-macosx_10_12_x86_64.whl
urllib3 @ file:///private/tmp/nix-build-python3.8-urllib3-1.25.11.drv-0/urllib3-1.25.11/dist/urllib3-1.25.11-py2.py3-none-any.whl
wcwidth @ file:///private/tmp/nix-build-python3.8-wcwidth-0.2.5.drv-0/wcwidth-0.2.5/dist/wcwidth-0.2.5-py2.py3-none-any.whl
Whoosh @ file:///private/tmp/nix-build-python3.8-Whoosh-2.7.4.drv-0/Whoosh-2.7.4/dist/Whoosh-2.7.4-py2.py3-none-any.whl
wrapt @ file:///private/tmp/nix-build-python3.8-wrapt-1.12.1.drv-0/wrapt-1.12.1/dist/wrapt-1.12.1-cp38-cp38-macosx_10_12_x86_64.whl
zipp @ file:///private/tmp/nix-build-python3.8-zipp-3.1.0.drv-0/zipp-3.1.0/dist/zipp-3.1.0-py3-none-any.whl

What's your issue about?

I'm trying to package vyper for Nixpkgs NixOS/nixpkgs#104758

example failure

[gw3] darwin -- Python 3.8.6 /nix/store/0mabx9absir73mmijrsv0dsyvyya463r-python3-3.8.6/bin/python3.8
file /private/tmp/nix-build-python3.8-vyper-0.2.8.drv-0/vyper-0.2.8/tests/compiler/LLL/test_compile_lll.py, line 38
  def test_lll_from_s_expression(get_contract_from_lll):
E       fixture 'get_contract_from_lll' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, testrun_uid, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

/private/tmp/nix-build-python3.8-vyper-0.2.8.drv-0/vyper-0.2.8/tests/compiler/LLL/test_compile_lll.py:38
______________________ ERROR at setup of test_with_depth _______________________
[gw0] darwin -- Python 3.8.6 /nix/store/0mabx9absir73mmijrsv0dsyvyya463r-python3-3.8.6/bin/python3.8
file /private/tmp/nix-build-python3.8-vyper-0.2.8.drv-0/vyper-0.2.8/tests/compiler/LLL/test_with.py, line 1
  def test_with_depth(get_contract_from_lll, assert_compile_failed):
E       fixture 'get_contract_from_lll' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, testrun_uid, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

/private/tmp/nix-build-python3.8-vyper-0.2.8.drv-0/vyper-0.2.8/tests/compiler/LLL/test_with.py:1
________________________ ERROR at setup of test_repeat _________________________
[gw3] darwin -- Python 3.8.6 /nix/store/0mabx9absir73mmijrsv0dsyvyya463r-python3-3.8.6/bin/python3.8
file /private/tmp/nix-build-python3.8-vyper-0.2.8.drv-0/vyper-0.2.8/tests/compiler/LLL/test_repeat.py, line 1
  def test_repeat(get_contract_from_lll, assert_compile_failed):
E       fixture 'get_contract_from_lll' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, testrun_uid, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

/private/tmp/nix-build-python3.8-vyper-0.2.8.drv-0/vyper-0.2.8/tests/compiler/LLL/test_repeat.py:1
____________________ ERROR at setup of test_with_set_depth _____________________
[gw0] darwin -- Python 3.8.6 /nix/store/0mabx9absir73mmijrsv0dsyvyya463r-python3-3.8.6/bin/python3.8
file /private/tmp/nix-build-python3.8-vyper-0.2.8.drv-0/vyper-0.2.8/tests/compiler/LLL/test_with.py, line 163
  def test_with_set_depth(get_contract_from_lll, assert_compile_failed):
E       fixture 'get_contract_from_lll' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, monkeypatch, no_cover, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, testrun_uid, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

/private/tmp/nix-build-python3.8-vyper-0.2.8.drv-0/vyper-0.2.8/tests/compiler/LLL/test_with.py:163

How can it be fixed?

I'm not familiar with python fixtures, what sort of dependency am I missing?

[fubuloubu]

I'm not familiar with python fixtures, what sort of dependency am I missing?

No, that's one of our fixtures from tests/base_conftest.py

The organization is kind of messy 😬

[siraben]

I see. What kind of change or ad-hoc patch would fix this?

[fubuloubu]

Not quite sure, never used Nix before. Why is it executing tests on packaging?

[siraben]

That's the recommended way to package Python packages in Nix, see this.

It is highly encouraged to have testing as part of the package build. This helps to avoid situations where the package was able to build and install, but is not usable at runtime. Currently, all packages will use the test command provided by the setup.py (i.e. python setup.py test). However, this is currently deprecated pypa/setuptools#1878 and your package should provide its own checkPhase.

[fubuloubu]

@siraben so if you look at our CI, it actually uses tox to execute tests. I think locally I just use pytest directly. It sounds like it is trying to execute python setup.py test which maybe be broken