Skip to content

Commit d741657

Browse files
committed
fix: replace setEvents with internalUpdateEvents across tests for consistency
fix: remove redundant theme initialization in NodeFlowController
1 parent 8bd7ddf commit d741657

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

packages/demo/lib/examples/advanced/workbench.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class _WorkbenchExampleState extends State<WorkbenchExample> {
5050
_controller = NodeFlowController<Map<String, dynamic>>(
5151
config: _nodeFlowConfig,
5252
);
53-
_controller.setTheme(_nodeFlowTheme); // Set initial theme in controller
53+
// NOTE: Theme is handled by NodeFlowEditor - no need to set it on the controller
5454
_loadInitialWorkflow();
5555
}
5656

packages/vyuh_node_flow/test/behavior/connections/connection_creation_test.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ void main() {
5656
controller.addNode(node2);
5757

5858
Connection? createdConnection;
59-
controller.setEvents(
59+
controller.internalUpdateEvents(
6060
NodeFlowEvents<String>(
6161
connection: ConnectionEvents(onCreated: (c) => createdConnection = c),
6262
),
@@ -473,7 +473,7 @@ void main() {
473473
Node<String>? startNode;
474474
Port? startPort;
475475

476-
controller.setEvents(
476+
controller.internalUpdateEvents(
477477
NodeFlowEvents<String>(
478478
connection: ConnectionEvents(
479479
onConnectStart: (node, port) {
@@ -589,7 +589,7 @@ void main() {
589589
test('completeConnectionDrag fires onConnectEnd with target', () {
590590
Node<String>? endTargetNode;
591591
Port? endTargetPort;
592-
controller.setEvents(
592+
controller.internalUpdateEvents(
593593
NodeFlowEvents<String>(
594594
connection: ConnectionEvents(
595595
onConnectEnd: (node, port) {
@@ -682,7 +682,7 @@ void main() {
682682
bool callbackFired = false;
683683
Node<String>? endTargetNode;
684684
Port? endTargetPort;
685-
controller.setEvents(
685+
controller.internalUpdateEvents(
686686
NodeFlowEvents<String>(
687687
connection: ConnectionEvents(
688688
onConnectEnd: (node, port) {
@@ -848,7 +848,7 @@ void main() {
848848
);
849849
controller.addNode(node);
850850

851-
controller.setEvents(
851+
controller.internalUpdateEvents(
852852
NodeFlowEvents<String>(
853853
connection: ConnectionEvents<String>(
854854
onBeforeStart: (context) {
@@ -882,7 +882,7 @@ void main() {
882882
controller.addNode(source);
883883
controller.addNode(target);
884884

885-
controller.setEvents(
885+
controller.internalUpdateEvents(
886886
NodeFlowEvents<String>(
887887
connection: ConnectionEvents<String>(
888888
onBeforeComplete: (context) {
@@ -926,7 +926,7 @@ void main() {
926926
controller.addNode(target);
927927

928928
ConnectionCompleteContext<String>? capturedContext;
929-
controller.setEvents(
929+
controller.internalUpdateEvents(
930930
NodeFlowEvents<String>(
931931
connection: ConnectionEvents<String>(
932932
onBeforeComplete: (context) {

packages/vyuh_node_flow/test/behavior/dragging/node_drag_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ void main() {
7979
controller.addNode(node);
8080

8181
Node<String>? draggedNode;
82-
controller.setEvents(
82+
controller.internalUpdateEvents(
8383
NodeFlowEvents<String>(
8484
node: NodeEvents<String>(
8585
onDragStart: (n) {
@@ -148,7 +148,7 @@ void main() {
148148
controller.addNode(node);
149149

150150
Node<String>? movedNode;
151-
controller.setEvents(
151+
controller.internalUpdateEvents(
152152
NodeFlowEvents<String>(
153153
node: NodeEvents<String>(
154154
onDrag: (n) {
@@ -215,7 +215,7 @@ void main() {
215215
controller.addNode(node2);
216216

217217
final movedNodeIds = <String>[];
218-
controller.setEvents(
218+
controller.internalUpdateEvents(
219219
NodeFlowEvents<String>(
220220
node: NodeEvents<String>(
221221
onDrag: (n) {
@@ -305,7 +305,7 @@ void main() {
305305
controller.addNode(node);
306306

307307
Node<String>? stoppedNode;
308-
controller.setEvents(
308+
controller.internalUpdateEvents(
309309
NodeFlowEvents<String>(
310310
node: NodeEvents<String>(
311311
onDragStop: (n) {
@@ -328,7 +328,7 @@ void main() {
328328
controller.addNode(node2);
329329

330330
final stoppedNodeIds = <String>[];
331-
controller.setEvents(
331+
controller.internalUpdateEvents(
332332
NodeFlowEvents<String>(
333333
node: NodeEvents<String>(
334334
onDragStop: (n) {
@@ -402,7 +402,7 @@ void main() {
402402
controller.addNode(node);
403403

404404
final events = <String>[];
405-
controller.setEvents(
405+
controller.internalUpdateEvents(
406406
NodeFlowEvents<String>(
407407
node: NodeEvents<String>(
408408
onDragStart: (n) => events.add('start'),

packages/vyuh_node_flow/test/behavior/selection/connection_selection_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ void main() {
474474
controller.addNode(node2);
475475
controller.addConnection(conn);
476476

477-
controller.setEvents(
477+
controller.internalUpdateEvents(
478478
NodeFlowEvents<String>(
479479
connection: ConnectionEvents<String>(
480480
onSelected: (c) {
@@ -504,7 +504,7 @@ void main() {
504504
controller.addNode(node2);
505505
controller.addConnection(conn);
506506

507-
controller.setEvents(
507+
controller.internalUpdateEvents(
508508
NodeFlowEvents<String>(
509509
connection: ConnectionEvents<String>(
510510
onSelected: (c) {

packages/vyuh_node_flow/test/behavior/selection/node_selection_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ void main() {
414414
String? selectedNodeId;
415415
final node = createTestNode(id: 'node1');
416416
controller.addNode(node);
417-
controller.setEvents(
417+
controller.internalUpdateEvents(
418418
NodeFlowEvents<String>(
419419
node: NodeEvents<String>(
420420
onSelected: (n) {
@@ -433,7 +433,7 @@ void main() {
433433
String? lastSelectedNodeId = 'initial';
434434
final node = createTestNode(id: 'node1');
435435
controller.addNode(node);
436-
controller.setEvents(
436+
controller.internalUpdateEvents(
437437
NodeFlowEvents<String>(
438438
node: NodeEvents<String>(
439439
onSelected: (n) {

packages/vyuh_node_flow/test/edge_cases/concurrent_operations_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ void main() {
459459

460460
controller = createTestController();
461461
// Create events directly to avoid type inference issues with copyWith
462-
controller.setEvents(
462+
controller.internalUpdateEvents(
463463
NodeFlowEvents<String>(
464464
node: NodeEvents<String>(
465465
onCreated: (node) => nodeCreatedCount++,

0 commit comments

Comments
 (0)