Skip to content

Commit a3bca83

Browse files
committed
Trim ids when cloning descriptions
1 parent a010993 commit a3bca83

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

script/aria.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function ariaAttributeReferences() {
4545
'</span>';
4646
sp.setAttribute('aria-describedby', 'desc-' + title);
4747
var dRef = item.nextElementSibling;
48-
var desc = dRef.firstElementChild.innerHTML;
48+
var desc = cloneWithoutIds(dRef.firstElementChild).innerHTML;
4949
dRef.id = 'desc-' + title;
5050
dRef.setAttribute('role', 'definition');
5151
var heading = document.createElement('h4');
@@ -254,7 +254,7 @@ function ariaAttributeReferences() {
254254
// sp.id = title;
255255
sp.setAttribute('aria-describedby', 'desc-' + title);
256256
var dRef = item.nextElementSibling;
257-
var desc = dRef.firstElementChild.innerHTML;
257+
var desc = cloneWithoutIds(dRef.firstElementChild).innerHTML;
258258
dRef.id = 'desc-' + title;
259259
dRef.setAttribute('role', 'definition');
260260
container.replaceChild(sp, item);
@@ -744,6 +744,14 @@ function ariaAttributeReferences() {
744744
});
745745

746746
updateReferences(document);
747+
748+
function cloneWithoutIds(node) {
749+
const clone = node.cloneNode(true);
750+
for (const elementWithId of clone.querySelectorAll("[id]")) {
751+
elementWithId.removeAttribute("id");
752+
}
753+
return clone;
754+
}
747755
}
748756

749757
require(['core/pubsubhub'], function (respecEvents) {

0 commit comments

Comments
 (0)