Skip to content

Commit 9a5e55c

Browse files
authored
Landmark Practice: Add note to prevent dialog content wrapped in a landmark (pull #2818)
Resolve issue #2512 by adding the following note to principles of landmark design: >Note that wrapping the content of a modal dialog in a landmark region is unnecessary. A landmark that wraps modal content cannot provide any benefit to users because it is not perceivable unless the modal is open. In addition, when a modal is open, a landmark containing its content is superfluous because the modal itself is a container that provides both a name and boundaries.
1 parent 7fb7c8e commit 9a5e55c

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

content/patterns/landmarks/examples/general-principles.html

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,11 @@ <h1>General Principles</h1>
8080
<li>
8181
Landmark roles can be nested to identify parent/child relationships of the information being presented.
8282
</li>
83+
<li>
84+
Note that wrapping the content of a modal dialog in a landmark region is unnecessary.
85+
A landmark that wraps modal content cannot provide any benefit to users because it is not perceivable unless the modal is open.
86+
In addition, when a modal is open, a landmark containing its content is superfluous because the modal itself is a container that provides both a name and boundaries.
87+
</li>
8388
</ul>
8489

8590
<p style="font-weight: bold">Step 3: Label each area</p>

content/practices/landmark-regions/landmark-regions-practice.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,13 @@ <h2>General Principles of Landmark Design</h2>
103103

104104
<ul>
105105
<li>Assign landmark roles based on the type of content in the area.</li>
106-
107106
<li><code>banner</code>, <code>main</code>, <code>complementary</code> and <code>contentinfo</code> landmarks should be top level landmarks.</li>
108-
109107
<li>Landmark roles can be nested to identify parent/child relationships of the information being presented.</li>
108+
<li>
109+
Note that wrapping the content of a modal dialog in a landmark region is unnecessary.
110+
A landmark that wraps modal content cannot provide any benefit to users because it is not perceivable unless the modal is open.
111+
In addition, when a modal is open, a landmark containing its content is superfluous because the modal itself is a container that provides both a name and boundaries.
112+
</li>
110113
</ul>
111114

112115
<p id="aria_lh_step3"><strong>Step 3: Label areas</strong></p>

0 commit comments

Comments
 (0)