Skip to content

Commit ba6ccbd

Browse files
committed
More fixes from comments
1 parent c8f8afc commit ba6ccbd

File tree

1 file changed

+12
-40
lines changed

1 file changed

+12
-40
lines changed

index.html

Lines changed: 12 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,6 @@ <h3>Pressure sources</h3>
161161
<em>global system thermals</em> and the <em>central [=processing unit=]</em>, also known as the CPU.
162162
Future levels of this specification MAY introduce additional [=source types=].
163163
</p>
164-
<p>
165-
If a [=virtual pressure source=] exists, the [=supported source types=] is equal to the
166-
[=source types=] [=map/keys=] in the [=virtual pressure source mapping=] [=ordered map=].
167-
</p>
168164
<pre class="idl">
169165
enum PressureSource { "thermals", "cpu" };
170166
</pre>
@@ -1098,10 +1094,10 @@ <h3>Data Collection and Delivery</h3>
10981094
</p>
10991095
<aside class="note">
11001096
It is recommended that the [=platform collector=] suspends low-level data collection
1101-
when there is no active [=data collection=] to any {{PressureObserver}} [=relevant global object=].
1097+
when there is no active [=data collection=] to any {{PressureObserver}}'s [=relevant global object=].
11021098
</aside>
11031099
<p>
1104-
The <dfn>data collection</dfn> steps given |relevantGlobal| as input, is run when
1100+
The <dfn>data collection</dfn> steps given |relevantGlobal| as input, are run when
11051101
the |relevantGlobal| associated [=platform collector=] needs to obtain new |data|
11061102
for a [=source type=] |source:PressureSource| and are as follows:
11071103
<ol>
@@ -1730,17 +1726,6 @@ <h4>
17301726
yes
17311727
</td>
17321728
</tr>
1733-
<tr>
1734-
<td>
1735-
samples
1736-
</td>
1737-
<td>
1738-
Array of strings
1739-
</td>
1740-
<td>
1741-
yes
1742-
</td>
1743-
</tr>
17441729
</table>
17451730
<p>
17461731
The [=remote end steps=] given |session|, |URL variables| and |parameters| are:
@@ -1760,24 +1745,6 @@ <h4>
17601745
<li>
17611746
If |sampleInterval| is not an Number, return [=error=] with [=error code|WebDriver error code=] [=invalid argument=].
17621747
</li>
1763-
<li>
1764-
Let |samples| be the result of invoking
1765-
<a data-cite="!WEBDRIVER2#dfn-getting-properties">get a property</a> "samples" from |parameters|.
1766-
</li>
1767-
<li>
1768-
If |samples| is not an Array, return [=error=] with [=error code|WebDriver error code=] [=invalid argument=].
1769-
</li>
1770-
<li>
1771-
For each |sample| in |samples|:
1772-
<ol>
1773-
<li>
1774-
If |sample| is not a [=string=] and a valid {{PressureState}}, return [=error=] with [=error code|WebDriver error code=] [=invalid argument=].
1775-
</li>
1776-
<li>
1777-
[=queue/Enqueue=] |sample| to |virtualPressureSource|'s [=pending samples=].
1778-
</li>
1779-
</ol>
1780-
</li>
17811748
<li>
17821749
Let |topLevelTraversable| be the <a data-cite="webdriver2/#dfn-current-browsing-context">current browsing
17831750
context</a>'s [=browsing context/top-level traversable=].
@@ -1832,8 +1799,8 @@ <h4>
18321799
</tr>
18331800
</table>
18341801
<p>
1835-
This [=extension command=] deletes a given [=source type=] of [=virtual pressure source=] and returns
1836-
pressure source updates back to hardware.
1802+
This [=extension command=] deletes a given [=source type=] of [=virtual pressure source=], meaning that,
1803+
if available, data will be delivered the regular way, by non-virtual means.
18371804
</p>
18381805
<p>
18391806
The [=remote end steps=] given |session|, |URL variables| and |parameters| are:
@@ -1842,6 +1809,9 @@ <h4>
18421809
<li>
18431810
Let |virtualPressureSourceType| be the value of the |URL variables|["type"].
18441811
</li>
1812+
<li>
1813+
If |virtualPressureSourceType| is not a [=valid source type=], return [=error=] with [=error code|WebDriver error code=] [=invalid argument=].
1814+
</li>
18451815
<li>
18461816
Let |topLevelTraversable| be the <a data-cite="webdriver2/#dfn-current-browsing-context">current browsing
18471817
context</a>'s [=browsing context/top-level traversable=].
@@ -1850,8 +1820,7 @@ <h4>
18501820
Let |topLevelVirtualPressureSourceMapping| be the |topLevelTraversable|'s [=virtual pressure source mapping=].
18511821
</li>
18521822
<li>
1853-
Remove |topLevelVirtualPressureSourceMapping|[|virtualPressureSourceType|] and any data associated with its
1854-
[=virtual pressure source=].
1823+
[map/Remove] |topLevelVirtualPressureSourceMapping|[|virtualPressureSourceType|].
18551824
</li>
18561825
<li>
18571826
Return [=success=] with data <code>null</code>.
@@ -1925,7 +1894,7 @@ <h4>
19251894
Let |virtualPressureSourceType| be the value of the |URL variables|["type"].
19261895
</li>
19271896
<li>
1928-
If |virtualPressureSourceType| is not a [=string=], return [=error=] with [=error code|WebDriver error code=] [=invalid argument=].
1897+
If |virtualPressureSourceType| is not a [=valid source type=], return [=error=] with [=error code|WebDriver error code=] [=invalid argument=].
19291898
</li>
19301899
<li>
19311900
Let |topLevelTraversable| be the <a data-cite="webdriver2/#dfn-current-browsing-context">current browsing
@@ -1955,6 +1924,9 @@ <h4>
19551924
<li>
19561925
If |sample| is not a [=string=] and a valid {{PressureState}}, return [=error=] with [=error code|WebDriver error code=] [=invalid argument=].
19571926
</li>
1927+
</ol>
1928+
For each |sample| in |samples|:
1929+
<ol>
19581930
<li>
19591931
[=queue/Enqueue=] |sample| to |virtualPressureSource|'s [=pending samples=].
19601932
</li>

0 commit comments

Comments
 (0)