Skip to content

Commit f40f567

Browse files
authored
Fix bikeshed errors in color adjust spec (#12155)
* fix bikeshed warnings * clean up * address feedback
1 parent 61108aa commit f40f567

File tree

1 file changed

+18
-9
lines changed

1 file changed

+18
-9
lines changed

css-color-adjust-1/Overview.bs

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,20 @@ WPT Display: open
2020
</pre>
2121
<pre class='link-defaults'>
2222
spec:css2; type:dfn; text:canvas
23+
spec:css-backgrounds-3; type:property;
24+
text:border-color
25+
text:box-shadow
2326
spec:css-color-4; type:property; text:color
27+
spec:css-color-5; type:function; text:color()
2428
spec:fill-stroke-3; type:property;
2529
text:fill
2630
text:stroke
27-
spec: html; urlPrefix: https://html.spec.whatwg.org/multipage/; type: dfn;
28-
text: navigable; for:Window; url: nav-history-apis.html#window-navigable
29-
text: top-level traversable; for:/; url: document-sequences.html#top-level-traversable
31+
spec:css-gaps-1; type:property; text:column-rule-color
32+
spec: html;
33+
text:body; type:element
34+
text:meta; type:element
35+
text:navigable; type:dfn; for:Window;
36+
text:top-level traversable; type:dfn; for:/;
3037
</pre>
3138

3239
<pre class=anchors>
@@ -57,7 +64,9 @@ Introduction {#intro}
5764
to automatically adjust colors to the user's assumed performance preferences,
5865
such as suppressing background colors when printing to save ink.
5966

60-
Together with the 'prefers-color-scheme', 'prefers-contrast', and 'forced-colors' [=media queries=] [[!MEDIAQUERIES-5]],
67+
Together with the <a descriptor for=@media>prefers-color-scheme</a>,
68+
<a descriptor for=@media>prefers-contrast</a>, and
69+
<a descriptor for=@media>forced-colors</a> [=media queries=] [[!MEDIAQUERIES-5]],
6170
this module allows color scheme negotiation
6271
between the author and the user.
6372

@@ -171,7 +180,7 @@ Opting Into a Preferred Color Scheme: the 'color-scheme' property {#color-scheme
171180
rendering/dark-color-scheme/color-scheme-visited-link-initial.html
172181
</wpt>
173182

174-
While the 'prefers-color-scheme' media feature
183+
While the <a descriptor for=@media>prefers-color-scheme</a> media feature
175184
allows an author to adapt the page’s colors to the user’s preferred color scheme,
176185
many parts of the page are not under the author's control
177186
(such as form controls, scrollbars, etc).
@@ -244,7 +253,7 @@ Opting Into a Preferred Color Scheme: the 'color-scheme' property {#color-scheme
244253
To <dfn noexport>determine the used color scheme</dfn> of an element:
245254

246255
1. If the user's [=preferred color scheme=],
247-
as indicated by the 'prefers-color-scheme' media feature,
256+
as indicated by the <a descriptor for=@media>prefers-color-scheme</a> media feature,
248257
is present among the listed [=color schemes=],
249258
and is supported by the user agent,
250259
that's the element's [=used color scheme=].
@@ -275,7 +284,7 @@ Opting Into a Preferred Color Scheme: the 'color-scheme' property {#color-scheme
275284

276285
<div class=example>
277286
A page that responds to user preferences for light or dark display
278-
by using the 'prefers-color-scheme' media feature
287+
by using the <a descriptor for=@media>prefers-color-scheme</a> media feature
279288
to alter the colors it uses
280289
can easily opt the browser-controlled UI
281290
(scrollbars, inputs, etc)
@@ -420,7 +429,7 @@ to conform to either a [=dark=] or [=light=] color scheme.
420429
and have indicated so using the 'color-scheme' property
421430
or <{meta/name/color-scheme}> <{meta}> name,
422431
this has no effect other than reporting a ''@media/prefers-color-scheme/dark'' value
423-
for the 'prefers-color-scheme' [=media query=]
432+
for the <a descriptor for=@media>prefers-color-scheme</a> [=media query=]
424433
and selecting a [=dark=] [=used color scheme=].
425434

426435
But for pages that do not explicitly support a [=dark=] color scheme,
@@ -788,7 +797,7 @@ Forced Color Palettes {#forced}
788797
<!--THOUGHTS
789798
This advice (below) maybe makes sense for (prefers-contrast),
790799
but is it really applicable to forced-colors as well?
791-
If so, should forced-colors be instead a 'forced' value on 'prefers-contrast',
800+
If so, should forced-colors be instead a 'forced' value on <a descriptor for=@media>prefers-contrast</a>,
792801
so that a (prefers-contrast) query will catch all of these cases at once?
793802

794803
Authors are encouraged to simplify the contrast in their pages

0 commit comments

Comments
 (0)