Extract lookup of repo/CG/WG data from APIs to validate.js (#64)

This allows more of the code to be tested, and is a more reasonable
interface, as `validateRepo` doesn't need information related to all
repositories.

Author: foolip

lib/validator.js

@@ -39,7 +39,8 @@ const mdMatch = (md, ref) => nlToSpace(httpToHttps(md.toLowerCase())).indexOf(nl
 
 const fullName = r => r.owner.login + '/' + r.name;
 
-function validateRepo(r, licenses, repoData, cgData, repoMap) {
+// Also potentially sets `r.prpreview` and `r.w3c`.
+function validateRepo(r, data, licenses) {
   const {contributing, contributingSw, license, licenseSw} = licenses;
 
   const errors = [];
@@ -70,20 +71,12 @@ function validateRepo(r, licenses, repoData, cgData, repoMap) {
   let shouldBeRepoManaged = false;
   const hasRecTrack = {ashnazg: null, repotype: null, tr: null}; // TODO detect conflicting information (repo-type vs ash-nazg vs TR doc)
 
-  // is the repo associated with a CG in the CG monitor?
-  const cg = cgData.data.find(cg => {
-    return cg.repositories.includes('https://github.com/' + fullName(r)) ||
-           cg.repositories.includes('https://github.com/' + fullName(r) + '/');
-  });
-
-  // is the repo associated with a WG in the spec dashboard?
-  const wgRepo = repoMap[fullName(r)];
-
-  if (wgRepo) {
-    hasRecTrack.tr = wgRepo.some(x => x.recTrack);
+  const {specs} = data;
+  if (specs && specs.length) {
+    hasRecTrack.tr = specs.some(s => s.recTrack);
   }
 
-  const ashRepo = repoData.find(x => x.owner.toLowerCase() === r.owner.login.toLowerCase() && x.name.toLowerCase() === r.name.toLowerCase());
+  const {ashRepo} = data;
   if (ashRepo) {
     hasRecTrack.ashnazg = ashRepo.groups.some(g => g.groupType === "WG");
   }
@@ -123,6 +116,7 @@ function validateRepo(r, licenses, repoData, cgData, repoMap) {
     if (!conf.group && ["rec-track", "note", "cg-report"].includes(conf["repo-type"])) {
       reportError('incompletew3cjson', {error: "group"});
     } else {
+      // Note that `data.groups` is unused here.
       groups = arrayify(conf.group).map(id => parseInt(id, 10));
       shouldBeRepoManaged = conf["repo-type"] && (conf["repo-type"] === 'rec-track' || conf["repo-type"] === 'cg-report');
     }
@@ -134,17 +128,7 @@ function validateRepo(r, licenses, repoData, cgData, repoMap) {
       }
     }
   } else {
-    if (cg) {
-      groups = [cg.id];
-    } else if (r.owner.login === 'WICG') {
-      groups = [80485];
-    }
-    if (wgRepo && wgRepo.length) {
-      groups = groups.concat(wgRepo.map(x => x.group));
-    }
-    if (r.owner.login === 'WebAudio') {
-      groups.push(46884);
-    }
+    groups = data.groups;
     reportError('now3cjson');
   }
   const recTrackStatus = hasRecTrack.tr || hasRecTrack.ashnazg || hasRecTrack.repo;
@@ -177,7 +161,6 @@ function validateRepo(r, licenses, repoData, cgData, repoMap) {
 
   return {
     errors, groups,
-    isAshRepo: !!ashRepo,
     hasRecTrack: !!recTrackStatus,
   };
 }

lib/w3cData.js

@@ -0,0 +1,61 @@
+/* eslint-env node */
+
+// Additional W3C data about a repo that isn't from the GitHub repo/API.
+
+"use strict";
+
+const fetch = require("node-fetch");
+const w3c = require("node-w3capi");
+
+const config = require("../config.json");
+w3c.apiKey = config.w3capikey;
+
+async function data() {
+  const [ashRepos, cgData, repoMap, w3cgroups] = await Promise.all([
+    fetch("https://labs.w3.org/hatchery/repo-manager/api/repos").then(r => r.json()),
+    fetch("https://w3c.github.io/cg-monitor/report.json").then(r => r.json()),
+    fetch("https://w3c.github.io/spec-dashboard/repo-map.json").then(r => r.json()),
+    // https://github.com/w3c/node-w3capi/issues/41
+    new Promise((resolve, reject) => {
+      w3c.groups().fetch({embed: true}, (err, w3cgroups) => {
+        if (err) {
+          reject(err);
+        } else {
+          resolve(w3cgroups);
+        }
+      });
+    })
+  ]);
+
+  function get(owner, name) {
+    const fullName = `${owner}/${name}`;
+    const ashRepo = ashRepos.find(x => {
+      return x.owner.toLowerCase() === owner.toLowerCase() &&
+          x.name.toLowerCase() === name.toLowerCase();
+    }) || null;
+    const cg = cgData.data.find(cg => {
+      return cg.repositories.includes(`https://github.com/${fullName}`) ||
+          cg.repositories.includes(`https://github.com/${fullName}/`);
+    });
+    const specs = repoMap[fullName] || [];
+
+    const groups = [];
+    if (cg) {
+      groups.push(cg.id);
+    } else if (owner === 'WICG') {
+      groups.push(80485);
+    }
+    for (const spec of specs) {
+      groups.push(spec.group);
+    }
+    if (owner === 'WebAudio') {
+      groups.push(46884);
+    }
+
+    return {ashRepo, specs, groups};
+  }
+
+  return {get, w3cgroups};
+}
+
+module.exports = data;