Use verificationSucess to test common algorithm tests.

Author: aljones15

tests/suites/algorithms.js

@@ -2,8 +2,14 @@
  * Copyright 2024 Digital Bazaar, Inc.
  * SPDX-License-Identifier: BSD-3-Clause
  */
+import {
+  assertions,
+  generators,
+  issueCloned
+} from 'data-integrity-test-suite-assertion';
 import {createInitialVc, endpointCheck} from '../helpers.js';
 import {expect} from 'chai';
+import {localVerifier} from '../vc-verifier/index.js';
 
 export function algorithmSuite({
   suiteName
@@ -15,9 +21,11 @@ export function commonAlgorithms({
   issuers,
   mandatoryPointers,
   keyType,
+  cryptosuite,
   suiteName,
   vcVersion
 }) {
+  const verifier = localVerifier({cryptosuite});
   for(const [name, {endpoints}] of issuers) {
     const [issuer] = endpoints;
     // does the endpoint support this test?
@@ -26,35 +34,48 @@ export function commonAlgorithms({
     }
     describe(`${name}: ${keyType}`, function() {
       let securedCredential = null;
-      let proofs = [];
       before(async function() {
         securedCredential = await createInitialVc({
           issuer,
           vcVersion,
           vc: credential,
           mandatoryPointers
         });
-        if(securedCredential) {
-          proofs = Array.isArray(securedCredential.proof) ?
-            securedCredential?.proof : [securedCredential?.proof];
-          // only test proofs that match the relevant cryptosuite
-          proofs = proofs.filter(p => p?.cryptosuite === suiteName);
-        }
       });
       it('When generating ECDSA signatures, the signature value MUST be ' +
-        'expressed according to section 7 of [RFC4754] (sometimes referred to ' +
-        'as the IEEE P1363 format) and encoded according to the specific ' +
+        'expressed according to section 7 of [RFC4754] (sometimes referred ' +
+        'to as the IEEE P1363 format) and encoded according to the specific ' +
         'cryptosuite proof generation algorithm.', async function() {
         this.test.link = 'https://w3c.github.io/vc-di-ecdsa/#algorithms:~:text=When%20generating%20ECDSA%20signatures%2C%20the%20signature%20value%20MUST%20be%20expressed%20according%20to%20section%207%20of%20%5BRFC4754%5D%20(sometimes%20referred%20to%20as%20the%20IEEE%20P1363%20format)%20and%20encoded%20according%20to%20the%20specific%20cryptosuite%20proof%20generation%20algorithm';
+        await assertions.verificationSuccess({
+          credential: securedCredential,
+          verifier,
+          reason: `Should verify VC signed with ${suiteName} ${keyType}`
+        });
       });
-      it('For P-256 keys, the default hashing function, SHA-2 with 256 bits of ' +
-        'output, MUST be used.', async function() {
-        this.test.link = 'https://w3c.github.io/vc-di-ecdsa/#algorithms:~:text=For%20P%2D256%20keys%2C%20the%20default%20hashing%20function%2C%20SHA%2D2%20with%20256%20bits%20of%20output%2C%20MUST%20be%20used.';
-      });
-      it('For P-384 keys, SHA-2 with 384-bits of output MUST be used, specified ' +
-        'via the RDFC-1.0 implementation-specific parameter.', async function() {
-        this.test.link = 'https://w3c.github.io/vc-di-ecdsa/#algorithms:~:text=For%20P%2D384%20keys%2C%20SHA%2D2%20with%20384%2Dbits%20of%20output%20MUST%20be%20used%2C%20specified%20via%20the%20RDFC%2D1.0%20implementation%2Dspecific%20parameter.';
-      });
+      if(keyType === 'P-256') {
+        it('For P-256 keys, the default hashing function, SHA-2 with 256 bits' +
+          'of output, MUST be used.', async function() {
+          this.test.link = 'https://w3c.github.io/vc-di-ecdsa/#algorithms:~:text=For%20P%2D256%20keys%2C%20the%20default%20hashing%20function%2C%20SHA%2D2%20with%20256%20bits%20of%20output%2C%20MUST%20be%20used.';
+          await assertions.verificationSuccess({
+            credential: securedCredential,
+            verifier,
+            reason: `Should verify VC signed with ${suiteName} ${keyType}`
+          });
+        });
+      }
+      if(keyType === 'P-384') {
+        it('For P-384 keys, SHA-2 with 384-bits of output MUST be used, ' +
+          'specified via the RDFC-1.0 implementation-specific parameter.',
+        async function() {
+          this.test.link = 'https://w3c.github.io/vc-di-ecdsa/#algorithms:~:text=For%20P%2D384%20keys%2C%20SHA%2D2%20with%20384%2Dbits%20of%20output%20MUST%20be%20used%2C%20specified%20via%20the%20RDFC%2D1.0%20implementation%2Dspecific%20parameter.';
+          await assertions.verificationSuccess({
+            credential: securedCredential,
+            verifier,
+            reason: `Should verify VC signed with ${suiteName} ${keyType}`
+          });
+        });
+      }
     });
   }
 }