Skip to content

Commit c883de1

Browse files
committed
Remove commented out code; leave explanation.
1 parent 1b05199 commit c883de1

File tree

1 file changed

+5
-79
lines changed

1 file changed

+5
-79
lines changed

tests/95-functions-sd.js

Lines changed: 5 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* SPDX-License-Identifier: BSD-3-Clause
44
*/
55
import {
6-
// createDisclosedVc,
76
encodeSdDerivedProofValue,
87
generateCredential,
98
inspectSdBaseProofValue,
@@ -100,84 +99,11 @@ describe('Functions - ecdsa-sd-2023', function() {
10099
'Implementation must not use CBOR tagging.'
101100
);
102101
});
103-
// 3.5.3 parseBaseProofValue
104-
// it('If the proofValue string does not start with u, ' +
105-
// 'indicating that it is a multibase-base64url-no-pad-encoded value, ' +
106-
// 'an error MUST be raised and SHOULD convey an error type of ' +
107-
// 'PROOF_VERIFICATION_ERROR.',
108-
// async function() {
109-
// this.test.link = 'https://www.w3.org/TR/vc-di-ecdsa/#selective-disclosure-functions';
110-
// if(holder) {
111-
// const proof = proofExists(securedCredential);
112-
// should.exist(proof.proofValue,
113-
// 'Expected proof to have proofValue.');
114-
// // Create negative fixture
115-
// const invalidBaseCredential = structuredClone(securedCredential);
116-
// invalidBaseCredential.proof.proofValue =
117-
// invalidBaseCredential.proof.proofValue.slice(1);
118-
// ({disclosedCredential} = await createDisclosedVc(
119-
// {
120-
// selectivePointers: ['/credentialSubject/id'],
121-
// signedCredential: invalidBaseCredential,
122-
// vcHolder: holder
123-
// }));
124-
// should.not.exist(disclosedCredential?.proof,
125-
// '"Derive" endpoint should reject proof without multibase indicator.'
126-
// );
127-
// } else {
128-
// this.skip();
129-
// }
130-
// });
131-
// 3.5.3 parseBaseProofValue
132-
// it('If the decodedProofValue does not start with the ' +
133-
// 'ECDSA-SD base proof header bytes 0xd9, 0x5d, ' +
134-
// 'and 0x00, an error MUST be raised and SHOULD ' +
135-
// 'convey an error type of PROOF_VERIFICATION_ERROR.',
136-
// async function() {
137-
// this.test.link = 'https://www.w3.org/TR/vc-di-ecdsa/#selective-disclosure-functions';
138-
// if(holder) {
139-
// const proof = proofExists(securedCredential);
140-
// should.exist(proof.proofValue,
141-
// 'Expected proof to have proofValue.');
142-
// // Create negative fixture
143-
// const invalidBaseCredential = structuredClone(securedCredential);
144-
// invalidBaseCredential.proof.proofValue =
145-
// invalidBaseCredential.proof.proofValue.slice(0, 1) +
146-
// invalidBaseCredential.proof.proofValue.slice(4);
147-
// ({disclosedCredential} = await createDisclosedVc(
148-
// {
149-
// selectivePointers: ['/credentialSubject/id'],
150-
// signedCredential: invalidBaseCredential,
151-
// vcHolder: holder
152-
// }));
153-
// should.not.exist(disclosedCredential?.proof,
154-
// '"Derive" endpoint should reject proof without header.'
155-
// );
156-
// } else {
157-
// this.skip();
158-
// }
159-
// });
160-
// 3.5.7 serializeDerivedProofValue
161-
// it('CBOR-encode components per [RFC8949] where CBOR ' +
162-
// 'tagging MUST NOT be used on any of the components.',
163-
// async function() {
164-
// this.test.link = 'https://www.w3.org/TR/vc-di-ecdsa/#selective-disclosure-functions';
165-
// if(holder) {
166-
// ({disclosedCredential} = await createDisclosedVc(
167-
// {
168-
// selectivePointers: ['/credentialSubject/id'],
169-
// signedCredential: securedCredential,
170-
// vcHolder: holder
171-
// }));
172-
// const decodedDerivedProofValue =
173-
// await inspectSdDerivedProofValue(disclosedCredential.proof);
174-
// should.exist(decodedDerivedProofValue,
175-
// 'Implementation must not use CBOR tagging.'
176-
// );
177-
// } else {
178-
// this.skip();
179-
// }
180-
// });
102+
103+
// 3.5.3 parseBaseProofValue - untestable without special endpoints
104+
// 3.5.3 parseBaseProofValue - untestable without special endpoints
105+
// 3.5.7 serializeDerivedProofValue - untestable without special endpoints
106+
181107
// 3.5.8 parseDerivedProofValue
182108
it('If the proofValue string does not start with u, ' +
183109
'indicating that it is a multibase-base64url-no-pad-encoded ' +

0 commit comments

Comments
 (0)