Skip to content

Conversation

@PatStLouis
Copy link
Contributor

Adds a couple helper functions and coverage for jcs statements.

@PatStLouis PatStLouis changed the base branch from main to add-algorithm-suites November 11, 2024 21:05
@aljones15 aljones15 marked this pull request as ready for review November 13, 2024 16:54
@aljones15 aljones15 marked this pull request as draft November 13, 2024 17:40
@aljones15 aljones15 requested a review from BigBlueHat November 13, 2024 19:46
@aljones15 aljones15 self-assigned this Nov 13, 2024
@aljones15 aljones15 marked this pull request as ready for review November 13, 2024 19:47
@aljones15
Copy link
Contributor

the tests runs and don't conflict with the other tests so I am marking this ready for review.
It needs to take multiple credentials, but working tests are working tests.

@BigBlueHat BigBlueHat requested a review from TallTed November 13, 2024 19:50
Copy link
Member

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, as always!

@aljones15 aljones15 merged commit 406d3f1 into add-algorithm-suites Nov 13, 2024
2 checks passed
@aljones15 aljones15 deleted the algo-ecdsa-jcs-2019 branch November 13, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants