Skip to content

Add ecdsa-sd-2023 issuer proofValue & invalid proof.created test (B -> A) #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: algorithm-sd-suite
Choose a base branch
from
Open

Add ecdsa-sd-2023 issuer proofValue & invalid proof.created test (B -> A) #99

wants to merge 10 commits into from

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Nov 15, 2024 •
edited
Loading

Features:

  1. Adds an issuer based proofValue check for sd (this is an older test from sd-create).
  2. Adds a file for algorithms-sd to tests dir
  3. Adds a proof config invalid created verifier test
  4. Merges into the ecdsa-sd-2023 Algorithms PR
  5. Corrects an issue with skipMessage
  6. Uses a newer setup file
  7. Adds a non-existent mandatory pointer negative test

This PR should be merged into the SD Algorithms PR.

@aljones15 aljones15 changed the title Add sd proof value check Add ecdsa-sd-2023 issuer proofValue & invalid proof.created test Nov 15, 2024
@aljones15 aljones15 self-assigned this Nov 15, 2024
@aljones15 aljones15 changed the title Add ecdsa-sd-2023 issuer proofValue & invalid proof.created test Add ecdsa-sd-2023 issuer proofValue & invalid proof.created test (B) Nov 15, 2024
@aljones15 aljones15 changed the title Add ecdsa-sd-2023 issuer proofValue & invalid proof.created test (B) Add ecdsa-sd-2023 issuer proofValue & invalid proof.created test (B -> A) Nov 15, 2024
@aljones15 aljones15 marked this pull request as ready for review November 15, 2024 17:29
@BigBlueHat
Copy link
Member

@aljones15 can you reword the commit subject from
assertIssuer added to issuer tests.
to Add assertIssuer to issuer tests.? Trying to follow the verb/action first pattern. Sorry for the nit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatStLouis PatStLouis Awaiting requested review from PatStLouis

@gannan08 gannan08 Awaiting requested review from gannan08

@BigBlueHat BigBlueHat Awaiting requested review from BigBlueHat

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljones15 @BigBlueHat