Skip to content

Commit 010ff90

Browse files
Refactor quote component
See w3c/w3c-website#454
1 parent 901347d commit 010ff90

File tree

5 files changed

+11
-40
lines changed

5 files changed

+11
-40
lines changed

assets-src/styles/sass/50-core-components/_quotes.scss

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,26 +15,13 @@
1515
&::before {
1616
background-color: $w3c-blue;
1717
border-radius: rem(5);
18-
content: '';
19-
height: 100%;
2018
left: rem(-10);
21-
position: absolute;
22-
top: 0;
2319
width: rem(10);
2420
}
2521

2622
> * {
2723
max-width: rem(630);
2824
}
29-
30-
blockquote {
31-
margin-inline-start: 0;
32-
padding: 0;
33-
34-
&::before {
35-
display: none;
36-
}
37-
}
3825
}
3926

4027
[dir="rtl"] {
Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
<figure class="component component--quote">
2-
<blockquote>
3-
<p>The goal of the Web is to serve humanity. We build it now so that those who come to it later will be able to create things we cannot ourselves imagine.</p>
4-
</blockquote>
5-
<figcaption>Sir Tim Berners-Lee</figcaption>
6-
</figure>
1+
<blockquote class="component component--quote">
2+
<p>The goal of the Web is to serve humanity. We build it now so that those who come to it later will be able to create things we cannot ourselves imagine.</p>
3+
<footer>Sir Tim Berners-Lee</footer>
4+
</blockquote>

public/dist/assets/styles/core.css

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3205,24 +3205,12 @@ main,
32053205
.component--quote::before {
32063206
background-color: #005a9c;
32073207
border-radius: 0.3125rem;
3208-
content: "";
3209-
height: 100%;
32103208
left: -0.625rem;
3211-
position: absolute;
3212-
top: 0;
32133209
width: 0.625rem;
32143210
}
32153211
.component--quote > * {
32163212
max-width: 39.375rem;
32173213
}
3218-
.component--quote blockquote {
3219-
-webkit-margin-start: 0;
3220-
margin-inline-start: 0;
3221-
padding: 0;
3222-
}
3223-
.component--quote blockquote::before {
3224-
display: none;
3225-
}
32263214

32273215
[dir=rtl] .component--quote::before {
32283216
left: auto;

public/dist/assets/styles/core.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
1-
<figure class="component component--quote">
2-
<blockquote>
3-
<p>
4-
{% block text %}{% endblock %}
5-
</p>
6-
</blockquote>
1+
<blockquote class="component component--quote">
2+
<p>
3+
{% block text %}{% endblock %}
4+
</p>
75
{% if author is defined and author is not empty %}
8-
<figcaption>{{ author }}</figcaption>
6+
<footer>{{ author }}</footer>
97
{% endif %}
10-
</figure>
8+
</blockquote>

0 commit comments

Comments
 (0)