Skip to content

Conversation

JAWS-test2
Copy link
Contributor

Fixes #919

Also:

  • Update and addition of links
  • Remove role=application (no landmark region)
  • Adding role=region
  • Adding the test for meaningful labeling

Base automatically changed from master to main March 5, 2021 20:42
@kfranqueiro kfranqueiro removed the request for review from michael-n-cooper May 5, 2025 13:17
Copy link

netlify bot commented May 5, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit b635c0a
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/68acc387f314740008fdcd35
😎 Deploy Preview https://deploy-preview-1023--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kfranqueiro
Copy link
Contributor

I synced this branch today while looking through old PRs, which required resolving conflicts:

  • In the list of landmarks, I only kept the banner change (which concerns the referenced bug); application had since been removed, navigation had since been changed to something similar to what was in this PR, and region had since been added. I did correct one duplicated word in the navigation item.
  • The modification of one line of the first example was no longer applicable as the example had changed
  • Preserved the addition to the test prodecure, although I wonder if items 3 and 4 could be merged?
  • Preserved the additions under related techniques
  • Preserved the changes to the first 3 resource links; the 4th is already pointing to a newer URL for what was added in this PR, and the 5th was added after this PR

See df64f09e for what was in the original commit of this PR.

@mbgower mbgower self-assigned this May 16, 2025
@bruce-usab
Copy link
Contributor

Discussed on backlog call 5/16. We did not resolve if "each landmark region" was equivalent to "same type of landmark".

Copy link
Contributor

@mbgower mbgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a bit of friction between how "name" is used in this document. There is also inconsistency with how "label" and "accessible name" are used. I am making some suggestions to try to improve.

spelled labeling with only one L not two together (which I think is American usage?)
Changed the first use of "label" to "name" to try to better tie in the idea that one typically provides an accessible name for a region through use of an aria label technique.
@mbgower
Copy link
Contributor

mbgower commented Jul 25, 2025

@mbgower to copy over phrase

@giacomo-petri
Copy link
Contributor

We also need to update lines 49 and 51 in Example 1, as they are not handled as landmarks (missing acc name), even though the title suggests otherwise.

@bruce-usab
Copy link
Contributor

rendered diff

@mbgower
Copy link
Contributor

mbgower commented Aug 25, 2025

Despite the few thumbs up, there seems to be sufficient support in the comments for this update to technique language.

@mbgower mbgower merged commit 54e54b8 into w3c:main Aug 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARIA11 update the banner definition
7 participants