-
Notifications
You must be signed in to change notification settings - Fork 318
Update ARIA11 #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ARIA11 #1023
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I synced this branch today while looking through old PRs, which required resolving conflicts:
See df64f09e for what was in the original commit of this PR. |
Co-authored-by: Scott O'Hara <[email protected]>
…nk text Co-authored-by: Scott O'Hara <[email protected]>
Discussed on backlog call 5/16. We did not resolve if "each landmark region" was equivalent to "same type of landmark". |
Co-authored-by: Kenneth G. Franqueiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a bit of friction between how "name" is used in this document. There is also inconsistency with how "label" and "accessible name" are used. I am making some suggestions to try to improve.
spelled labeling with only one L not two together (which I think is American usage?) Changed the first use of "label" to "name" to try to better tie in the idea that one typically provides an accessible name for a region through use of an aria label technique.
@mbgower to copy over phrase |
We also need to update lines 49 and 51 in Example 1, as they are not handled as landmarks (missing acc name), even though the title suggests otherwise. |
Despite the few thumbs up, there seems to be sufficient support in the comments for this update to technique language. |
Fixes #919
Also:
role=application
(no landmark region)role=region