Fix parsing response's CSP type mismatch #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
added a commit
that referenced
this pull request
Oct 14, 2024
SHA: b33a9a2 Reason: push, by antosart Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ghost
reviewed
Oct 14, 2024
Comment on lines
+539
to
+540
| <a abstract-op lt="parse a serialized CSP list">parsing</a> |token|, with a | ||
| [=policy/source=] of "`header`", and a [=policy/disposition=] of "`enforce`". |
There was a problem hiding this comment.
parse a serialized CSP list was deleted, this does not link to anything anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Parse response’s Content Security Policies" algorithm, which wanted to use the result of extracting header list values, a list of byte sequences, as input for parsing, which takes either a byte sequence or a string.
As it turns out, extracting header list values already takes care of splitting the header value on commas and returning a list (provided that the ABNF grammar of the header specifies so, which the Content-Security-Policy grammar does), so the CSP spec can be further simplified by removing the part handling commas in header values.
This fixes #684.
Preview | Diff