-
Notifications
You must be signed in to change notification settings - Fork 84
Integrate with speculation rules #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The build error appears to be preexisting. |
The build error should be fixed with #777. |
This upstreams the monkeypatches from https://wicg.github.io/nav-speculation/speculation-rules.html#content-security-policy. At a high level, the additions are: - A new directive, `inline-speculation-rules`, which can be used if developers want to block inline JavaScript `<script>`s but allow inline `<script type=speculationrules>`s. This is done by introducing a new script type, `script speculationrules`, to sit alongside the existing `script` and `script attribute` types; HTML passes this new value in. - Handling of the new `"speculationrules"` request destination, which is used by the `Speculation-Rules` HTTP header. It cannot be blocked by CSP.
16bb13b
to
8c2dcb5
Compare
Rebased! |
This is ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, and as it's landed in HTML it should meet the requirements we're starting to pull together for additions to CSP.
I'll wait a bit for @antosart to have any feedback, but I'm comfortable merging this at this point.
Thanks!
This looks good to me, too, but see whatwg/fetch#1841 (comment). Would it make sense to provide more context and link to some reasoning on the decision of gating |
This upstreams the monkeypatches from https://wicg.github.io/nav-speculation/speculation-rules.html#content-security-policy. At a high level, the additions are:
A new directive,
inline-speculation-rules
, which can be used if developers want to block inline JavaScript<script>
s but allow inline<script type=speculationrules>
s. This is done by introducing a new script type,script speculationrules
, to sit alongside the existingscript
andscript attribute
types; HTML passes this new value in.Handling of the new
"speculationrules"
request destination, which is used by theSpeculation-Rules
HTTP header. It cannot be blocked by CSP.This should be merged a bit after whatwg/html#11426. Otherwise it will reference the WICG draft.
Preview | Diff