Skip to content

Commit 10d856a

Browse files
committed
CREDENTIAL: Soften the language in 'Request a credential'.
1 parent af1c343 commit 10d856a

File tree

2 files changed

+10
-21
lines changed

2 files changed

+10
-21
lines changed

specs/credentialmanagement/index.html

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1855,13 +1855,11 @@ <h4 class="heading settled" data-level="4.1.1" id="request-credential"><span cla
18551855
</ol>
18561856

18571857

1858-
<p class="issue" id="issue-a3de5bfb"><a class="self-link" href="#issue-a3de5bfb"></a> How do we deal with a future in which
1859-
<code class="idl"><a data-link-type="idl" href="#originboundcredential">OriginBoundCredential</a></code> isn’t the only type? For example, how could an
1860-
author pull some "RemoteCredential" that required interaction with a
1861-
third-party, but fall back to a <code class="idl"><a data-link-type="idl" href="#passwordcredential">PasswordCredential</a></code>? For the moment, we’re
1862-
resolving this by rejecting the promise if the types listed in
1863-
<code class="idl"><a data-link-type="idl" href="#dom-credentialcontainer-get">get()</a></code>'s <code class="idl"><a class="idl-code" data-link-type="argument" href="#dom-credentialcontainer-get-options-options">options</a></code> aren’t all instances of
1864-
the same type, but that seems like something we’d want to fix. <a href="https://github.com/w3c/webappsec/issues/256">&lt;https://github.com/w3c/webappsec/issues/256></a></p>
1858+
<p class="note" role="note">Note: Currently, we reject a call to <code class="idl"><a data-link-type="idl" href="#dom-credentialcontainer-get">get()</a></code> if the
1859+
<var>options</var> provided specify a set of <code class="idl"><a data-link-type="idl" href="#credential">Credential</a></code> types that don’t
1860+
play well together (e.g. some future "NeedsLotsOfUserInteractionCredential"
1861+
type in the same request as an <code class="idl"><a data-link-type="idl" href="#passwordcredential">PasswordCredential</a></code>). We may wish to define
1862+
a more graceful fallback mechanism if/when new credential types are defined.</p>
18651863

18661864

18671865
<h4 class="heading settled" data-level="4.1.2" id="store-credential"><span class="secno">4.1.2. </span><span class="content">
@@ -3652,13 +3650,6 @@ <h2 class="no-num heading settled" id="issues-index"><span class="content">Issue
36523650
<div class="issue"> This is terribly hand-wavey. The intent is
36533651
clear, but I need to do the work to walk through the list of DOMStrings
36543652
and convert them to interfaces and etc. Busywork for later. <a href="https://github.com/w3c/webappsec/issues/289">&lt;https://github.com/w3c/webappsec/issues/289></a><a href="#issue-6005a2a4"></a></div>
3655-
<div class="issue"> How do we deal with a future in which
3656-
<code class="idl"><a data-link-type="idl" href="#originboundcredential">OriginBoundCredential</a></code> isn’t the only type? For example, how could an
3657-
author pull some "RemoteCredential" that required interaction with a
3658-
third-party, but fall back to a <code class="idl"><a data-link-type="idl" href="#passwordcredential">PasswordCredential</a></code>? For the moment, we’re
3659-
resolving this by rejecting the promise if the types listed in
3660-
<code class="idl"><a data-link-type="idl" href="#dom-credentialcontainer-get">get()</a></code>'s <code class="idl"><a class="idl-code" data-link-type="argument" href="#dom-credentialcontainer-get-options-options">options</a></code> aren’t all instances of
3661-
the same type, but that seems like something we’d want to fix. <a href="https://github.com/w3c/webappsec/issues/256">&lt;https://github.com/w3c/webappsec/issues/256></a><a href="#issue-a3de5bfb"></a></div>
36623653
<div class="issue"> Add some thoughts here about when and how the API
36633654
should be used, especially with regard to <code class="idl"><a data-link-type="idl" href="#dom-credentialrequestoptions-suppressui">suppressUI</a></code>. <a href="https://github.com/w3c/webappsec/issues/290">&lt;https://github.com/w3c/webappsec/issues/290></a><a href="#issue-e1d9f1af"></a></div>
36643655
<div class="issue">

specs/credentialmanagement/index.src.html

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1167,13 +1167,11 @@ <h4 id="request-credential">
11671167
</li>
11681168
</ol>
11691169

1170-
ISSUE(w3c/webappsec#256): How do we deal with a future in which
1171-
{{OriginBoundCredential}} isn't the only type? For example, how could an
1172-
author pull some "RemoteCredential" that required interaction with a
1173-
third-party, but fall back to a {{PasswordCredential}}? For the moment, we're
1174-
resolving this by rejecting the promise if the types listed in
1175-
{{CredentialContainer/get()}}'s {{options!!argument}} aren't all instances of
1176-
the same type, but that seems like something we'd want to fix.
1170+
Note: Currently, we reject a call to {{CredentialContainer/get()}} if the
1171+
<var>options</var> provided specify a set of {{Credential}} types that don't
1172+
play well together (e.g. some future "NeedsLotsOfUserInteractionCredential"
1173+
type in the same request as an {{PasswordCredential}}). We may wish to define
1174+
a more graceful fallback mechanism if/when new credential types are defined.
11771175

11781176
<h4 id="store-credential">
11791177
Store a <code>Credential</code>

0 commit comments

Comments
 (0)