CREDENTIAL: 'toFormData' should be synchronous.

Author: mikewest

specs/credentialmanagement/index.html

@@ -961,7 +961,7 @@ <h4 class="heading settled" data-level="3.1.3" id="interfaces-credential-types-p
 
 [<dfn class="idl-code" data-dfn-for="PasswordCredential" data-dfn-type="constructor" data-export="" data-lt="PasswordCredential(data)" id="dom-passwordcredential-passwordcredential">Constructor<a class="self-link" href="#dom-passwordcredential-passwordcredential"></a></dfn>(<a data-link-type="idl-name" href="#dictdef-passwordcredentialdata">PasswordCredentialData</a> <dfn class="idl-code" data-dfn-for="PasswordCredential/PasswordCredential(data)" data-dfn-type="argument" data-export="" id="dom-passwordcredential-passwordcredential-data-data">data<a class="self-link" href="#dom-passwordcredential-passwordcredential-data-data"></a></dfn>), Exposed=Window]
 interface <dfn class="idl-code" data-dfn-type="interface" data-export="" id="passwordcredential">PasswordCredential<a class="self-link" href="#passwordcredential"></a></dfn> : <a data-link-type="idl-name" href="#locallystoredcredential">LocallyStoredCredential</a> {
-  Promise&lt;<a data-link-type="idl-name" href="https://xhr.spec.whatwg.org/#interface-formdata">FormData</a>> <a class="idl-code" data-link-type="method" href="#dom-passwordcredential-toformdata">toFormData</a>(<a data-link-type="idl-name" href="#dictdef-formdataoptions">FormDataOptions</a> <a class="idl-code" data-link-type="argument" href="#dom-passwordcredential-toformdata-formdataoptions-formdataoptions">formDataOptions</a>);
+  <a data-link-type="idl-name" href="https://xhr.spec.whatwg.org/#interface-formdata">FormData</a> <a class="idl-code" data-link-type="method" href="#dom-passwordcredential-toformdata">toFormData</a>(<a data-link-type="idl-name" href="#dictdef-formdataoptions">FormDataOptions</a> <a class="idl-code" data-link-type="argument" href="#dom-passwordcredential-toformdata-formdataoptions-formdataoptions">formDataOptions</a>);
 };
 </pre>
 
@@ -2418,9 +2418,8 @@ <h4 class="heading settled" data-level="4.3.1" id="generate-formdata"><span clas
 
 
      <li>
-      Return a promise rejected with a <code>SecurityError</code>
-      <strong>and</strong> terminate this algorithm if any of the following
-      conditions are true:
+      Return a new <code class="idl"><a data-link-type="idl" href="https://xhr.spec.whatwg.org/#interface-formdata">FormData</a></code> object <strong>and</strong> terminate this
+      algorithm if any of the following conditions are true:
 
 
       <ol>
@@ -2441,16 +2440,6 @@ <h4 class="heading settled" data-level="4.3.1" id="generate-formdata"><span clas
 
 
 
-     <li>
-      Let <var>promise</var> be a newly created <code>Promise</code> object.
-    
-     
-    
-     <li>
-      Return <var>promise</var>, and execute the remaining steps asynchronously.
-    
-     
-    
      <li>
       Let <var>fd</var> be a new <code class="idl"><a data-link-type="idl" href="https://xhr.spec.whatwg.org/#interface-formdata">FormData</a></code> object.
 
@@ -2477,7 +2466,7 @@ <h4 class="heading settled" data-level="4.3.1" id="generate-formdata"><span clas
 
 
      <li>
-      Resolve <var>promise</var> with <var>fd</var>.
+      Resolve <var>fd</var>.
 
 
 
@@ -3606,7 +3595,7 @@ <h2 class="no-num heading settled" id="idl-index"><span class="content">IDL Inde
 
 [<a href="#dom-passwordcredential-passwordcredential">Constructor</a>(<a data-link-type="idl-name" href="#dictdef-passwordcredentialdata">PasswordCredentialData</a> <a href="#dom-passwordcredential-passwordcredential-data-data">data</a>), Exposed=Window]
 interface <a href="#passwordcredential">PasswordCredential</a> : <a data-link-type="idl-name" href="#locallystoredcredential">LocallyStoredCredential</a> {
-  Promise&lt;<a data-link-type="idl-name" href="https://xhr.spec.whatwg.org/#interface-formdata">FormData</a>> <a class="idl-code" data-link-type="method" href="#dom-passwordcredential-toformdata">toFormData</a>(<a data-link-type="idl-name" href="#dictdef-formdataoptions">FormDataOptions</a> <a class="idl-code" data-link-type="argument" href="#dom-passwordcredential-toformdata-formdataoptions-formdataoptions">formDataOptions</a>);
+  <a data-link-type="idl-name" href="https://xhr.spec.whatwg.org/#interface-formdata">FormData</a> <a class="idl-code" data-link-type="method" href="#dom-passwordcredential-toformdata">toFormData</a>(<a data-link-type="idl-name" href="#dictdef-formdataoptions">FormDataOptions</a> <a class="idl-code" data-link-type="argument" href="#dom-passwordcredential-toformdata-formdataoptions-formdataoptions">formDataOptions</a>);
 };
 
 dictionary <a href="#dictdef-federatedcredentialdata">FederatedCredentialData</a> : <a data-link-type="idl-name" href="#dictdef-locallystoredcredentialdata">LocallyStoredCredentialData</a> {

specs/credentialmanagement/index.src.html

@@ -609,7 +609,7 @@ <h4 id="interfaces-credential-types-passwordcredential"><code>PasswordCredential
 
     [Constructor(PasswordCredentialData data), Exposed=Window]
     interface PasswordCredential : LocallyStoredCredential {
-      Promise&lt;FormData&gt; toFormData(FormDataOptions formDataOptions);
+      FormData toFormData(FormDataOptions formDataOptions);
     };
   </pre>
   <dl dfn-for="PasswordCredential">
@@ -1540,9 +1540,8 @@ <h4 id="generate-formdata">
       Let <var>environment</var> be the <a>incumbent settings object</a>.
     </li>
     <li>
-      Return a promise rejected with a <code>SecurityError</code>
-      <strong>and</strong> terminate this algorithm if any of the following
-      conditions are true:
+      Return a new {{FormData}} object <strong>and</strong> terminate this
+      algorithm if any of the following conditions are true:
 
       <ol>
         <li>
@@ -1554,12 +1553,6 @@ <h4 id="generate-formdata">
         </li>
       </ol>
     </li>
-    <li>
-      Let <var>promise</var> be a newly created <code>Promise</code> object.
-    </li>
-    <li>
-      Return <var>promise</var>, and execute the remaining steps asynchronously.
-    </li>
     <li>
       Let <var>fd</var> be a new {{FormData}} object.
     </li>
@@ -1578,7 +1571,7 @@ <h4 id="generate-formdata">
       {{PasswordCredential/[[password]]}}.
     </li>
     <li>
-      Resolve <var>promise</var> with <var>fd</var>.
+      Resolve <var>fd</var>.
     </li>
   </ol>