Enable checkJs (#648)

* Add more ts-checks

* cover extattrs

* cover more

* Enable checkJs

* Add .js to import()

* TODO:

Author: saschanaz

.gitignore

@@ -1,3 +1,4 @@
 node_modules/
 dist/*
 !dist/package.json
+.vscode/

jsconfig.json

@@ -2,7 +2,8 @@
   "compilerOptions": {
     "target": "es2020",
     "module": "es2020",
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "checkJs": true
   },
   "include": [
     "lib/"

lib/error.js

@@ -28,12 +28,16 @@ function contextAsText(node) {
  * @typedef {object} WebIDL2ErrorOptions
  * @property {"error" | "warning"} [level]
  * @property {Function} [autofix]
+ * @property {string} [ruleName]
  *
  * @typedef {ReturnType<typeof error>} WebIDLErrorData
  *
  * @param {string} message error message
+ * @param {*} position
+ * @param {*} current
+ * @param {*} message
  * @param {"Syntax" | "Validation"} kind error type
- * @param {WebIDL2ErrorOptions} [options]
+ * @param {WebIDL2ErrorOptions=} options
  */
 function error(
   source,
@@ -52,6 +56,12 @@ function error(
       : source.slice(Math.max(position + count, 0), position);
   }
 
+  /**
+   * @param {import("./tokeniser.js").Token[]} inputs
+   * @param {object} [options]
+   * @param {boolean} [options.precedes]
+   * @returns
+   */
   function tokensToText(inputs, { precedes } = {}) {
     const text = inputs.map((t) => t.trivia + t.value).join("");
     const nextToken = source[position];

lib/productions/argument.js

@@ -1,5 +1,3 @@
-// @ts-check
-
 import { Base } from "./base.js";
 import { Default } from "./default.js";
 import { ExtendedAttributes } from "./extended-attributes.js";
@@ -18,7 +16,7 @@ import {
 
 export class Argument extends Base {
   /**
-   * @param {import("../tokeniser").Tokeniser} tokeniser
+   * @param {import("../tokeniser.js").Tokeniser} tokeniser
    */
   static parse(tokeniser) {
     const start_position = tokeniser.position;

lib/productions/array-base.js

@@ -1,5 +1,3 @@
-// @ts-check
-
 export class ArrayBase extends Array {
   constructor({ source, tokens }) {
     super();

lib/productions/attribute.js

@@ -1,5 +1,3 @@
-// @ts-check
-
 import { validationError } from "../error.js";
 import { idlTypeIncludesDictionary } from "../validators/helpers.js";
 import { Base } from "./base.js";

lib/productions/base.js

@@ -1,5 +1,3 @@
-// @ts-check
-
 export class Base {
   /**
    * @param {object} initializer

lib/productions/callback-interface.js

@@ -1,12 +1,10 @@
-// @ts-check
-
 import { Container } from "./container.js";
 import { Operation } from "./operation.js";
 import { Constant } from "./constant.js";
 
 export class CallbackInterface extends Container {
   /**
-   * @param {import("../tokeniser").Tokeniser} tokeniser
+   * @param {import("../tokeniser.js").Tokeniser} tokeniser
    */
   static parse(tokeniser, callback, { partial = null } = {}) {
     const tokens = { callback };

lib/productions/constructor.js

@@ -3,7 +3,7 @@ import { argument_list, autoParenter } from "./helpers.js";
 
 export class Constructor extends Base {
   /**
-   * @param {import("../tokeniser").Tokeniser} tokeniser
+   * @param {import("../tokeniser.js").Tokeniser} tokeniser
    */
   static parse(tokeniser) {
     const base = tokeniser.consume("constructor");
@@ -31,9 +31,6 @@ export class Constructor extends Base {
   }
 
   *validate(defs) {
-    if (this.idlType) {
-      yield* this.idlType.validate(defs);
-    }
     for (const argument of this.arguments) {
       yield* argument.validate(defs);
     }

lib/productions/container.js

@@ -18,9 +18,8 @@ function inheritance(tokeniser) {
 
 export class Container extends Base {
   /**
-   * @template T
    * @param {import("../tokeniser.js").Tokeniser} tokeniser
-   * @param {T} instance
+   * @param {*} instance TODO: This should be {T extends Container}, but see https://github.com/microsoft/TypeScript/issues/4628
    * @param {*} args
    */
   static parse(tokeniser, instance, { inheritable, allowedMembers }) {