Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 15, 2024

⚠ NEVER add commits to this pull request.

πŸ€– This pull request was automatically created to facilitate human review of @webref/events changes triggered by curated data at 2c7c32d.

🧐 Please review the diff below and version numbers. If all looks good, merge this pull request to release the changes to npm.

πŸ“¦ Latest released @webref/events package was v1.15.0. Merging this pull request will release v1.16.0. Make sure that the bump is the right one for the changes.

✍ If any change needs to be made before release, do not add a commit to this pull request. Changes should rather be handled in a separate pull request and pushed to the main branch. You may leave this pull request open in the meantime, or close it. The pre-release job will automatically update this pull request or create a new one once the updates have made their way to the main branch.

πŸ›ˆ The actual change introduced by this pull request is a version bump in packages/events/package.json. You do not need to review that change. The bumped version is not the version that will be released when this pull request is merged, but rather the version that will be released next time.

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--exclude=CHANGELOG.md' '--unified=3' webref/node_modules/@webref/events/events.json packages/events/events.json
--- webref/node_modules/@webref/events/events.json
+++ packages/events/events.json
@@ -2679,20 +2679,6 @@
     "interface": "ErrorEvent"
   },
   {
-    "src": {
-      "format": "fire an event phrasing",
-      "href": "https://webaudio.github.io/web-audio-api/#ref-for-concept-event-fire"
-    },
-    "href": "https://webaudio.github.io/web-audio-api/#eventdef-audiocontext-error",
-    "type": "error",
-    "targets": [
-      {
-        "target": "AudioContext"
-      }
-    ],
-    "interface": "ErrorEvent"
-  },
-  {
     "href": "https://html.spec.whatwg.org/multipage/indices.html#event-error",
     "src": {
       "format": "summary table",
@@ -2847,6 +2833,20 @@
     "interface": "Event"
   },
   {
+    "src": {
+      "format": "fire an event phrasing",
+      "href": "https://webaudio.github.io/web-audio-api/#ref-for-concept-event-fire"
+    },
+    "href": "https://webaudio.github.io/web-audio-api/#eventdef-audiocontext-error",
+    "type": "error",
+    "targets": [
+      {
+        "target": "AudioContext"
+      }
+    ],
+    "interface": "Event"
+  },
+  {
     "src": {
       "format": "fire an event phrasing",
       "href": "https://websockets.spec.whatwg.org/#ref-for-concept-event-fire%E2%91%A1"

@github-actions github-actions bot force-pushed the release-events-20241115161310959 branch 13 times, most recently from 781b9eb to 50a1df5 Compare November 18, 2024 18:45
@github-actions github-actions bot force-pushed the release-events-20241115161310959 branch from 50a1df5 to 87591b4 Compare November 20, 2024 12:39
@tidoust
Copy link
Member

tidoust commented Nov 20, 2024

Fix is correct, the "error" event now uses the Event interface

@tidoust tidoust merged commit 550927e into main Nov 20, 2024
@tidoust tidoust deleted the release-events-20241115161310959 branch November 20, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants