Skip to content

Commit 8ae6738

Browse files
committed
address comments
1 parent ae86de4 commit 8ae6738

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

index.bs

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@ spec:webidl; type:dfn; text:resolve
4444
"href": "https://www.itu.int/rec/T-REC-G.722/",
4545
"title": "G.722 : 7 kHz audio-coding within 64 kbit/s",
4646
"publisher": "ITU"
47+
},
48+
"CloneArrayBuffer": {
49+
"href": "https://tc39.es/ecma262/#sec-clonearraybuffer",
50+
"title": "CloneArrayBuffer"
4751
}
4852
}
4953
</pre>
@@ -449,10 +453,11 @@ interface RTCEncodedVideoFrame {
449453
When called, run the following steps:
450454

451455
1. Set this.`[[type]]` to |originalFrame|.`[[type]]`.
452-
1. Let this.`[[data]]` be the result of <a href="https://tc39.es/ecma262/#sec-clonearraybuffer">CloneArrayBuffer</a>(|originalFrame|.`[[data]]`, 0, |originalFrame|.`[[data]]`.`[[ArrayBufferByteLength]]`).
456+
1. Let this.`[[data]]` be the result of [[CloneArrayBuffer]](|originalFrame|.`[[data]]`, 0, |originalFrame|.`[[data]]`.`[[ArrayBufferByteLength]]`).
453457
1. Let `[[metadata]]` represent the metadata associated with this newly constructed frame.
454458
1. For each {`[[key]]`,`[[value]]`} pair of |originalFrame|.`[[getMetadata()]]`, set `[[metadata]]`.`[[key]]` to `[[value]]`.
455-
1. For each {`[[key]]`,`[[value]]`} pair of |options|`[metadata]`, if the `[[value]]` exists, set `[[metadata]]`.`[[key]]` to `[[value]]`.
459+
1. For each {`[[key]]`,`[[value]]`} pair of |options|`[metadata]`, if `[[value]]` is not <code>undefined</code>, set `[[metadata]]`.`[[key]]` to `[[value]]`.
460+
<p class="note">This does a "deep-copy" here.</p>
456461

457462
</p>
458463
</dd>
@@ -673,10 +678,11 @@ interface RTCEncodedAudioFrame {
673678

674679
When called, run the following steps:
675680

676-
1. Let this.`[[data]]` be the result of <a href="https://tc39.es/ecma262/#sec-clonearraybuffer">CloneArrayBuffer</a>(|originalFrame|.`[[data]]`, 0, |originalFrame|.`[[data]]`.`[[ArrayBufferByteLength]]`).
681+
1. Let this.`[[data]]` be the result of [[CloneArrayBuffer]](|originalFrame|.`[[data]]`, 0, |originalFrame|.`[[data]]`.`[[ArrayBufferByteLength]]`).
677682
1. Let `[[metadata]]` represent the metadata associated with this newly constructed frame.
678683
1. For each {`[[key]]`,`[[value]]`} pair of |originalFrame|.`[[getMetadata()]]`, set `[[metadata]]`.`[[key]]` to `[[value]]`.
679-
1. For each {`[[key]]`,`[[value]]`} pair of |options|`[metadata]`, if the `[[value]]` exists, set `[[metadata]]`.`[[key]]` to `[[value]]`.
684+
1. For each {`[[key]]`,`[[value]]`} pair of |options|`[metadata]`, if `[[value]]` is not <code>undefined</code>, set `[[metadata]]`.`[[key]]` to `[[value]]`.
685+
<p class="note">This does a "deep-copy" here.</p>
680686

681687
</p>
682688
</dd>

0 commit comments

Comments
 (0)