Skip to content

Commit a87eeb2

Browse files
committed
Review comments
1 parent d5f6808 commit a87eeb2

File tree

1 file changed

+9
-16
lines changed

1 file changed

+9
-16
lines changed

index.bs

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -590,14 +590,8 @@ partial interface DedicatedWorkerGlobalScope {
590590
attribute EventHandler onrtctransform;
591591
};
592592

593-
interface mixin RTCRtpScriptSource {
594-
};
595-
596-
interface mixin RTCRtpScriptSink {
597-
};
598-
599593
[Exposed=DedicatedWorker]
600-
interface RTCRtpScriptTransformer {
594+
interface RTCRtpScriptTransformer : EventTarget {
601595
// Attributes and methods related to the transformer source
602596
readonly attribute ReadableStream readable;
603597
Promise<unsigned long long> generateKeyFrame(optional DOMString rid);
@@ -683,22 +677,21 @@ The <dfn attribute for="RTCRtpScriptTransform">onkeyframerequest</dfn> EventHand
683677

684678
## Events ## {#RTCRtpScriptTransformer-events}
685679

686-
The following events fire on an {{RTCRtpScriptTransformer}}:
680+
The following event fires on an {{RTCRtpScriptTransformer}}:
687681

688682
* keyframerequest of type {{KeyFrameRequestEvent}} - fired when the sink determines that a key frame has been requested.
689683

690684
The steps that generate an event of type {{KeyFrameRequestEvent}} are as follows:
691685

692-
Given a {{RTCRtpScriptTransformer}} `transform`:
686+
Given a {{RTCRtpScriptTransformer}} |transform|:
693687

694-
When `transform`'s `[[encoder]]` receives a keyframe request, for instance from an incoming RTCP Picture Loss Indication (PLI)
695-
or Full Intra Refresh (FIR), queue
696-
a task to perform the following steps:
688+
When |transform|'s `[[encoder]]` receives a keyframe request, for instance from an incoming RTCP Picture Loss Indication (PLI)
689+
or Full Intra Refresh (FIR), queue a task to perform the following steps:
697690

698-
1. Set `rid` to the RID of the appropriate layer, or undefined if the request is not for a specific layer.
699-
1. Fire a cancelable event of type {{KeyFrameRequestEvent}} on `transform`, with {{KeyFrameRequestEvent/rid}} set to `rid`.
700-
1. If the event is cancelled, abort these steps.
701-
1. Run the [$generate key frame algorithm$] with a new promise, `transform`.`[[encoder]]` and `rid`.
691+
1. Set |rid| to the RID of the appropriate layer, or undefined if the request is not for a specific layer.
692+
1. [=Fire an event=] named `keyframerequest` at |transform| using {{KeyFrameRequestEvent}} with its {{Event/cancelable}} attribute initialized to "true", and with {{KeyFrameRequestEvent/rid}} set to |rid|.
693+
1. If the event's `canceled flag` is true, abort these steps.
694+
1. Run the [$generate key frame algorithm$] with a new promise, |transform|.`[[encoder]]` and |rid|.
702695

703696
## KeyFrame Algorithms ## {#KeyFrame-algorithms}
704697

0 commit comments

Comments
 (0)