Further style improvements and make sure to create pipeToController before using it

Author: youennf

index.bs

@@ -134,6 +134,7 @@ SFrameTransform includes GenericTransformStream;
 [Exposed=(Window)]
 interface RTCRtpScriptTransform {
     constructor(Worker worker, optional object options);
+    // FIXME: add messaging methods.
 };
 
 typedef (SFrameTransform or RTCRtpScriptTransform) RTCRtpTransform;
@@ -160,31 +161,31 @@ argument, ensure that the codec is disabled and produces no output.
 ### Stream creation ### {#stream-creation}
 
 At construction of each {{RTCRtpSender}} or {{RTCRtpReceiver}}, run the following steps:
-1. Initialize `[[Streams]]` to null.
-2. Initialize `[[transform]]` to null.
-3. Initialize `[[readable]]` to the result of <a dfn for="ReadableStream">creating</a> a {{ReadableStream}}. `[[readable]]` is provided frames using the [=readEncodedData=] algorithm given |this| as parameter.
-4. Set `[[readable]]`.`[[owner]]` to |this|.
-5. Initialize `[[writable]]` to the result of [=WritableStream/creating=] a {{WritableStream}}, its [=WritableStream/create/writeAlgorithm=] set to [=writeEncodedData=] given |this| as parameter.
-6. Set `[[writable]]`.`[[owner]]` to |this|.
-7. Initialize `[[pipeToController]]` to null.
-8. Initialize `[[lastReceivedFrameTimestamp]]` to zero.
+1. Initialize [=this=].`[[Streams]]` to null.
+2. Initialize [=this=].`[[transform]]` to null.
+3. Initialize [=this=].`[[readable]]` to the result of <a dfn for="ReadableStream">creating</a> a {{ReadableStream}}. `[[readable]]` is provided frames using the [=readEncodedData=] algorithm given |this| as parameter.
+4. Set [=this=].`[[readable]]`.`[[owner]]` to |this|.
+5. Initialize [=this=].`[[writable]]` to the result of [=WritableStream/creating=] a {{WritableStream}}, its [=WritableStream/create/writeAlgorithm=] set to [=writeEncodedData=] given |this| as parameter.
+6. Set [=this=].`[[writable]]`.`[[owner]]` to |this|.
+7. Initialize [=this=].`[[pipeToController]]` to null.
+8. Initialize [=this=].`[[lastReceivedFrameTimestamp]]` to zero.
 9. If the {{RTCPeerConnection}}'s configuration does not have {{RTCConfiguration/encodedInsertableStreams}} set to "true", queue a task to run the following steps:
-    1. If `[[pipeToController]]` is not null, abort these steps.
-    2. Call <a href="https://streams.spec.whatwg.org/#readable-stream-pipe-to">pipeTo</a> with `[[readable]]`, `[[writable]]`, preventClose equal to true, preventAbort equal to true, preventCancel equal to true and `[[pipeToController]]`.signal.
+    1. If [=this=].`[[pipeToController]]` is not null, abort these steps.
+    2. Set [=this=].`[[pipeToController]]` to a new {{AbortController}}.
+    3. Call <a href="https://streams.spec.whatwg.org/#readable-stream-pipe-to">pipeTo</a> with [=this=].`[[readable]]`, [=this=].`[[writable]]`, preventClose equal to true, preventAbort equal to true, preventCancel equal to true and [=this=].`[[pipeToController]]`.signal.
 
 When {{RTCRtpSender/createEncodedStreams}}() is
 called, run the following steps:
 
-1. If the {{RTCPeerConnection}}'s configuration does not have {{RTCConfiguration/encodedInsertableStreams}} set to "true", throw an {{InvalidStateError}} and abort these steps.
+1. If the {{RTCPeerConnection}}'s configuration does not have {{RTCConfiguration/encodedInsertableStreams}} set to "true", throw an "{{InvalidAccessError}}" {{DOMException}} and abort these steps.
 2. If the data source does not permit access, throw an "{{InvalidAccessError}}" {{DOMException}} and abort these steps.
-3. If `[[Streams]]` is not null, throw an {{InvalidStateError}}.
-4. If `[[pipeToController]]` is not null, throw an {{InvalidStateError}}.
-5. Create an {{RTCInsertableStreams}} object |s|.
-6. Set |s|.{{RTCInsertableStreams/readable}} to `[[readable]]`.
-7. Set |s|.{{RTCInsertableStreams/writable}} to `[[writable]]`.
+3. If [=this=].`[[Streams]]` is not null, throw an "{{InvalidAccessError}}" {{DOMException}}.
+4. If [=this=].`[[pipeToController]]` is not null, throw an "{{InvalidAccessError}}" {{DOMException}}.
+5. Set [=this=].`[[Streams]]` to an {{RTCInsertableStreams}} object.
+6. Set [=this=].`[[Streams]]`.{{RTCInsertableStreams/readable}} to [=this=].`[[readable]]`.
+7. Set [=this=].`[[Streams]]`.{{RTCInsertableStreams/writable}} to [=this=].`[[writable]]`.
 8. Enable the encoded data source.
-9. Store |s| in the internal slot `[[Streams]]`.
-10. Return |s|
+10. Return [=this=].`[[Streams]]`.
 
 ### Stream processing ### {#stream-processing}
 
@@ -213,20 +214,20 @@ On getting the transform attribute, the user agent MUST run the following steps:
 On setting the transform attribute, the user agent MUST run the following steps:
 1. Let |rtcObject| be the {{RTCRtpReceiver}} or {{RTCRtpSender}} on which the setter is invoked.
 2. Let |transform| be the argument to the setter.
-3. Let |checkedTransform| set to |transform| if it is not null or to an <a href="https://streams.spec.whatwg.org/#identity-transform-stream">identity transform</a> otherwise.
-3. Let |reader| be the result of <a href="https://streams.spec.whatwg.org/#readablestream-get-a-reader">getting a reader</a> for |checkedTransform|.`[[readable]]`.
-4. Let |writer| be the result of <a href="https://streams.spec.whatwg.org/#writablestream-get-a-writer">getting a writer</a> for |checkedTransform|.`[[writable]]`.
-5. Initialize |newPipeToController| to a new AbortController.
+3. Let |checkedTransform| set to |transform| if it is not null or to an [=identity transform stream=] otherwise.
+3. Let |reader| be the result of [=ReadableStream/getting a reader=] for |checkedTransform|.`[[readable]]`.
+4. Let |writer| be the result of [=WritableStream/getting a writer=] for |checkedTransform|.`[[writable]]`.
+5. Initialize |newPipeToController| to a new {{AbortController}}.
 6. If |rtcObject|.`[[pipeToController]]` is not null, run the following steps:
-    1. <a href="https://dom.spec.whatwg.org/#abortsignal-add">Add</a> the [=chain transform algorithm=] to |rtcObject|.`[[pipeToController]]`:
-    2. Call <a href="https://dom.spec.whatwg.org/#abortsignal-signal-abort">abort</a> on |rtcObject|.`[[pipeToController]]`.
+    1. [=AbortSignal/Add=] the [=chain transform algorithm=] to |rtcObject|.`[[pipeToController]]`:
+    2. [=AbortSignal/signal abort=] |rtcObject|.`[[pipeToController]]`.
 7. Else, run the [=chain transform algorithm=] steps.
 8. Set |rtcObject|.`[[pipeToController]]` to |newPipeToController|.
 9. Set |rtcObject|.`[[transform]]` to |transform|.
 
 The <dfn>chain transform algorithm</dfn> steps are defined as:
-1. If |newPipeToController| <a href="https://dom.spec.whatwg.org/#abortsignal-aborted-flag">aborted flag</a> is true, abort these steps.
-2. Call <a href="https://streams.spec.whatwg.org/#readablestreamdefaultreader-release">release</a> with |reader|.
+1. If |newPipeToController|'s [=AbortSignal/aborted flag=] is true, abort these steps.
+2. [=ReadableStreamDefaultReader/Release=] |reader|.
 3. [=WritableStreamDefaultWriter/Release=] |writer|.
 4. Assert that |newPipeToController| is the same object as |rtcObject|.`[[pipeToController]]`.
 5. Call <a href="https://streams.spec.whatwg.org/#readable-stream-pipe-to">pipeTo</a> with |rtcObject|.`[[readable]]`, |checkedTransform|.`[[writable]]`, preventClose equal to false, preventAbort equal to false, preventCancel equal to true and |newPipeToController|.signal.
@@ -242,11 +243,11 @@ Similarly, if a web application sets the transform synchronously at creation of
 
 The <dfn constructor for="SFrameTransform" lt="SFrameTransform(options)"><code>new SFrameTransform(<var>options</var>)</code></dfn> constructor steps are:
 1. Let |transformAlgorithm| be an algorithm which takes a |frame| as input and runs the <a href="#sframe-transform-algorithm">SFrame transform algorithm</a> with |this| and |frame|.
-2. Set |this|.<a href="https://streams.spec.whatwg.org/#generictransformstream-transform">`[[transform]]`</a> to the result of [=TransformStream/creating=] a {{TransformStream}}, with [=TransformStream/create/transformAlgorithm=] set to |transformAlgorithm|.
+2. Set |this|.`[[transform]]` to the result of [=TransformStream/creating=] a {{TransformStream}}, with [=TransformStream/create/transformAlgorithm=] set to |transformAlgorithm|.
 3. Let |options| be the method's first argument.
 4. Set |this|.`[[role]]` to |options|["{{SFrameTransportOptions/role}}"].
-5. Set |this|.`[[readable]]` to |this|.<a href="https://streams.spec.whatwg.org/#generictransformstream-transform">`[[transform]]`</a>.`[[readable]]`.
-6. Set |this|.`[[writable]]` to |this|.<a href="https://streams.spec.whatwg.org/#generictransformstream-transform">`[[transform]]`</a>.`[[writable]]`.
+5. Set |this|.`[[readable]]` to |this|.`[[transform]]`.`[[readable]]`.
+6. Set |this|.`[[writable]]` to |this|.`[[transform]]`.`[[writable]]`.
 
 ## SFrame transform algorithm ## {#sframe-transform-algorithm}
 
@@ -263,16 +264,17 @@ The SFrame transform algorithm, given |sframe| as a SFrameTransform object and |
 10. If |frame| is an ArrayBuffer, set |frame| to |buffer|.
 11. If |frame| is an {{RTCEncodedAudioFrame}}, set |frame|.{{RTCEncodedAudioFrame/data}} to |buffer|.
 12. If |frame| is an {{RTCEncodedVideoFrame}}, set |frame|.{{RTCEncodedVideoFrame/data}} to |buffer|.
-13. <a href="https://streams.spec.whatwg.org/#transformstream-enqueue">Enqueue</a> |frame| in |sframe|.`[[transform]]`.
+13. [=ReadableStream/Enqueue=] |frame| in |sframe|.`[[transform]]`.
 
 # RTCRtpScriptTransform # {#scriptTransform}
 
 The <dfn constructor for="RTCRtpScriptTransform" lt="RTCRtpScriptTransform(worker, options)"><code>new RTCRtpScriptTransform(<var>worker</var>, <var>options</var>)</code></dfn> constructor steps are:
-1. Create two <a href="https://streams.spec.whatwg.org/#identity-transform-stream">identity transforms</a> named |t1| and |t2|.
-2. Set |this|.`[[writable]]` to |t1|.`[[writable]]`.
-3. Set |this|.`[[readable]]` to |t2|.`[[readable]]`.
-4. FIXME: transfer |t1|.`[[readable]]` and |t2|.`[[writable]]` to the dedicated worker.
-5. FIXME: Create counterpart of |this| in dedicated worker, for instance expose transfered |t1|.`[[readable]]` and |t2|.`[[writable]]`.
+1. Set |t1| to an [=identity transform stream=].
+2. Set |t2| to an [=identity transform stream=].
+3. Set |this|.`[[writable]]` to |t1|.`[[writable]]`.
+4. Set |this|.`[[readable]]` to |t2|.`[[readable]]`.
+5. FIXME: transfer |t1|.`[[readable]]` and |t2|.`[[writable]]` to the dedicated worker.
+6. FIXME: Create counterpart of |this| in dedicated worker, for instance expose transfered |t1|.`[[readable]]` and |t2|.`[[writable]]`.
 
 # Privacy and security considerations # {#privacy}