Remove unused code

Author: w3stling

src/main/java/com/apptasticsoftware/rssreader/internal/FeedItemImpl.java

@@ -10,8 +10,6 @@
 import com.apptasticsoftware.rssreader.module.podcast.internal.PodcastItemDataImpl;
 import com.apptasticsoftware.rssreader.module.psc.PscItemData;
 import com.apptasticsoftware.rssreader.module.psc.internal.PscItemDataImpl;
-import com.apptasticsoftware.rssreader.module.spotify.SpotifyItemData;
-import com.apptasticsoftware.rssreader.module.spotify.internal.SpotifyItemDataImpl;
 import com.apptasticsoftware.rssreader.module.youtube.YoutubeItemData;
 import com.apptasticsoftware.rssreader.module.youtube.internal.YoutubeItemDataImpl;
 
@@ -22,7 +20,6 @@ public class FeedItemImpl extends ItemImpl implements FeedItem {
     private final MediaRssItemData mediaRssItemData = new MediaRssItemDataImpl();
     private final PodcastItemData podcastItemData;
     private final PscItemData pscItemData = new PscItemDataImpl();
-    private final SpotifyItemData spotifyItemData = new SpotifyItemDataImpl();
     private final YoutubeItemData youtubeItemData = new YoutubeItemDataImpl();
 
     /**
@@ -55,11 +52,6 @@ public PscItemData getPscItemData() {
         return pscItemData;
     }
 
-    @Override
-    public SpotifyItemData getSpotifyItemData() {
-        return spotifyItemData;
-    }
-
     @Override
     public YoutubeItemData getYoutubeItemData() {
         return youtubeItemData;
@@ -70,11 +62,11 @@ public boolean equals(Object o) {
         if (!(o instanceof FeedItemImpl)) return false;
         if (!super.equals(o)) return false;
         FeedItemImpl feedItem = (FeedItemImpl) o;
-        return Objects.equals(getItunesItemData(), feedItem.getItunesItemData()) && Objects.equals(getMediaRssItemData(), feedItem.getMediaRssItemData()) && Objects.equals(getPodcastItemData(), feedItem.getPodcastItemData()) && Objects.equals(getPscItemData(), feedItem.getPscItemData()) && Objects.equals(getSpotifyItemData(), feedItem.getSpotifyItemData()) && Objects.equals(getYoutubeItemData(), feedItem.getYoutubeItemData());
+        return Objects.equals(getItunesItemData(), feedItem.getItunesItemData()) && Objects.equals(getMediaRssItemData(), feedItem.getMediaRssItemData()) && Objects.equals(getPodcastItemData(), feedItem.getPodcastItemData()) && Objects.equals(getPscItemData(), feedItem.getPscItemData()) && Objects.equals(getYoutubeItemData(), feedItem.getYoutubeItemData());
     }
 
     @Override
     public int hashCode() {
-        return Objects.hash(super.hashCode(), getItunesItemData(), getMediaRssItemData(), getPodcastItemData(), getPscItemData(), getSpotifyItemData(), getYoutubeItemData());
+        return Objects.hash(super.hashCode(), getItunesItemData(), getMediaRssItemData(), getPodcastItemData(), getPscItemData(), getYoutubeItemData());
     }
 }

src/main/java/com/apptasticsoftware/rssreader/module/spotify/SpotifyItemData.java

@@ -1,6 +1,4 @@
 package com.apptasticsoftware.rssreader.module.spotify;
 
 public interface SpotifyItemData {
-
-    SpotifyItemData getSpotifyItemData();
 }

src/main/java/com/apptasticsoftware/rssreader/module/spotify/internal/SpotifyItemDataImpl.java

@@ -9,12 +9,10 @@
 import com.apptasticsoftware.rssreader.module.psc.PscItemData;
 import com.apptasticsoftware.rssreader.module.psc.internal.PscItemDataImpl;
 import com.apptasticsoftware.rssreader.module.spotify.SpotifyItem;
-import com.apptasticsoftware.rssreader.module.spotify.SpotifyItemData;
 
 import java.util.Objects;
 
 public class SpotifyItemImpl extends ItemImpl implements SpotifyItem {
-    private final SpotifyItemData spotifyData = new SpotifyItemDataImpl();
     private final ItunesItemData itunesData = new ItunesItemDataImpl();
     private final MediaRssItemData mediaRssData = new MediaRssItemDataImpl();
     private final PscItemData pscData = new PscItemDataImpl();
@@ -23,11 +21,6 @@ public SpotifyItemImpl(DateTimeParser dateTimeParser) {
         super(dateTimeParser);
     }
 
-    @Override
-    public SpotifyItemData getSpotifyItemData() {
-        return spotifyData;
-    }
-
     @Override
     public ItunesItemData getItunesItemData() {
         return itunesData;
@@ -48,11 +41,11 @@ public boolean equals(Object o) {
         if (o == null || getClass() != o.getClass()) return false;
         if (!super.equals(o)) return false;
         SpotifyItemImpl that = (SpotifyItemImpl) o;
-        return Objects.equals(getSpotifyItemData(), that.getSpotifyItemData()) && Objects.equals(getItunesItemData(), that.getItunesItemData()) && Objects.equals(getMediaRssItemData(), that.getMediaRssItemData()) && Objects.equals(getPscItemData(), that.getPscItemData());
+        return Objects.equals(getItunesItemData(), that.getItunesItemData()) && Objects.equals(getMediaRssItemData(), that.getMediaRssItemData()) && Objects.equals(getPscItemData(), that.getPscItemData());
     }
 
     @Override
     public int hashCode() {
-        return Objects.hash(super.hashCode(), getSpotifyItemData(), getItunesItemData(), getMediaRssItemData(), getPscItemData());
+        return Objects.hash(super.hashCode(), getItunesItemData(), getMediaRssItemData(), getPscItemData());
     }
 }

src/main/java/com/apptasticsoftware/rssreader/module/spotify/internal/SpotifyItemImpl.java

@@ -86,7 +86,7 @@ void example1(AbstractRssReader<SpotifyChannel, SpotifyItem> feedReader) {
     @SuppressWarnings("java:S5961")
     void equalsContract() {
         EqualsVerifier.simple().forClass(SpotifyChannelImpl.class).withNonnullFields("spotifyData", "itunesData", "mediaRssData").withIgnoredFields("dateTimeParser").withIgnoredFields("category").withNonnullFields("categories").withIgnoredFields("syUpdatePeriod").withIgnoredFields("syUpdateFrequency").verify();
-        EqualsVerifier.simple().forClass(SpotifyItemImpl.class).withNonnullFields("spotifyData", "itunesData", "mediaRssData").withIgnoredFields("defaultComparator").withIgnoredFields("dateTimeParser").withIgnoredFields("category").withNonnullFields("categories").withIgnoredFields("enclosure").withNonnullFields("enclosures").verify();
+        EqualsVerifier.simple().forClass(SpotifyItemImpl.class).withNonnullFields("itunesData", "mediaRssData").withIgnoredFields("defaultComparator").withIgnoredFields("dateTimeParser").withIgnoredFields("category").withNonnullFields("categories").withIgnoredFields("enclosure").withNonnullFields("enclosures").verify();
     }
 
     private static Stream<? extends Arguments> feedReaderArguments() {