Release 4.0.5.0 (#2858)

* minor fixed for modlist-report cli usage and make it automatic after compilation

* added tickbox option to auto-generate report

* another another othergames fix

* experimental speedup maybe

* image cache optimization on gallery

* some fixes for failing gallery images

* Update Game.cs

* Update GameRegistry.cs

* reverse exclude filter for contains mods

formatting

* retry fix

* update CHANGELOG.md

* update workflow version for NuGet releases

---------

Co-authored-by: JanuarySnow <bobfordiscord12@gmail.com>
Co-authored-by: Maelstrom <Inolongerfearpoison@gmail.com>

Author: 3 people

.github/workflows/tests.yaml

@@ -7,7 +7,7 @@ on:
     branches: [ main ]
 
 env:
-  VERSION: 4.0.2.0
+  VERSION: 4.0.5.0
 
 jobs:
   build:

CHANGELOG.md

@@ -1,13 +1,21 @@
 ### Changelog
 
-### Version - 4.0.4.1 - 9/10/2025
+#### Version - 4.0.5.0 - 11/04/2025
+* Added checkbox for automatically generating a modlist-report for analyzing the metadata of the resulting modlist file ([@JanuarySnow](https://www.github.com/JanuarySnow))
+* Added option to inverse the mod search filter in the gallery ([@JanuarySnow](https://www.github.com/JanuarySnow))
+* Added game MetaData for Dragon's Dogma 2 ([@Maelstrom8](https://github.com/Maelstrom8))
+* Optimized Performance ([@JanuarySnow](https://www.github.com/JanuarySnow))
+* Fixed an installation issue when using other Games as sources ([@JanuarySnow](https://www.github.com/JanuarySnow))
+* Fixed the retry button deleting stuff it shouldn't, causing unfinished installations being reported as completed ([@JanuarySnow](https://www.github.com/JanuarySnow))
+
+#### Version - 4.0.4.1 - 9/10/2025
 * Hotfix for the game file sourcing now suddenly requiring other games to be installed on modlists that don't actually use file sourcing from other games ([@JanuarySnow](https://www.github.com/JanuarySnow))
 
 #### Version - 4.0.4.0 - 9/7/2025
 * Fixed the Nexus OAuth token never being refreshed upon starting installation or during downloads
   * This could lead to issues after having not logged back into Nexus for 6 hours after your initial login
 * Fixed an issue with the Google Drive downloader not being able to download files when not prompted with a harmful file warning
-* Fixed Wabbajack not properly sourcing files from other installed games (for example when using Skyrim SE DLC on Skyrim VR modlists) ([@JanuarySnow](https://www.github.com/JanuarySnow)])
+* Fixed Wabbajack not properly sourcing files from other installed games (for example, when using Skyrim SE DLC on Skyrim VR modlists) ([@JanuarySnow](https://www.github.com/JanuarySnow)])
 * Fixed Wabbajack crashing when navigating the 'Has Mod(s)' filter in the gallery with arrow keys
 
 #### Version - 4.0.3.0 - 7/18/2025

Wabbajack.App.Wpf/App.xaml.cs

@@ -33,6 +33,7 @@
 using Wabbajack.Services.OSIntegrated;
 using Wabbajack.UserIntervention;
 using Wabbajack.Util;
+using Wabbajack.Common;
 using Ext = Wabbajack.Common.Ext;
 
 namespace Wabbajack;
@@ -43,9 +44,11 @@ namespace Wabbajack;
 public partial class App
 {
     private IHost _host;
+    private TimerResolution? _timerRes;
 
     private void OnStartup(object sender, StartupEventArgs e)
     {
+        _timerRes = new TimerResolution(1);
         if (IsAdmin())
         {
             var messageBox = MessageBox.Show("Don't run Wabbajack as Admin!", "Error", MessageBoxButton.OK, MessageBoxImage.Error, MessageBoxResult.OK, MessageBoxOptions.DefaultDesktopOnly);
@@ -191,6 +194,7 @@ private bool GrantFullControlOverDir(AbsolutePath path)
 
     protected override void OnExit(ExitEventArgs e)
     {
+        _timerRes?.Dispose();
         base.OnExit(e);
     }
 

Wabbajack.App.Wpf/Settings.cs

@@ -104,4 +104,5 @@ public class GalleryFilterSettings
     public bool IncludeUnofficial { get; set; }
     public bool OnlyInstalled { get; set; }
     public string Search { get; set; }
+    public bool ExcludeMods { get; set; }
 }

Wabbajack.App.Wpf/Util/ImageCacheManager.cs

@@ -25,50 +25,57 @@ public class ImageCacheManager
 
     private async Task SaveImage(Hash hash, MemoryStream ms)
     {
-        var path = _imageCachePath.Combine(hash.ToHex());
-        await using var fs = new FileStream(path.ToString(), FileMode.Create, FileAccess.Write);
-        ms.WriteTo(fs);
+        var path = PathFor(hash);
+        ms.Position = 0;
+        await using var fs = new FileStream(path.ToString(), FileMode.Create, FileAccess.Write, FileShare.Read);
+        await ms.CopyToAsync(fs);
     }
-    private async Task<(bool, MemoryStream)> LoadImage(Hash hash)
+
+    private async Task<(bool ok, MemoryStream stream)> LoadImage(Hash hash)
     {
-        MemoryStream imageStream = null;
-        var path = _imageCachePath.Combine(hash.ToHex());
-        if (!path.FileExists())
-        {
-            return (false, imageStream);
-        }
+        var path = PathFor(hash);
+        if (!path.FileExists()) return (false, null);
 
-        imageStream = new MemoryStream();
-        await using var fs = new FileStream(path.ToString(), FileMode.Open, FileAccess.Read);
-        await fs.CopyToAsync(imageStream);
-        return (true, imageStream);
+        var ms = new MemoryStream();
+        await using var fs = new FileStream(path.ToString(), FileMode.Open, FileAccess.Read, FileShare.Read);
+        await fs.CopyToAsync(ms);
+        return (true, ms);
     }
 
+    private AbsolutePath PathFor(Hash hash) => _imageCachePath.Combine(hash.ToHex());
+
     public ImageCacheManager(ILogger<ImageCacheManager> logger, Services.OSIntegrated.Configuration configuration)
     {
         _logger = logger;
         _configuration = configuration;
         _imageCachePath = _configuration.ImageCacheLocation;
         _imageCachePath.CreateDirectory();
-        
+
         RxApp.TaskpoolScheduler.ScheduleRecurringAction(_pollInterval, () =>
         {
-            foreach (var (hash, cachedImage) in _cachedImages)
+            foreach (var (hash, cached) in _cachedImages)
             {
-                if (!cachedImage.IsExpired()) continue;
-                
+                if (!cached.IsExpired()) continue;
+
                 try
                 {
                     _cachedImages.TryRemove(hash, out _);
-                    File.Delete(_configuration.ImageCacheLocation.Combine(hash).ToString());
+                    var path = PathFor(hash);
+                    if (path.FileExists())
+                    {
+                        try { File.Delete(path.ToString()); }
+                        catch (IOException) {  }
+                        catch (UnauthorizedAccessException) {  }
+                    }
                 }
                 catch (Exception ex)
                 {
-                    _logger.LogError("Failed to delete cached image {b64}", hash);
+                    _logger.LogError(ex, "Failed to delete cached image {hashHex}", hash.ToHex());
                 }
             }
         });
-        
+
+
     }
 
     public async Task<bool> Add(string url, BitmapImage img)
@@ -105,6 +112,6 @@ public class CachedImage(BitmapImage image)
     private readonly TimeSpan _cacheDuration = TimeSpan.FromMinutes(5);
 
     public BitmapImage Image { get; } = image;
-    
-    public bool IsExpired() => _cachedAt - DateTime.Now > _cacheDuration;
+
+    public bool IsExpired() => DateTime.Now - _cachedAt > _cacheDuration;
 }

Wabbajack.App.Wpf/Util/UIUtils.cs

@@ -19,6 +19,8 @@
 using Wabbajack.DTOs;
 using Exception = System.Exception;
 using SharpImage = SixLabors.ImageSharp.Image;
+using SixLabors.ImageSharp.Processing;
+using SixLabors.ImageSharp.Metadata.Profiles.Icc;
 
 namespace Wabbajack;
 
@@ -34,6 +36,7 @@ public static BitmapImage BitmapImageFromStream(Stream stream)
         img.StreamSource = stream;
         img.EndInit();
         img.Freeze();
+        stream.Position = 0;
         return img;
     }
 
@@ -104,40 +107,86 @@ public static AbsolutePath OpenFileDialog(string filter, string initialDirectory
         return default;
     }
 
-    public static IObservable<BitmapImage> DownloadBitmapImage(this IObservable<string> obs, Action<Exception> exceptionHandler,
-        LoadingLock loadingLock, HttpClient client, ImageCacheManager icm)
+    public static IObservable<BitmapImage> DownloadBitmapImage(
+    this IObservable<string> obs,
+    Action<Exception> exceptionHandler,
+    LoadingLock loadingLock,
+    HttpClient client,
+    ImageCacheManager icm)
     {
+        const int MaxConcurrent = 8;
+
         return obs
             .ObserveOn(RxApp.TaskpoolScheduler)
-            .SelectTask(async url =>
+            .Select(url => Observable.FromAsync(async () =>
             {
                 using var ll = loadingLock.WithLoading();
                 try
                 {
                     var (cached, cachedImg) = await icm.Get(url);
                     if (cached) return cachedImg;
 
-                    await using var stream = await client.GetStreamAsync(url);
+                    await using var net = await client.GetStreamAsync(url);
 
-                    using var pngStream = new MemoryStream();
-                    using (var sharpImg = await SharpImage.LoadAsync(stream))
+                    using var sharpImg = await SixLabors.ImageSharp.Image.LoadAsync<SixLabors.ImageSharp.PixelFormats.Bgra32>(net);
+                    const int targetPx = 512;
+                    if (sharpImg.Width > targetPx || sharpImg.Height > targetPx)
                     {
-                        await sharpImg.SaveAsPngAsync(pngStream);
+                        var scale = Math.Min((float)targetPx / sharpImg.Width, (float)targetPx / sharpImg.Height);
+                        var nw = (int)(sharpImg.Width * scale);
+                        var nh = (int)(sharpImg.Height * scale);
+                        sharpImg.Mutate(x => x.Resize(nw, nh));
                     }
 
+                    using var pngStream = new MemoryStream(capacity: 64 * 1024);
+                    var fastPng = new SixLabors.ImageSharp.Formats.Png.PngEncoder
+                    {
+                        CompressionLevel = SixLabors.ImageSharp.Formats.Png.PngCompressionLevel.NoCompression,
+                        FilterMethod = SixLabors.ImageSharp.Formats.Png.PngFilterMethod.None,
+                        BitDepth = SixLabors.ImageSharp.Formats.Png.PngBitDepth.Bit8,
+                        ColorType = SixLabors.ImageSharp.Formats.Png.PngColorType.RgbWithAlpha
+                    };
+                    try
+                    {
+                        await sharpImg.SaveAsPngAsync(pngStream, fastPng);
+                    }
+                    catch (IndexOutOfRangeException)
+                    {
+                        // SME banner failed to load, buggy metadata in log, so this crap removes it
+                        sharpImg.Metadata.IccProfile = null;
+                        sharpImg.Metadata.ExifProfile = null;
+                        sharpImg.Metadata.XmpProfile = null;
+                        foreach (var f in sharpImg.Frames)
+                        {
+                            f.Metadata.IccProfile = null;
+                            f.Metadata.ExifProfile = null;
+                            f.Metadata.XmpProfile = null;
+                        }
+
+                        pngStream.SetLength(0);
+                        pngStream.Position = 0;
+                        await sharpImg.SaveAsPngAsync(pngStream, fastPng);
+                    }
+
+                    pngStream.Position = 0;
+
                     var img = BitmapImageFromStream(pngStream);
+
                     await icm.Add(url, img);
+
                     return img;
                 }
                 catch (Exception ex)
                 {
                     exceptionHandler(ex);
                     return default;
                 }
-            })
+            }))
+            .Merge(MaxConcurrent) // limit concurrency
             .ObserveOnGuiThread();
     }
 
+
     /// <summary>
     /// Format bytes to a greater unit
     /// </summary>

Wabbajack.App.Wpf/ViewModels/Compiler/CompilerSettingsVM.cs

@@ -40,6 +40,7 @@ public CompilerSettingsVM(CompilerSettings cs)
         AlwaysEnabled = cs.AlwaysEnabled.ToHashSet();
         Version = cs.Version?.ToString() ?? "";
         Description = cs.Description;
+        AutoGenerateReport = cs.AutoGenerateReport;
     }
 
     [Reactive] public bool ModlistIsNSFW { get; set; }
@@ -48,6 +49,8 @@ public CompilerSettingsVM(CompilerSettings cs)
     [Reactive] public Game Game { get; set; }
     [Reactive] public AbsolutePath OutputFile { get; set; }
 
+    [Reactive] public bool AutoGenerateReport { get; set; } = false;
+
     [Reactive] public AbsolutePath ModListImage { get; set; }
     [Reactive] public bool UseGamePaths { get; set; }
 
@@ -133,7 +136,8 @@ public CompilerSettings ToCompilerSettings()
             Ignore = Ignore.ToArray(),
             AlwaysEnabled = AlwaysEnabled.ToArray(),
             Version = System.Version.Parse(Version),
-            Description = Description
+            Description = Description,
+            AutoGenerateReport = AutoGenerateReport
         };
     }
     public AbsolutePath CompilerSettingsPath